From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA4DCD13D3 for ; Mon, 18 Sep 2023 07:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0B6D6B0295; Mon, 18 Sep 2023 03:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBCA26B0297; Mon, 18 Sep 2023 03:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B368A6B0298; Mon, 18 Sep 2023 03:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A33306B0295 for ; Mon, 18 Sep 2023 03:33:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7CAC1140BD2 for ; Mon, 18 Sep 2023 07:33:06 +0000 (UTC) X-FDA: 81248901972.13.893B576 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf28.hostedemail.com (Postfix) with ESMTP id 010C5C0003 for ; Mon, 18 Sep 2023 07:33:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rwf73w9n; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf28.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695022383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dbgURMvRB5vglPwXNEinmDiIBwhTERpqxwujlCbmGpc=; b=HIyS0/zxI9K4TIGeXRuol+Oqiq+pCvSdeTvHdoEnzfMFSQfbAnjW40MeY9ISRHo8MvAAVA dtJN7LlBW5+ujXe5wF4amGHln91PveFwQk2CmZZfO3yRdgFVdtj4FgsJZMMer84FVMy3ab R6qUDTu/6niDrvPBIVMaM7Elo1b43ug= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rwf73w9n; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf28.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695022383; a=rsa-sha256; cv=none; b=6SJ2BnQG4rGsGdJfhnATKrJyKebjcBoNj5mwDSnUFqb5sMkRyQN6b6fexpAXfjksg+kvih s3p6CTQvJ862Vs7JrbzJ710mgMmX3DiwDNtLMeoR/H25UJ1//Os8XWx1KehGHe1jE4FJsh KyvEvnuzadBIbB/AnisJVPkuUsY+E+k= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230918073300euoutp02bd1b0c6061e750453bdafe700e795ad8~F7d-TK8Pz2905929059euoutp02H for ; Mon, 18 Sep 2023 07:33:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230918073300euoutp02bd1b0c6061e750453bdafe700e795ad8~F7d-TK8Pz2905929059euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695022380; bh=dbgURMvRB5vglPwXNEinmDiIBwhTERpqxwujlCbmGpc=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=rwf73w9ncRjC3brjfD2715hl1hXTN9ifCUZWS6AqyxjK1saqp/dwicu0ASeLR8B9v M8ZAO9HxO0PODwhFOtBXAkg7xHFTwD+U3Tc/kZ5euqBdpJY35IahXFk91ADBGIuXVq GpcVCsPJrdp3OqBVb7PXSAHL1CgqA4BkLxv2gXbk= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230918073300eucas1p1c9a31881336f26a495b69de4e7d0c071~F7d-DshJ-1309713097eucas1p1g; Mon, 18 Sep 2023 07:33:00 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 6E.9B.11320.B2DF7056; Mon, 18 Sep 2023 08:33:00 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230918073259eucas1p1cfcfbfd6a8c37c7cebd0b4734beffbc5~F7d_ue6-f0660306603eucas1p1s; Mon, 18 Sep 2023 07:32:59 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230918073259eusmtrp287fc632a8e38eea9a64656ffaf30256d~F7d_s7iJo3259532595eusmtrp2T; Mon, 18 Sep 2023 07:32:59 +0000 (GMT) X-AuditID: cbfec7f4-97dff70000022c38-9b-6507fd2bc863 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 28.AB.10549.B2DF7056; Mon, 18 Sep 2023 08:32:59 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230918073259eusmtip2f600a41fd36323b49a478548a33828b6~F7d_frRyu1441814418eusmtip2j; Mon, 18 Sep 2023 07:32:59 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 18 Sep 2023 08:32:58 +0100 Received: from CAMSVWEXC02.scsc.local ([::1]) by CAMSVWEXC02.scsc.local ([fe80::3c08:6c51:fa0a:6384%13]) with mapi id 15.00.1497.012; Mon, 18 Sep 2023 08:32:58 +0100 From: Daniel Gomez To: David Hildenbrand , "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "willy@infradead.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" CC: "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 0/6] shmem: high order folios support in write path Thread-Topic: [PATCH 0/6] shmem: high order folios support in write path Thread-Index: AQHZ57ou5Qxd50H2CkCAi/G4rRLLzbAb8riAgAQxuQA= Date: Mon, 18 Sep 2023 07:32:57 +0000 Message-ID: <20230918073252.7nljdakmdk5kcpdt@sarkhan> In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [106.110.32.103] Content-Type: text/plain; charset="us-ascii" Content-ID: <7FB5FC383E12CC4DB148D262FACCE602@scsc.local> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUxTZxjd297eXmraXFoiT1icpmxjo7UI6naZylAxXlmWmOzHAppoxTvK N2utTmIMokamia2bASkkYCcgyCRcwRAsEIvCKh/tIAPGmA65bKSkdPIVPoTNcmvSf+d5znnP eU7yEkL5C1EYkZZ9itFnazOVuAR72LnUt1W9Kma2cU8QVVZfh1P3/jTh1Hz9spAa4GTUxMx1 jGodUVG2VgdGDbSU4dTzuv9EVMvrZjE1bJ5AVNW8V0w9arDi1MpiGR4vo0vzf8XoCtZIP7gb SQ/0Gmm29nucZmd+ENO/3FrBaG/bbzg9y753OChZsvskk5l2mtFHxR2X6LoW/kC5bPB3tjGH MB9dk11FQQSQO2D8ygS6iiSEnLyLwN3jFvPDHILfC6b9zCyC1qeV+Nsns51eEU9UI2ivuif2 EeuqzqWjPNGDoKD7J5wfahAU/tUq8qlw8mNoc7DrISFkhwicdYWYjxCSSVBkYtetFORBqC7o Qz4cQtLw+MZNEY8/g3+9JW80BIGRH8DiVK5vLSV3wkhpu8C3DiLj4M6Pp31rRG6ClzXLYt49 FEa4cgHfIBispTYhjzfCWsuYv5kaeoc4xONt0FTZhvFYCa8LbyPeRw0Vj2ZwHseCZ9Tl91dB 1e0pIX9OMDhKOMxXEchKCXDWm37TBPhn6I4/TAHurkaxGaktAfdZAjIsARmWgAxLQEYFEtWi UMZoyEplDDHZzBmNQZtlMGanalJyslj05g92r3XNNaNq9yuNHQkIZEdACJUh0pJonJFLT2rP 5jH6nGN6YyZjsKN3CUwZKlXtcaTIyVTtKSaDYXIZ/VtWQASF5Qsul7tMxq8S8y90P3tfl3Zr skG5qenE8CHdlw1rggMxuheRk87V5UOxyWcU33xd/LLf+Q5TQH0x5m3cmJLLVcSVTiLNlowr NvdcvXGhpnn7wtJHRy6GN6uSv43bn25z7ew3JKKExydGP+nvkBbLbeO1ERGePI/VUbP3Wui5 nPN7NQn2HfRib5RMZi9R7w/veZCYpAqL8MDuss/VU+HTpqSmYUef69N9MY3BK1T62dXYxvOX m2RDm53P4m9cGhw8vD3aU1882h8Rbn6e3q4o3zDhzHkybuqwmu2O6/ddGd3xYwej5NNF52Tu 1V37PuR+Nv9tmUesosiWMs8N2jbXDucpMYNOGx0p1Bu0/wOXt2Ji8gMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOKsWRmVeSWpSXmKPExsVy+t/xe7raf9lTDTYvVLGYs34Nm8Xqu/1s Fl/X/2K2uPyEz+Lppz4Wi723tC327D3JYnF51xw2i3tr/rNa7Pqzg93ixoSnjBbLvr5nt9i9 cRGbxe8fc9gc+DxmN1xk8ViwqdRj8wotj8tnSz02repk89j0aRK7x4kZv1k83u+7yubxeZNc AGeUnk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6RiaWeobF5rJWRqZK+nU1Kak5mWWqRvl2CXsbx b7cZCzYJVux5eJK5gbGbr4uRk0NCwETi87H3rF2MXBxCAksZJR7NvcoIkZCR2PjlKiuELSzx 51oXG0TRR0aJ968OskM4ZxglFu7eBdW+klHi5O4lbCAtbAKaEvtObgKrEhE4yCrR/fQVE0iC WSBSYlo/SIKTQ1jAXWJ50zmwfSICHhIHJ05hhbCtJD68nwlUw8HBIqAq8eN1AUiYV8BU4tbs /WBjhAQOM0o07LEAKeEUsJNYMrkMJMwoICvxaOUvdohN4hK3nsxngvhAQGLJnvPMELaoxMvH /6A+05E4e/0J1McGEluX7mOBsJUk/nQsZISYoyOxYPcnNgjbUuLtnQtQ87Ulli18zQxxmqDE yZlPWCYwysxCsnoWkvZZSNpnIWmfhaR9ASPrKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMAU t+3Yz807GOe9+qh3iJGJg/EQowQHs5II70xDtlQh3pTEyqrUovz4otKc1OJDjKbAkJvILCWa nA9Msnkl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp2ampBalFMH1MHJxSDUw9R2977tHt u7zI1qvx3Dod3s2SM/lsLEM+1mcaNed3dUgfe/55c7jqN/v/L9Zl3hTb5PH7sWDhp8ur+8Vv TOPc4/FVQIH98plyFb1bXPdLLmr5XskWC5z/MdA4adGVHxb80i8/tHW6V7DNUnhVYrzmoUHj /1uyGx9fn3QiwensvRZPq3/ZR/rTDsbez/odtMArhTP/6N3Kz+lFFzfXR2RZfLr8sUm99Mez lX8eWd5982/+Br1TwbVLZe047t2IfrW6ZJ9b9hM2pu7Dz7NOl+65cHz7zI+HVT4G6X1gCHWc 4nnvdAD/B70rwhFpcyeHyBf+PDs9aU7/4n6LVdW5V1cvNcqyXXBa4H7xJrkyzuizSizFGYmG WsxFxYkAyQ+4L/oDAAA= X-CMS-MailID: 20230918073259eucas1p1cfcfbfd6a8c37c7cebd0b4734beffbc5 X-Msg-Generator: CA X-RootMTR: 20230915095123eucas1p2c23d8a8d910f5a8e9fd077dd9579ad0a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230915095123eucas1p2c23d8a8d910f5a8e9fd077dd9579ad0a References: <20230915095042.1320180-1-da.gomez@samsung.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 010C5C0003 X-Stat-Signature: ukf9jafrbed1t8fw7zmyy6c3tyswua6o X-Rspam-User: X-HE-Tag: 1695022382-988634 X-HE-Meta: U2FsdGVkX19YJX22CmoyiUyiEAvf23L8d030OdgR+LwT9nmbnoo7aDin5D+lcnbOrzZxn8UgU/8bYLtIkWq89RD796UdlTu8onW4g91OJbZo/144hJmQ+NQugD1PtFRqJScBj3IPz9Xh+ccl5/RaSrGaBtyTgWOgO1BSs8TuCUMYHT1a4hkg6y8T/8JRF1RvIqsjKURJY0rK9CFW7gFzoSkfYfuNa3i2puW4Z9SONzMq2DrbNlpTaITgyIK+58gKcRcU08ZjGvI6rOF2mraY9f7R5D1+wm5ug2jnPRc4qKxdo3zO1JrTidZZuo/mGJd0oGq5VOLUNQssxlMwsrEuQQ9M8D3nw7nnOuzDszV8wnLG3Ao+NugUhIYg2Jc1AYjbbTAp6D72eWESF2uoWPBArT/9kGX+/auIbhpK4gLQwnyIq/BQcMTOfz551oet7ND4kvDiff4/03WwTVaUGinP+CwW5/thgVsh4hxju66JzrRsp9C1BJxm5GIwp/bG5F0pakAj0v2kBMxSiQpPi/OIqxif4v+ybBU0yo8R1I6Mbr+TwqJ6ZxlLp3VAAvw3t2wAkBkUayTBUPHWEFMoSGMvx2C8oY4tn3oROCSktPvfl1ywdqAvxsKWzG8L81PJBvkGmI9+gTLFO6TuF1vrzp+dkEQWQuyCweKNq/pkCDpIh4qqbtLUH/WTVCx0HERfj+m9ZP2SMkkioxMIlUgIUTMK7+Dq27YwNV8tNw30tYdphO0vHB1y8jxMFoX1alw5Auh8Tojm8IWEsEgCMzjI78M1RDmeFA7+RwD912wnjgnAk2pSD6tf9UAbyv0vD7ERZB0O5lkb28CKSnDPL9EF9z9GzZ1HZ0qxP91IFzp76j0/jZUcFlOC90/21gpgw70BDTrIpAjlzB2NcuOpK17Sia1KN2pF+W5xGjK4ZdG7pBzPECN5RMytLFRhLXuDJ1KOKm0bt9DK8mScy50L0f13wX4 9+CE9L17 pG7pav2yKz8lJRhOq619I4RB9Ejau5vg+BqAkVkNVELl6Yg7+EC4sqiCC8+2fGTPdMKl9/Au57GbX37rUWgGLgf5NtYdIXBtCMZpR2IAeyMzznhQsTgHSr/yI0LsVgUX/eobtRCW+526KIQ6eIPH5L5LgdUuFTmTtieHj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 05:29:51PM +0200, David Hildenbrand wrote: > On 15.09.23 11:51, Daniel Gomez wrote: > > This series add support for high order folios in shmem write > > path. > > > > This is a continuation of the shmem work from Luis here [1] > > following Matthew Wilcox's suggestion [2] regarding the path to take > > for the folio allocation order calculation. > > > > [1] RFC v2 add support for blocksize > PAGE_SIZE > > https://lore.kernel.org/all/ZHBowMEDfyrAAOWH@bombadil.infradead.org/T/#= md3e93ab46ce2ad9254e1eb54ffe71211988b5632 > > [2] https://lore.kernel.org/all/ZHD9zmIeNXICDaRJ@casper.infradead.org/ > > > > Patches have been tested and sent from next-230911. They do apply > > cleanly to the latest next-230914. > > > > fsx and fstests has been performed on tmpfs with noswap with the > > following results: > > - fsx: 2d test, 21,5B > > - fstests: Same result as baseline for next-230911 [3][4][5] > > > > [3] Baseline next-230911 failures are: generic/080 generic/126 > > generic/193 generic/633 generic/689 > > [4] fstests logs baseline: https://gitlab.com/-/snippets/3598621 > > [5] fstests logs patches: https://gitlab.com/-/snippets/3598628 > > > > There are at least 2 cases/topics to handle that I'd appreciate > > feedback. > > 1. With the new strategy, you might end up with a folio order matching > > HPAGE_PMD_ORDER. However, we won't respect the 'huge' flag anymore if > > THP is enabled. > > 2. When the above (1.) occurs, the code skips the huge path, so > > xa_find with hindex is skipped. > > Similar to large anon folios (but different to large non-shmem folios in = the > pagecache), this can result in memory waste. > > We discussed that topic in the last bi-weekly mm meeting, and also how to > eventually configure that for shmem. > > Refer to of a summary. [1] > > [1] https://lkml.kernel.org/r/4966f496-9f71-460c-b2ab-8661384ce626@arm.co= m Thanks for the summary David (I was missing linux-MM from kvack in lei). I think the PMD_ORDER-1 as max would suffice here to honor/respect the huge flag. Although, we would end up having a different max value than pagecache/readahead. > > -- > Cheers, > > David / dhildenb >=