From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1956CD37B0 for ; Mon, 18 Sep 2023 07:26:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 762976B026F; Mon, 18 Sep 2023 03:26:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 712AE6B0270; Mon, 18 Sep 2023 03:26:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603BA6B0271; Mon, 18 Sep 2023 03:26:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 501C96B026F for ; Mon, 18 Sep 2023 03:26:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 16063120B9F for ; Mon, 18 Sep 2023 07:26:31 +0000 (UTC) X-FDA: 81248885382.06.EC2FE3C Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [216.200.240.184]) by imf09.hostedemail.com (Postfix) with ESMTP id 77779140014 for ; Mon, 18 Sep 2023 07:26:27 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=iXQBjyY+; spf=pass (imf09.hostedemail.com: domain of haibo.li@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=haibo.li@mediatek.com; dmarc=pass (policy=quarantine) header.from=mediatek.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695021989; a=rsa-sha256; cv=none; b=iLTu8FDbHuq6bFKWw9sMyKFWWD7zgNbN1lYKt2aSpqsqtZWR1SJ8x0XGyua9dc86luVssR q3Yk97+M2u7CDq7Dqmcs6kEvm8DnX5CgFgrnT1WwfgZhNqZslp2oMWnWq4HzbXRonspRjY xGCmMWq3UVuvUB2Qv/5jO+Mxz/0/8NM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=iXQBjyY+; spf=pass (imf09.hostedemail.com: domain of haibo.li@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=haibo.li@mediatek.com; dmarc=pass (policy=quarantine) header.from=mediatek.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695021989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pmAQXDi1eFJFIz1BbU82J1+CnIbylJEmn229iHCJQIs=; b=Gb5Fd51ptZhuQIHAdTkVutaTBABZXz2moRSnS9uF870Pz2oot8QAzUR9UPeUBhs85Z0lvA zysYspjV/eKLDrPO0efcMK/za2iCkMguCnfTdyzLHORPCCvduRirNyiVCqBqnkHgCioTf6 Q2PIehyhjNzaktfUCPxlp+jtfv8INk0= X-UUID: aac468a255f411ee9b7791016c24628a-20230918 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=pmAQXDi1eFJFIz1BbU82J1+CnIbylJEmn229iHCJQIs=; b=iXQBjyY+RHy3WfgWsRoEQk9ClNi24G+J9sMkQbBwomqELi5Sc59HCFnuCrY217QGTtK0HQtbfE2ZrXZVrjcGPKrqVwRspTafgyhE/84ceszmRUVXQszV2++LCssmXe375Mw790g8n6d5VhcdE3VSrLbuNxPhzjxz7qbi4x7e9/4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:27032722-6e89-4ea1-b03d-6d964807bdc2,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:0ad78a4,CLOUDID:c4a7f5be-14cc-44ca-b657-2d2783296e72,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:817|102,TC:nil,Content:0|-5,EDM:-3,I P:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 1,FCT|NGT X-CID-BAS: 1,FCT|NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: aac468a255f411ee9b7791016c24628a-20230918 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1766610083; Mon, 18 Sep 2023 00:26:22 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 18 Sep 2023 15:25:46 +0800 Received: from mszsdtlt102.gcn.mediatek.inc (10.16.4.142) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 18 Sep 2023 15:25:45 +0800 From: Haibo Li To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal Date: Mon, 18 Sep 2023 15:25:45 +0800 Message-ID: <20230918072545.87653-1-haibo.li@mediatek.com> X-Mailer: git-send-email 2.34.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 77779140014 X-Stat-Signature: s8ozjg85icbwqzmk6xuhzh4txdaymqnj X-Rspam-User: X-HE-Tag: 1695021987-412281 X-HE-Meta: U2FsdGVkX1/6aStZrgCUe4O8VrOxcUaVBzmFWo8+VHfOGQY8URtz1nFLeRHEEPrZ5r/SF05N2uX5JgUJZPfOxjRiTbPMmj9HjEcAivil0UwoQq/c6GOtwDhybt8xCmEy7mxVrsmtLjKCt9sikQxZQQP5TCghCiZ4rjlVyyOq5S+tOn95E7Csndln4KUYDHN+07T1NOOsPW+4HstOi4BZG9WkPLiSgEYRPG0E484OPdR6cuxb9LI5pcx8r3X2gYHPUYt52B/Ho2yPjWkS/IFQY0nHpWke5pid5aO/Wge9+IUdKUoMNzW8j7Y3ouap10a2PJ8kbGYARKSdP1EQCE3kOAE9vMefRxzNKE+dm8ib5Cub0rBsxSlxzxUzFwfRzoIfYB0vZEME6gtjX8Pygtba0pyOCya/uXLFLpfZGwtBj8BBbb9R2GDry+Y9Vw0d7wJuzUUHQ0bQP6MT97N8D2Bw3W0Hsm4PgsCnsDK9xtd4KigP2d1UbK+Ba4BAs0n53V1dhXWMcyVNun49+tJV2wb6FGQtKTbse7/AM1hLdqs44NbGKIwHW9xNwwf6SPKVp+fd84PqJlRBkdu/w434rCXjpnrSyhhGW5ppTjJBQ7+Ah4zStrXASQHw4OfWBFUahIbycdvrDI75Nk1ykE2rpRjBQbi3bZc3WtIj2F1zUBoS1WhpioefzJ2yuwNCPYhfmEs3iPLTVWaU4NFgONairBBZV0t5iHiqXTYNhV5G45zLaeeKbt52cM4mZ9BJ8nfATk1OeijW5mcZfAHK3hgcOndFXnKFi1DYvtf3znPaHAKKEornJBEESaCQRjUJAxzu7FJjGx3AkSaKKOTzN3mGHHjjyLR30UJvJvlsRmeA0B/W/j/8nGgDP5oKWqlV37/Ulab5G49H2TJcnleWyhcsWRArqzsk5W9E5MQZNNgZ1EgBoykbR3a9ax3myDwSiJ+Y9Crv+RBKTFbvgEnLC9Vi2yC YQjg9kh7 QOoyQVyFKpY5IjrosZ3vMc5GLzfI2wPymDlegsX8t3JLrfPthF+0r+3Xflk3+Gj7upuUiyIYc8Kh+MyyiWQA+rdW2YpdmB8y4H+z29p1eYsGt0b4uXr8vDeQhevYi16euPIRSJaCfQnXsII2EwTfdauw0RBqn/Z08L60h/4wbbX9pMjIGzrkIJSwLPuM1H1Xwy/KJYaQLLt0qvI+kVu0bvRxC5hZFnRGsYOdZhiQxFTDPIA3vZQ/I3skGU7Gt1AIaQsuaNL7E5NTyC7QbwJwRnSIbzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Fri, Sep 15, 2023 at 4:46 AM 'Haibo Li' via kasan-dev > wrote: > > > > The patch checks each shadow address,so it introduces extra overhead. > > Ack. Could still be fine, depends on the overhead. > I do a simple test by reading memory. Read 4096 memory by loop and the reading unit is 8 bytes. __hwasan_load8_noabort is called 512(4096/8) times. Measure the time of memory read. Here is the result on ARM CA7X(repeat 100 times): ---------------min-------max-----avg---- before patch | 77.3ms | 80.6ms | 79.2ms| after patch | 77.2ms | 80.7ms | 79.2ms| ---------------------------------------- There is no obvious drop in this scenario. It may differ in different arch. just for information if you are intrested in it. > But if the message printed by kasan_non_canonical_hook is good enough > for your use case, I would rather stick to that.