From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3B3CD37B0 for ; Mon, 18 Sep 2023 05:43:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D1C76B020D; Mon, 18 Sep 2023 01:43:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05BCB6B020F; Mon, 18 Sep 2023 01:43:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E65096B0213; Mon, 18 Sep 2023 01:43:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D35596B020D for ; Mon, 18 Sep 2023 01:43:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CF451CA763 for ; Mon, 18 Sep 2023 05:43:32 +0000 (UTC) X-FDA: 81248625864.05.A870D3C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id EC3111C000B for ; Mon, 18 Sep 2023 05:43:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gtv90Ler; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695015811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RG3+cLzQkS/xm0Jam8SKL1AbTeeUKGb+cFWE1W4UVek=; b=Hc57aPkBYKtkj1E6fo4tOXNRBch0DqEe9zLs0BVyhT4jco8eRgDzAwZPXU/+aBZVYPmNKy jbeGnwuxo7ObaHlzBcmD09WqOPUEquOYkbuuoEeqnmrHt7GfQFwYqdbhDns0orHOBatWRO fuq1eFOVSGLWQvLmT9f5K6Bf45+tAVE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695015811; a=rsa-sha256; cv=none; b=q2BrN9nqZFhksCbEEHYN/OAhJHhov+fYldG+f49c04p6Xqp++Hq1fMOCBZTCNhGCvBGht9 buzs9XWJKkQ5SEJfB6wK/XxTFEwSwtiwqnIF6QrpT+Ba6t7F7Gwjuz45m8KdWZY88L0ujG qBfo0aTEjSV4/VvNm3Ng2zyWswd9xsw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gtv90Ler; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F307F60EA0; Mon, 18 Sep 2023 05:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74ACAC433C7; Mon, 18 Sep 2023 05:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695015809; bh=YGgUq5DoOzuAKAW768LWuySAzka3BDAbCZW93wDfo0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gtv90Ler6UvXzC9iWDK+pje0FUBajwdK+Cqa9DxQrNdefNV5EjOzM4I89M+nuaTxg tKlViaWm/lwsm2F9kvrsw8QeE9BLkfRyzL+IZxYXgi4N4geDhdvfm0frJ4t8IAr/oq gc/FtIw7+XuyxTxWrtTGmxlB6WODDA5yi5fSNQpEq7/Aaj3GT4JBwTyxLDwH9GDLlQ cEb3aCPgF1Bthd5tdXJJR5iFnML/nWtQyggUVsrA3ZkxUZH4NMyjoR/AoO+3v8YncC HPZ6b/9dwUYUQUXw8VPHUw2uC+4inptwCYxx53ITJP1uVIomisM0+N+awoi0f7Hapv GV6IV6obAt0Hg== From: SeongJae Park To: Jinjie Ruan Cc: sj@kernel.org, akpm@linux-foundation.org, brendan.higgins@linux.dev, feng.tang@intel.com, damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 2/2] mm/damon/core-test: Fix memory leak in damon_new_ctx() Date: Mon, 18 Sep 2023 05:43:26 +0000 Message-Id: <20230918054326.74929-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918051044.3814018-3-ruanjinjie@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 995mejiksa1dwgj4ikujxgdc3tzq78k1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EC3111C000B X-Rspam-User: X-HE-Tag: 1695015810-743832 X-HE-Meta: U2FsdGVkX1/MnC1U+CebTCep6QAfySCDZXHkqHZwuY6t5qEZIi8ZbtAG6G8JluSEEcQrIJBsRtV88Grr6gZCnTn7K710exduntm5g3YF8TGb978uFtjDni+09GD04G5M1DzVEVIi9mgdY4LRQLsDFzpYLhmkKh6iJbqEjStUqrXjIG7Jfi7ip8155iiO53NJ9oUpmrHKfX0yTFxjbW6KnCXaUvFtCzbBmIfIk3/L/3YEC56Hk/IcUa+egGegZlkZbd1dSun2W/jhKPtMSxWKJBhaJYLHoOOk5HRfd28zSlD1ozRHBafhg9B1ltSw8SIJl3FIZN3bNspNkmy9q6KXT8kgpev/GXy4kHxAhMTxk+XI0y9qT4frWoiIc2s3Ts2WdVJxgxkFA5QIek5Q96KaPJRy25n/6YzIaloUyds97a+A0VaEFVWeF6pCRBuGBIbT/dm1lUy+dq+bkvBfKPrhWGnYoOUGoNfVxhIXyKRporoPiYH5mPgsmIBnWcKTxoGTZCJimpwNmbTfP2mGIlMf6ZeRHyJF6zu5jGyxLBKOJoW6JsBhPchwS/vSOQyGacYy8Gb01X7GtoUtfldtTp85UcimCzrNVqTPfoVmMWA/0ASOiV1jr8oVmeQ5iLCCuVY8s5BSFBb0SPXeLlNNp8x/DuBzgfCxi/50VL54PzyXm9pjZRMB5JZNO7/SLIMABMUVotezVCZJeXbdHRUNhwBBtwPEwH5ujX5cl32blj2CiWUijPNE2XIHva6IynU77kMCKyQ48fieimdoWhXi9Ujtg03mgpB6xHFyZs3GLrtsPLuTZsOA9d5BiVGKIRpvDwiCLQ7OmtHstZ/m6voPl+B0WCKAjWUaW6XynaTw5mSVh877sr/LOxSTVOkqyeHHIR2l9mA7JUPiRKPvVGOiK6CeYo5WsVrJYWfZ3o8Lud/brMEMk8P8+FZfw33zpiXsKAn9fDTYFQbYVUjjyRmQJdq y1b9QCTG FIvGoOf623dBVC3jMYqL6D4eU1lBnS7gUv2scjzzNvFel3LVH5/YBZ3jWthCcmTNn4YUD5mhhMt1WqVepK2meUxk4FNl1AaAdkkMkNcaIp3COlTn6rmLNMVQeuxk2x/V2EqFwtPzY6eM3/zVLyT082hYXfFqDR7j7OYXCV3s7W4qC8Z0RoHvOzGVW0qiqDYc9g64FcFvmVCcX1UEfBTizlN/CYFmw6PAJ1P/6dmbme2g/qkcbhWhCoYm+/pB2ReuPeQVAeT8c5Go9DpU5gBZqcKfUYdlLDiVwKKoFsc3F7bxdV5zGv0/DunRVxdFflQSUJfAlVu9TGyFkrXrWighAwhomlAIfzqC3HCBltP+v162Wb+3XSxKnl7zQi+TLZf/cYrE+EehL/86z2WWpnEn8VkHg8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jinjie, On Mon, 18 Sep 2023 13:10:44 +0800 Jinjie Ruan wrote: > The damon_ctx which is allocated by kzalloc() in damon_new_ctx() in > damon_test_ops_registration() and damon_test_set_attrs() are not freed and > it causes below memory leak. So use damon_destroy_ctx() to free it. > > unreferenced object 0xffff2b49c6968800 (size 512): > comm "kunit_try_catch", pid 350, jiffies 4294895294 (age 557.028s) > hex dump (first 32 bytes): > 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ > 00 87 93 03 00 00 00 00 0a 00 00 00 00 00 00 00 ................ > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 > [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 > [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 > [<00000000daf6227b>] damon_test_ops_registration+0x34/0x328 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > unreferenced object 0xffff2b49c1a9cc00 (size 512): > comm "kunit_try_catch", pid 356, jiffies 4294895306 (age 557.000s) > hex dump (first 32 bytes): > 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 ................ > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 > [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 > [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 > [<00000000058495c4>] damon_test_set_attrs+0x30/0x1a8 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 Same to the comment on the first patch of this patchset, simply letting others know the name of the tool you used for making this cool output could be helpful. Could you please add it? Also, I prefer adding four spaces indent to quoted command outputs on commit messages. Could you please add that indentation? Also, I cannot 'git am' this patch on top of mm-unstable[1]. Could you please double check and rebase on latest mm-unstable if I din't miss something? [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-unstable > > Fixes: d1836a3b2a9a ("mm/damon/core-test: initialise context before test in damon_test_set_attrs()") > Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration") > Signed-off-by: Jinjie Ruan > --- > mm/damon/core-test.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h > index 255f8c925c00..ce86ed30fb47 100644 > --- a/mm/damon/core-test.h > +++ b/mm/damon/core-test.h > @@ -266,6 +266,8 @@ static void damon_test_ops_registration(struct kunit *test) > > /* Check double-registration failure again */ > KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL); > + > + damon_destroy_ctx(c); > } > > static void damon_test_set_regions(struct kunit *test) > @@ -342,6 +344,8 @@ static void damon_test_set_attrs(struct kunit *test) > invalid_attrs = valid_attrs; > invalid_attrs.aggr_interval = 4999; > KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); > + > + damon_destroy_ctx(c); > } > > static void damos_test_new_filter(struct kunit *test) Other than above comments, changes look good to me. > -- > 2.34.1 > Thanks, SJ