From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/9] mm/damon/core: use nr_accesses_bp as a source of damos_before_apply tracepoint
Date: Sat, 16 Sep 2023 02:09:39 +0000 [thread overview]
Message-ID: <20230916020945.47296-4-sj@kernel.org> (raw)
In-Reply-To: <20230916020945.47296-1-sj@kernel.org>
damos_before_apply tracepoint is exposing access rate of DAMON regions
using nr_accesses field of regions, which was actually used by DAMOS in
the past. However, it has changed to use nr_accesses_bp instead.
Update the tracepoint to expose the value that DAMOS is really using.
Note that it doesn't expose the value as is in the basis point, but
after converting it to the natural number by dividing it by 10,000.
Therefore this change doesn't make user-visible behavioral differences.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/trace/events/damon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 19930bb7af9a..23200aabccac 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -36,7 +36,7 @@ TRACE_EVENT_CONDITION(damos_before_apply,
__entry->target_idx = target_idx;
__entry->start = r->ar.start;
__entry->end = r->ar.end;
- __entry->nr_accesses = r->nr_accesses;
+ __entry->nr_accesses = r->nr_accesses_bp / 10000;
__entry->age = r->age;
__entry->nr_regions = nr_regions;
),
--
2.25.1
next prev parent reply other threads:[~2023-09-16 2:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 2:09 [PATCH 0/9] mm/damon: implement DAMOS apply intervals SeongJae Park
2023-09-16 2:09 ` [PATCH 1/9] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses SeongJae Park
2023-09-16 2:09 ` [PATCH 2/9] mm/damon/sysfs-schemes: use nr_accesses_bp as the source of tried_regions/<N>/nr_accesses SeongJae Park
2023-09-16 2:09 ` SeongJae Park [this message]
2023-09-16 2:09 ` [PATCH 4/9] mm/damon/core: implement scheme-specific apply interval SeongJae Park
2023-09-16 2:09 ` [PATCH 5/9] Docs/mm/damon/design: document DAMOS apply intervals SeongJae Park
2023-09-16 2:09 ` [PATCH 6/9] mm/damon/sysfs-schemes: support DAMOS apply interval SeongJae Park
2023-09-16 2:09 ` [PATCH 7/9] selftests/damon/sysfs: test DAMOS apply intervals SeongJae Park
2023-09-16 2:09 ` [PATCH 8/9] Docs/admin-guide/mm/damon/usage: update for " SeongJae Park
2023-09-16 2:09 ` [PATCH 9/9] Docs/ABI/damon: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916020945.47296-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox