linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/9] mm/damon/sysfs-schemes: use nr_accesses_bp as the source of tried_regions/<N>/nr_accesses
Date: Sat, 16 Sep 2023 02:09:38 +0000	[thread overview]
Message-ID: <20230916020945.47296-3-sj@kernel.org> (raw)
In-Reply-To: <20230916020945.47296-1-sj@kernel.org>

DAMON sysfs interface exposes access rate of each region via DAMOS tried
regions directory.  For this, the nr_accesses field of the region is
used.  DAMOS was actually using nr_accesses in the past, but it uses
nr_accesses_bp now.  Use the value that it is really using as the
source.

Note that this doesn't expose nr_accesses_bp as is (in basis point), but
after converting it to the natural number by dividing the value by
10,000.  Hence there is no behavioral change from users' perspective.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/sysfs-schemes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 527e7d17eb3b..093700f50b18 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -31,7 +31,7 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(
 		return NULL;
 	sysfs_region->kobj = (struct kobject){};
 	sysfs_region->ar = region->ar;
-	sysfs_region->nr_accesses = region->nr_accesses;
+	sysfs_region->nr_accesses = region->nr_accesses_bp / 10000;
 	sysfs_region->age = region->age;
 	INIT_LIST_HEAD(&sysfs_region->list);
 	return sysfs_region;
-- 
2.25.1



  parent reply	other threads:[~2023-09-16  2:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-16  2:09 [PATCH 0/9] mm/damon: implement DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` [PATCH 1/9] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses SeongJae Park
2023-09-16  2:09 ` SeongJae Park [this message]
2023-09-16  2:09 ` [PATCH 3/9] mm/damon/core: use nr_accesses_bp as a source of damos_before_apply tracepoint SeongJae Park
2023-09-16  2:09 ` [PATCH 4/9] mm/damon/core: implement scheme-specific apply interval SeongJae Park
2023-09-16  2:09 ` [PATCH 5/9] Docs/mm/damon/design: document DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` [PATCH 6/9] mm/damon/sysfs-schemes: support DAMOS apply interval SeongJae Park
2023-09-16  2:09 ` [PATCH 7/9] selftests/damon/sysfs: test DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` [PATCH 8/9] Docs/admin-guide/mm/damon/usage: update for " SeongJae Park
2023-09-16  2:09 ` [PATCH 9/9] Docs/ABI/damon: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230916020945.47296-3-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox