From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458FFCD37AA for ; Fri, 15 Sep 2023 21:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A205E8D002D; Fri, 15 Sep 2023 17:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0008D0005; Fri, 15 Sep 2023 17:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897FE8D002D; Fri, 15 Sep 2023 17:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7756B8D0005 for ; Fri, 15 Sep 2023 17:03:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 51B57C07AA for ; Fri, 15 Sep 2023 21:03:26 +0000 (UTC) X-FDA: 81240057612.29.6B1BF33 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 5B376C000A for ; Fri, 15 Sep 2023 21:03:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=K36WRPwo; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694811804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=APHJKdyAi/Un1XPHZn1Z1pQZW4vCCHalitDLmyiouTQ=; b=IxLTMuhkzOkAf8TzJUCGNkZXzHrTBYEYUgPj+765LxvyK620/y7KBQD1eMGVxIQW1KVf2R bsb0WHe65fhiJU18QpGdfUEdHpqCfUmofs/2slJenmS7N7Fzrn7GNVjLzzRpN0VKaDpDya P7rYGrn/SqPgkaGjs5m9hEIdLGICQuA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=K36WRPwo; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694811804; a=rsa-sha256; cv=none; b=bU5kjkIsVxc2P8Hr98yWC+8VqBn/54Y2Swn8b4LMV5bsX8aKlKRHLvZI8B0z1Pjn6D4Ve8 e66EqpFKjbGYWRczRgbLY8lB2FXA6lczZ8y9pvYlucAWiwCttgozn71DuWittyC3lASDBt skOwbjDE7JcR/uIhSWg+P7hLafDYeOA= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-68fb46f38f9so2473150b3a.1 for ; Fri, 15 Sep 2023 14:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694811803; x=1695416603; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=APHJKdyAi/Un1XPHZn1Z1pQZW4vCCHalitDLmyiouTQ=; b=K36WRPwoM2jnmdJDwB71FJolN6b10ng0imMTJzvCXkYYaHxhi74Z15hmGZn70/hH0O r2Uyeui+zgjrrxyLEeZ7JjrrwrzHw6nEBfQEtrp2THhzmCURMM733QEBKE6NniUe9IbO 4kRow3Ix5xGveNvVW7LeXsDUHGa6E8vIJXnO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811803; x=1695416603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=APHJKdyAi/Un1XPHZn1Z1pQZW4vCCHalitDLmyiouTQ=; b=vWYv4XrzgZAu+Qat2GF28VrEWlZdX4uQlkJZsOYRV2Zf6fj+FEEexqYus1Ci5qnZ6y tbtJmeyfhQHVt18j3jfRvNDvY5D1MKbi8R9ALz59HOrrRf68YxdwaKGrhZLp6jNiWxoY blpL1bJ/P+1lZunTubjZS73dCwwqM8JFiaBcijccnimPi/n0sJxopUvOGiqRYpr0zWBG lg9p456XBnn4dKRB8NLD1mgT2YCUJIfvPKgjBPzSw8UEJUNxURHs+AXsSEGoFFNeTgDF DiJl7uNmwGHOSSCFoUYS6e9VpInhWnLH4z9gaYg/6chjKSqwoY6CV4HFYvJQi8KBVC8L 0q8g== X-Gm-Message-State: AOJu0YwDBCgPsRCsrjbhUShGtIN6+xjhV64Pn9gXIYAKlWa+vbwqHD40 61NkpfHzm+RJlTfi5iLdAE5Uag== X-Google-Smtp-Source: AGHT+IH9giN0oiNJip6NSPrpp8FYJe9UYAjCNYEhPQYuBGuLm0ngXdsbwkHYQMIrzQrQbvKrNld2xQ== X-Received: by 2002:a05:6a20:320d:b0:14b:8023:33c8 with SMTP id hl13-20020a056a20320d00b0014b802333c8mr2834160pzc.2.1694811803227; Fri, 15 Sep 2023 14:03:23 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bv6-20020a632e06000000b0056001f43726sm3098867pgb.92.2023.09.15.14.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 14:03:22 -0700 (PDT) Date: Fri, 15 Sep 2023 14:03:22 -0700 From: Kees Cook To: Matteo Rizzo Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, corbet@lwn.net, luto@kernel.org, peterz@infradead.org, jannh@google.com, evn@google.com, poprdi@google.com, jordyzomer@google.com Subject: Re: [RFC PATCH 06/14] mm/slub: pass additional args to alloc_slab_page Message-ID: <202309151403.49D5C3CB@keescook> References: <20230915105933.495735-1-matteorizzo@google.com> <20230915105933.495735-7-matteorizzo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915105933.495735-7-matteorizzo@google.com> X-Rspamd-Queue-Id: 5B376C000A X-Rspam-User: X-Stat-Signature: 1mxzcaap5q9oxej3gmmcndymjczmp7c7 X-Rspamd-Server: rspam01 X-HE-Tag: 1694811804-50667 X-HE-Meta: U2FsdGVkX1/ipVPq+RlSk52s2+Mo8v/k4U3Eh2dwulbjh15Ub7DuV8HmNzYfWpQo4KoYTSG+nX8e29FV5t84Bhwuph57T1jgLNvgmSL0LUuhfXOh1skEdHa/0/nqhmwhsbynTLq3cJsI9cNFtsecmdrJ/UWNUT7AqXHH/f/xjK/bASF69zoHozvKhybX/lzD9ZotF1IGMEz/yvYMygVqAtWbRoBRiYyLxsW46U36zq0Vt/PwGSae10pMdJDUr2KBFgocHN2NZDmaF+/5GJmoW1FPmkycRKaACV56ZYr3pHvfaxhNgsk+PMJ5mJphsBB0ifbQRT5vCQXYpRpsI7LOz6OBMv9cY8PBRHhvwLsrravUqvHm8rBFXbSklkeXiKRtClHoab7OQKnvBm73wBUY6k0DkY07IGX89NNnE1UAQMbeMmufSOJhAWEhWE0rR7YgRSJzC+B3kE575A9awG53KTg7ozfOYrdC+SWJAFyHjCC3EljKIgWFXWVmsqlCRemTbCmQ8E0sip5bH2lCmHK0ojxzLWLgO1UQgykfgC+Ucf5sTlVdJMWbrBtfR1TplmpQXgQXNR+hTLAkLiBRHJfROXmHhHcgjspSG+FhLwN44dNwFe/DmX6Q19fAaQPvz3c2xQj1CgYMVYuL5ybbE3/rlNaKSXm3b1Ifiy7nHoOgVW1e0TvS7K3I2ItZ/xzFw2l61aiaeU2qtbsqR4hgZ3nojGWQUb5YqrQa7IlRwXOrEFEb3gIDE2igdrxA9vV6KbhoDEQMcRCEpOmg+pwuULj+vyt5Y2kSFdjTmc7nBcatI6SL+qRpujbVJ5rKrDf3pONxVCXpowhdLOpp14B9i7LMVvw++L3dO1uAyyZUbbg71VnTJyrJ9VMI9k6Fk8xBew9EecVGLBaIi5nDwdJL70m5XPrHjMFgnOM1XBJzNHwAjYfcy8kl7SiIBiJxCEJmK/sHLzWwe873rMvtUC9MxTh d9ckc3c0 4dC8GMguG714X2hZmMsEwKGfC/WQodTwOIDlQqPyXZeyDFsUpnhLEvtEdWue0xxAIjkYHfoqJfHvlL4Tdg93aeIhJMJDnxrQDOxDesLAY/4pIhslItD3Sz70b5cqrWqDJXG9epF5yeScGaWZdq8Kk0WGfSlLmcgbgWI4R2s/V2tvazaVnbi6WObpv0ISHZyTNTKctkGIJMGwys7b8c3k/yjIVBNIB+130veEiSBTXft+B+LqtpRJa7yen8V+fR5XPUX3iNUVxKW+OABBlkwfsDtvhWXxfdaBpu9vD1f/GYA61AmAx7IMU3h5z5xxlMmvsqo9gT2PDDbiI8qEXgk1dxpUPWU8xMdauiHoWCEqtcO11AlWZxjqTxv8gcL2UD9dzSfWfSvaGyLxKbXg67ZFn9MTYNXaggkg1LT1e3oEmABd6gy2KFSiRSke+FUdHf2GpFoBlgfkT1RFp4Cxe9BT0vygCDY2oHZcIpEUVYELnkfJhkBSsd2mQKT23ESZ9S2UY7Bp+E579DInCLyfz2+wWyicYgk1NDhP7MKGN6JcizPQb0pJjX0GlN8X6LFHfm+ZfAzlzVyqXWAQ+hHg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 10:59:25AM +0000, Matteo Rizzo wrote: > From: Jann Horn > > This is refactoring in preparation for SLAB_VIRTUAL. > > The implementation of SLAB_VIRTUAL needs access to struct kmem_cache in > alloc_slab_page in order to take unused slabs from the slab freelist, > which is per-cache. > > In addition to that it passes two different sets of GFP flags. > meta_gfp_flags is used for the memory backing the metadata region and > page tables, and gfp_flags for the data memory. > > Signed-off-by: Jann Horn Reviewed-by: Kees Cook -- Kees Cook