From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C98CD37AA for ; Fri, 15 Sep 2023 20:50:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F3156B03F3; Fri, 15 Sep 2023 16:50:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A3BF6B03F4; Fri, 15 Sep 2023 16:50:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66B7C6B03F5; Fri, 15 Sep 2023 16:50:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 592296B03F3 for ; Fri, 15 Sep 2023 16:50:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 24C53C0555 for ; Fri, 15 Sep 2023 20:50:04 +0000 (UTC) X-FDA: 81240023928.20.DBA2B7B Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 54F081C002C for ; Fri, 15 Sep 2023 20:50:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M3UjJoB+; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694811002; a=rsa-sha256; cv=none; b=FdMpZhheRt266uqv3QziEWLv7MGGUTVauSv8XyClf3dncXmt9AO44oNCaeQ/XPvqBUzNA7 aDsRRS/FG26DW1GqJI3aAQywPDtIYCAvSfDPwrfjlP2cHyMrY+R3pq6pGT1r/QKDIQW+bC zuNmXbxQVTB1AUJGFBiwnrTYap7bEnE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=M3UjJoB+; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694811002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pixcN5Y1AubjMBamu4r0/OjVDhrvJd2jJgNFr0zPGBA=; b=sYeHGWDXO1wbYHS9vbLAl9gnoRVMOAZflOuhix9RwxZoKghCLuio+d44O9S1EaoIKBvJgJ jp/gm0jmmK6U70JiuVBYHlWfaTlTu+NrkRQrpHzJLhdj3I4CFRty7IcwmY44x+3VQEykex mxYnA02IlsCIkDtJGFtm08sqs5ZvDko= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1bf55a81eeaso20780025ad.0 for ; Fri, 15 Sep 2023 13:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694811001; x=1695415801; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pixcN5Y1AubjMBamu4r0/OjVDhrvJd2jJgNFr0zPGBA=; b=M3UjJoB+3MMIIFtJhcwN2/6z9VU/vwk4tNb26ctK624g8wSRf7OYNkZdoXz67c9ePO NFkAHP2Gn5Fu7PBgOiNbr0+WtUr/+i3gt43BWW7QPto5/Ni5jDIhdxW69Cf8/+3ColFE cr+18XpLjerkvBmpGaZF7KeFCIC00bMHd2FB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811001; x=1695415801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pixcN5Y1AubjMBamu4r0/OjVDhrvJd2jJgNFr0zPGBA=; b=ietHP3jZXQKlZAy0vnWN69z2DYTjWy/vImqSRFkOPzZ91QzhbvNa6K7AqBB9GwP3CR LyE6L2kg/JuO/jya41GHCq0eYbA9ddjCC3RMU3oh2mvLSnC1NaRephXGggmqrT3bIzrK 7T5iNsXdln44tq+NtUxqWMQHxW+if15lbzLhvX4W7MKCQEK87BxfrKVzJfvsR4XNFf0r mRJs8wQff8+nw5vzE8CXrwGjCouyEP7GyHmegd+4XOQ/1tmHBH5HZqZJkeSmrnMV5uVS 3GrkHFHP15fPqP6lm/a24sxvHa7pO/p6cqqmuMe9RPMAeZ29FZcPBeTHj/3lk4JV3U91 8u0w== X-Gm-Message-State: AOJu0YxnlL5lcQyvr4uBOQXcCgS+vQsnRLITkLHRs76BW42z0UK0mceo gcDCcxQYjptAaldkzp49qP4clA== X-Google-Smtp-Source: AGHT+IFG5RbkUmAUyhtbRZ65uLoK2tgVIeCtTHS/dvTIeIuGjUg4Cs9dHFp2ggbnq+0cI4RujnJy7g== X-Received: by 2002:a17:902:d4c7:b0:1c1:e52e:49e3 with SMTP id o7-20020a170902d4c700b001c1e52e49e3mr2611409plg.36.1694811001209; Fri, 15 Sep 2023 13:50:01 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id q22-20020a170902bd9600b001bb9f104328sm3876566pls.146.2023.09.15.13.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:50:00 -0700 (PDT) Date: Fri, 15 Sep 2023 13:50:00 -0700 From: Kees Cook To: Matteo Rizzo Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, corbet@lwn.net, luto@kernel.org, peterz@infradead.org, jannh@google.com, evn@google.com, poprdi@google.com, jordyzomer@google.com Subject: Re: [RFC PATCH 01/14] mm/slub: don't try to dereference invalid freepointers Message-ID: <202309151349.BEBA203D@keescook> References: <20230915105933.495735-1-matteorizzo@google.com> <20230915105933.495735-2-matteorizzo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915105933.495735-2-matteorizzo@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 54F081C002C X-Stat-Signature: u4ydyik1bmrz1boyzszeec3bpsx9f36u X-Rspam-User: X-HE-Tag: 1694811002-800877 X-HE-Meta: U2FsdGVkX19tgkzZeyikNrSGhbguXFJGFuZG0hlOl33Bl4Pm6Hib7oc+RVY7XjaJA6XBRMoLo8GwI/sd8W5IOHiL1RAw4FVg6Dzgv2IgV1IoZ3SViE5PKOEdrzxiw3NEE8oYVXdHQzPpCd50AoMBRXnbJKEA7mSS1Wb8EYwCt5bAQAZhfaOATXKRR1m0p1/0TixthGr5NIttp1XcJf1pwqyc2IqGFhn3mhqcXsh0tMZi4k68ZjfkQQ807Psnh8wKChl41LoPHN2lr2gh7kBpRdX8VKozEk0oLweRZwHTCSichSr5Za01XZ8t8yIvnpNz1347J3fBuw0H5B7J+YRTk6oEYR57iYJIE32dsnxWCWGa9spENMRRyrKn08OSkykAmKKIcecO2Q45aUJYkwgPAuy+uZKt7ZaA2gKg8bzgp9qrZVwZu/Aa22IpPkDRdEHgxjHIt4E/kgMUmdOno/zqn8OUYdGtlDyLURk8CFVzV9EvIGbHUhJsiJig4VwxHrNaO/PVs+5cd6TBaf/qvMJkC4mC523rS2WhyJ0ZKqMJZasCyZIrLZYGwdQ3QlYqQ1RaaFFR9Gh6RS23ARKPVOTNldrF0hpOLYn8OQqQXb1j35GMMJTS3z05mZp0oEh4uCOowDfqgdTiNAbedekyhDjEo7XAvfy/qT/v4ATBGo1fdRc7eBKF3TqZd4bREV5NhXejVCLK/8r1KXLBmbAFyMCO1aeNs2RkTcZvKXyBJ9M2xngaW4l8sZqZ/+fVCAEPLz4inD/Rltxx9w4zzhIpr30dXuuD+GLkVEK5ChS2GNfmbFb88RPyM9TgIxVVpPdRCkvhRTtveLlMPWBKD8itTn3a35oFUf2SdWMJ6gp7YufnU60JhMawstaNFNg5/IVTbq/8sHiLYIP/e3iv8GEjSx3ySvrhrkNcB39gGZhvfBs5/KmQYELLicLN9IawVPKmDMMwWRpqMZ0Jvz6CMuNDCxP 5Usz4R3J yy6o63sJpSapb1KnZP10oe2RfN6b/iN4oMHHvY5Sb+EJcEDvTyyqtXjS+x0DpacL/1hMtO83EkWqzTc1+H9qOIUuPHDpnq6dCxNInO4XBowW8e6fLL6K1ErArNTFKlzNwXXqfiayaTK8zmaDLGlUwD69aXOtWzuIJ2QstPxFOhxwknqMF1IYvzVXZLTUaUapk3+nIpSb/W5Uf4UKhnFcWvP+nhSlEQpq9RRNOjh/hMxb1hv3++vLh0g10RGHFA5jT07pejmqT989nLnY4+ZhI15ik6YwYVBxLKEZV18uctTMZK7sf4xyxJZNKFpLwHDmw0sQvehgTsOyhpLp3RvB5qktF51P1rbYeh98QAkoe/ZI3EoXR9HqYn2oDiV8296QePB7rDrFxnHLm+hIvL8gFwl+8KIEAyvam6N+J+Tx9OHyos35aDK2DePGDN64RShReyORvAFZV5mWiCvHOLJa7HEBRNE1hTvu9h+edoS4vQ+IWJJ0x2W8y/YTWFP2F38yJGzgC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 10:59:20AM +0000, Matteo Rizzo wrote: > slab_free_freelist_hook tries to read a freelist pointer from the > current object even when freeing a single object. This is invalid > because single objects don't actually contain a freelist pointer when > they're freed and the memory contains other data. This causes problems > for checking the integrity of freelist in get_freepointer. > > Signed-off-by: Matteo Rizzo > --- > mm/slub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index f7940048138c..a7dae207c2d2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1820,7 +1820,9 @@ static inline bool slab_free_freelist_hook(struct kmem_cache *s, > > do { > object = next; > - next = get_freepointer(s, object); > + /* Single objects don't actually contain a freepointer */ > + if (object != old_tail) > + next = get_freepointer(s, object); > > /* If object's reuse doesn't have to be delayed */ > if (!slab_free_hook(s, object, slab_want_init_on_free(s))) { I find this loop's logic a bit weird, but, yes, this ends up being correct and avoids needless work. Reviewed-by: Kees Cook -- Kees Cook