From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFA6EEAA71 for ; Thu, 14 Sep 2023 21:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1E946B02F0; Thu, 14 Sep 2023 17:20:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCEFF6B02F1; Thu, 14 Sep 2023 17:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C963A6B02F2; Thu, 14 Sep 2023 17:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA48B6B02F0 for ; Thu, 14 Sep 2023 17:20:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 66251806ED for ; Thu, 14 Sep 2023 21:20:47 +0000 (UTC) X-FDA: 81236472534.25.2AE255C Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf01.hostedemail.com (Postfix) with ESMTP id BDD2940005 for ; Thu, 14 Sep 2023 21:20:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tu8Py3XZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3LHkDZQgKCFsLA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3LHkDZQgKCFsLA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694726445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ob3uAvnOoSCrtCSZPkBDgY1akrbFBa78/VkbR/tD3Zk=; b=k7vztfOo7qnNu4Y46gXxlrhGtRJhCculkmN13NtiaV2sg0yQNsJFv9lVWXrqLOuu8pr53U Xcl5hhW+Cg/IzKFBcooqcCZEjvTHTFpkX4wwLOj42CeRvesyJiwQa5P7OeN7D7UDnPtcMA 019VOjRmHaDGbFmbgQI50PbKD53USyU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tu8Py3XZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3LHkDZQgKCFsLA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3LHkDZQgKCFsLA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694726445; a=rsa-sha256; cv=none; b=AIxcTIlYsT3vnB1Hw17qhEn2blezri+3zhM8dZyk+1dueCllPpPvmQPRx4saMJTerT1XOg 6+ziPcZFKSwEknIzkyZoffprCLtLkiGfcuCs8L3uglPugNF4xiLJ2N6pWHip2PGcMVyddJ ooPqGzK+NAvMHCH4boNPxXRA5wE9M2Y= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-58cbf62bae8so18408837b3.3 for ; Thu, 14 Sep 2023 14:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694726445; x=1695331245; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ob3uAvnOoSCrtCSZPkBDgY1akrbFBa78/VkbR/tD3Zk=; b=Tu8Py3XZ/1GfoXt4m8yazuWV7mNtrcNr579zI7B+YUjM+lHGy+wXMwxj0nzKj4boEf TtOrd+4aoe0uA42u9F4s0nGA/HMCCN+SsJdSff6S8+YM7LGPFd6x0TT01ifwmOnA7ImD E1vbmLSfbk3up1VUgSuqXwQ1XqhJRg8lvMd6RGOHoGnA6zMLv1/NRWZrRCeG36Ev83CB dXi3A/jmpAWeaYBQx+2l6J+S7B9EwJyVJjUnqckojDpv/fEOsSVYMCMDIda1VU1pFn17 XdnTcZxP64rRmZg8RS/Ovr94AZW+8Hk76dt8Vf1DIuLys9xndKW9BsreqKNs3cOzIAwC kiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694726445; x=1695331245; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ob3uAvnOoSCrtCSZPkBDgY1akrbFBa78/VkbR/tD3Zk=; b=VX287YyTs1MNaRkOo0tjjcT2Eip0lqYBVuXG2GTR4My5UArKxR2QM53Ub/KOuAWMVP JmpfUKFzsc+9j6ahQJneMhDi6IKK06Iuxl8sv7Lbs4ja4yrGYidscmQgDp350FeYYQEM rz0k85MAHju3ctpdYflsvwUXiuRcoZT5yx6dNDd6MApHlXgx+XBbUSp6HrbZinF9LUs1 BzPWP1AujnQJPnlKoD/rWRtUQ13vLF9LDTrU16Tsgmuit3E0p79NXIgTTNAJ+H1+HMCH LxemtpQEkSB1pKJbJECqUUWHi5VgXy9NDy0/uBvuzKqBC25OEw8fG6zM/t88kqZDn8Dy VZ8g== X-Gm-Message-State: AOJu0YzhejQOy+Qac97lfojaQzqXGg9s/A3RiNFwncRZN2hXIhr92YI3 9wkMKIKNIJqj+FCNv0F0eNL9XzzKEw3kmQ== X-Google-Smtp-Source: AGHT+IHqKkwRb4VbopLin6Ia5XmxbD4rC+NeBFNXt+55ae4VdsIBmIxgGh8mmlngX1m+Fr0aiJb37+HMAskv5w== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a81:af11:0:b0:565:9bee:22e0 with SMTP id n17-20020a81af11000000b005659bee22e0mr176595ywh.0.1694726444854; Thu, 14 Sep 2023 14:20:44 -0700 (PDT) Date: Thu, 14 Sep 2023 21:20:42 +0000 In-Reply-To: <20230901062141.51972-1-wuyun.abel@bytedance.com> Mime-Version: 1.0 References: <20230901062141.51972-1-wuyun.abel@bytedance.com> Message-ID: <20230914212042.nnubjht3huiap3kk@google.com> Subject: Re: [RFC PATCH net-next 0/3] sock: Be aware of memcg pressure on alloc From: Shakeel Butt To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Morton , Roman Gushchin , Michal Hocko , Johannes Weiner , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , open list , "open list:NETWORKING [GENERAL]" , "open list:MEMORY MANAGEMENT" Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: rco8odezzt3wx6fnwa73w1u6wn8he1mt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BDD2940005 X-HE-Tag: 1694726445-309619 X-HE-Meta: U2FsdGVkX1/KuTIQLwH900MguLEOiTa+QyoIgA5jwAvhsWIs3+CkqXTNs6q0E1IMtch6R78Xe6tE+Va9Hbb7ufghkT07YF0USOLQt7FGUmWCpV/QBU+lc8jdrvt4m1tEhhGwobwrLaxQOKwCORWps4QNiAYgBA482ZJB3UuM1Sb9qbWJdj5upYIbh08O8PNE4ttQaHz6PErT1I6pPFBMFtoMVXWsHssKbykD8r8g/UKh7zZMhYswByMGgwKEmyolFsGx1lHb24IY6P7raeKYiy0KEOu4HCvcgl/7ulXLl4phxcvTJWvRt3hR6EPMXgq/vdXNFIa/rnyhxJFQRUUULSWUQeTl9dqcI/Ztb07bfaL0uWsY0RaWvi5QYERcaR/nygP55RncbsX8GHv000zpkYiFQGk3JXTVngL42HVvC8hueHtFa7XiPNNsQYuLBFdfiamnXnlh9OsCRK+1i9jY4C8H8SsmZlk+0y7rO3D3S+hJzHN1OSLQmXny3DCT2JrqVfybLUB9CzMWchLre/MGDCB/JXE0iZLPAWu5qA97pRyVcFwIiLkZJfZV3zEcgaIwHnvgYejEi+0pfIJESPotco2qk5L49iNc/DL2YaZq4gaycKVFXTeVZgqjyjeKjGBh3ajeQph2lPnJVPLuCaS4zlpNoCH5Gvyy4GSLZ8AWTHt8n76P4o4V7h8MNT2mI6SHu7N9SZdXvLDqzlDFI4ZEtpER/J97gDoyZlDM3UN1mU9E0P/UbUsmCUY9o/5ruark3/LdDvqFwAae1pe0VXZxy0AnoFHp9szaPVpHwWkU0DhdmowMzqb4eLTC/hCyX7A1ShkFbIeYi40Jce9JgpGBw+HuJrRQzqANUFyi/L9l4DfhFkgZdKFdsQ6DfSMroZvSBWyHYnWop8rKr9x6Tp7O5oO951Hk0diZeCxkJwnTs93CwRHipbd1kuJf7uQSZSguJ3FvsQYGWM45udIR5sY ZBeFVJGU Nfwi2zR7Ub7Aoo+4NMgP+5mjbrEKhvQa+0+PcJA3k7V4RCD74diXGxUlnfWvCANo5M97N5bx0RtlCaLhIUFHH+TumDxresKYOJ1Mbj0+Zo35afM5fPf9zAxJeQyP1Jv6Z0uTW5M2EiFq4zhlFTVxvWR+eu+pPBorTj1+NpTnASCzXJysMyRVm8w6FP0oU/UK7JIv4N33lQiJF38FCJl2t9eJWugoGjxhJhMpAXOgcXUeO+pkQsQwhQp1Y4B4S9vTVWNhIhaM/KTjHUkuyyo/NfkXXn4sYitNMz2rzqGlqkjnzwTmfRiFQkpVD0pSx6MunlGA5lJwpfYh5oFdmCeMkQ72nmDCqWKsWCzXA8A8dnQPnoccP0G/lV7GVJBwxaGCbyTTs2d/TCvFWvP0RoZulQc7MnR2LRy8E/FWWZdfJTYIzlIcsCfUTLVLDmDpiJwaDF5w/MkwSEDg3U9KRwp7lBdmJilW2UcijvCcALCsyfOzYl0AKGmDOW+MeLpxravqByQsbBUt+6blKolCqR52048+HBzhJnTlhLBUYJ9OUdvzppdI0Vhcmk1r+IsG0p8ou3H6oGzC5+1NzUoYfwZ4H6WvXX0nndXbe3GOc4vHWUtojWfFI222xvVTYws9ZdyEpucgO28ld3tgXr+OgO+sIrTuDkkJt9ZY0u+pRfLKflS4uFU8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 01, 2023 at 02:21:25PM +0800, Abel Wu wrote: > [...] > As expected, no obvious performance gain or loss observed. As for the > issue we encountered, this patchset provides better worst-case behavior > that such OOM cases are reduced at some extent. While further fine- > grained traffic control is what the workloads need to think about. > I agree with the motivation but I don't agree with the solution (patch 2 and 3). This is adding one more heuristic in the code which you yourself described as helped to some extent. In addition adding more dependency on vmpressure subsystem which is in weird state. Vmpressure is a cgroup v1 feature which somehow networking subsystem is relying on for cgroup v2 deployments. In addition vmpressure acts differently for workloads with different memory types (mapped, mlocked, kernel memory). Anyways, have you explored the BPF based approach. You can induce socket pressure at the points you care about and define memory pressure however your use-case cares for. You can define memory pressure using PSI or vmpressure or maybe with MEMCG_HIGH events. What do you think? thanks, Shakeel