From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E771EEAA40 for ; Thu, 14 Sep 2023 13:37:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A48916B024A; Thu, 14 Sep 2023 09:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F85A6B0272; Thu, 14 Sep 2023 09:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0516B02B3; Thu, 14 Sep 2023 09:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 793176B024A for ; Thu, 14 Sep 2023 09:37:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 488244052E for ; Thu, 14 Sep 2023 13:37:52 +0000 (UTC) X-FDA: 81235305984.04.C286122 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by imf11.hostedemail.com (Postfix) with ESMTP id 4B4B240019 for ; Thu, 14 Sep 2023 13:37:50 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vGZkvohh; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694698670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UjaH6awq5V/b/h5EjTWTj3DotldQx6AS4c6JYOsrlY=; b=N3Mq+j7tVcs/DDCB62m7yrIAYnu2AFpXAuW/5+u0gaWaFX7p6mGmks+TQmlHcK/HN4D7Jk jaq8g49qoh8cS1+3ZW1K74j1ZAf5KlU3HGnZzB5yfqvzxz8Yti+b86/Z0yYvzWWEhJxNS+ o/6Q0oppAYwbRkdrMEQfGSvLigeE2OU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vGZkvohh; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694698670; a=rsa-sha256; cv=none; b=TpV4+03vKNlpyxpUwfaS2+vVVSwWLD20oF7BoP8sawAWaIewjclag2Npe0q9nYqdM3MXm0 2j7Hn67vgv9I7uURFDwdhBqx/dSc7eBm0yFfvOBGj4+sAwaYr5Bfk5tzDFWsCjCteK06oq drxvoLr29qTOaUkxAza0HG5bC+dCQDo= Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-7a52db1e4bbso348705241.3 for ; Thu, 14 Sep 2023 06:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1694698669; x=1695303469; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9UjaH6awq5V/b/h5EjTWTj3DotldQx6AS4c6JYOsrlY=; b=vGZkvohh0AhKzJBW7GcYZQdg3UqDJ2CbKhIr+ByovE1KaD7hr2gRt0ozUn6QJYs48T 4Lo4cWN0CBq6WTaNshmgJCmQT87mTRHu2YDrU1sN0nAWrPl+E+SIvhIjfMNROVQ12/jH AAbQ3jA9ygy/WoHkYSRFLa2XFQqvoC64mGJedaJuZn3/6itlXKwAbRqotoLOSf1EA/MQ IjbxxM34L7950eho8uHS35rkkPBIfhIZNqMW0DlLOCnbOkUBA9aaz3TA/fzhQVhOFq2z 50i3ivx5ymQ1a1RTM32NzuarXHu9662pu8wpYdEBGOIrPi4kzJfy1ooABygv3hEpdWyH zcCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694698669; x=1695303469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9UjaH6awq5V/b/h5EjTWTj3DotldQx6AS4c6JYOsrlY=; b=F6UCStu9idNBfYIPYdUPayqBMsy5/5H85MNmKyhprrxacxX93RPEE/xUX+9XWkVESV q4S9oBBybXTZNwtr/WLdG/OiklmN+oBE4GtVtdiCc8V9RxCzwP33t//eKOsRAhxAIgt8 JKuHT/NC7Yfyp4pYe/nCqQSiJV2XU60XAcVfbJeI2Gq73YomeE1NqmT8IOSGFtjKkdYZ 9c6VQ7P5Rr6hdQ2G2xjzTyMQdGZdLQEBVe7N8RlrktiWjJpizxwKQFVc2hadRImgQyMp OGbrv6NR5yKvvNCaR1ylVhk9+ze6xXTW444vJcPIVN+WBNjurcjPkFmvT3MStEhq1iOI tbAA== X-Gm-Message-State: AOJu0YyUyXDMe2MJS16Pr/UwO8m6/xqBdd4BgQ7399hgMEGkPOjww6uZ 0KPjE/esGYmOjGyeDi7wiEzFaw== X-Google-Smtp-Source: AGHT+IHw2m/QzL3fWk6Anxsy/+dsxwjlnmmZnMwridhM308Ybhxzx8YwAeHDxESxqJxU9dr3tEIeCA== X-Received: by 2002:a67:f84d:0:b0:44d:634c:1125 with SMTP id b13-20020a67f84d000000b0044d634c1125mr5277278vsp.13.1694698669249; Thu, 14 Sep 2023 06:37:49 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:35bb]) by smtp.gmail.com with ESMTPSA id h16-20020a0cf410000000b0064713c8fab7sm476813qvl.59.2023.09.14.06.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 06:37:48 -0700 (PDT) Date: Thu, 14 Sep 2023 09:37:48 -0400 From: Johannes Weiner To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] mm: page_alloc: fix move_freepages_block() range error Message-ID: <20230914133748.GE48476@cmpxchg.org> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-5-hannes@cmpxchg.org> <2f2985f0-f1a7-f085-fd18-107f3fba9478@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f2985f0-f1a7-f085-fd18-107f3fba9478@suse.cz> X-Rspamd-Queue-Id: 4B4B240019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d9w4zb7icbxnk49n9barfw6cbhm56u6x X-HE-Tag: 1694698670-137281 X-HE-Meta: U2FsdGVkX18NvS2A/MO28ttf/Fl/TVhPIwP+MUr4ECp0sxjB9xYJmcmS1L2Cl9fBnk+A2gyEssL3x62g30sipBoUHkzYsS+wKoqNYGUdf97pw8gHrlXYQidvbe7Xks9ZIsJzUV0xnxRBYhL5HrWCWRTvgdh2ftxEdJzMdN56jVb9RqlqIeiyYNX6y07dkssMBW1mwJIIObnc/NOFpOzUgv5J0u/37s/maFMumY3XdzTpNHbMAjsCzvTgRh7yZoFphhcwMMFujQYa9QzE/YYQ5Q8kE7P0toYA7VQV411PjRi41DzxVXcicl4WGbnp/ukUhz+dyj2ZrJwj0DQ/rGH+zuslpNg2qQSssWeL9phBSsj24lYJ8+aOM6ZrF65DZ4hSuH0SiSFcT4eLgA1JVe9hjdsGv2F02wN6ql6tEolGMejYmgiCal++ZDym2mx1ieoBBERmySHwYs4vC95rxeueLah1ytfKW7QfTeC0gN5NumJSgkUI2BniniDoepfqKaNTlLipOAAAhuX+Iqrt3mZgd7PnF/mokWmGUHVs/xYS415wwAAZXeryhfv+8PsTjruBmizREYtlNkjSUeRtk9qgu9drL0hP36OVTw4IOrc63sveGDjP6OeDfQluP6ZuUagmxIDH7h16VGPe96yxREGlvzmEnjxWQihRGcZVn47lLV2cIHT7hzML55tNJ0Egcro8Q66LTD9uOUzlQtVek5ucwRGydBR+6KjRJfZbWUTI1fDrOQryMDRdLT5B/vV7y1G8h9p1BiPdDct1IjXwvifV0x8DwCWqMB2Tr8bTFww1dHGij6kbwHn3qCQqLo+/lzcJdJWiQb9mzGHmJHQf3RbaSiWDk3Rhtk0tZLQ9iGyyAcYnBtG227rLuD8iyTz1Rbn31VUmP5M/u5iU/1dMyuA+RgbdGRlPBd6vvR7ugFMZNUyCD0LTwbBdU48fC+EjyW88b/uCms1ip1XVO2nTO+R Z73D27Ul XqQ0OSoiXdrhA6g6dbU6bIUvVwj/Rmxg67CPzrEtru8DwjIGueSuSgoAT9tGJK0Ksab9+3/GFw0kfHNs0JDzXmAR4Cbci4p0Jqjyrrn6Knasdtp24zN6VezH8tktSCswSR2E1gQxepquQ5Go7HDqe5tsxp/kS5+lYZk/o5oUb5vFMl0KSAvCEkS0w1u6lLseDdecnYOrrMf1R0eD60RyNN1K3jssm1Dp/Uwk70+8tRTAkNoXgMyncct2OXg2TPVF5Jx/T8bjSMXdR9X3ZsY9FUIJX7nW3EyoLQoFz/OwpY/V8lCSD0lTo3tDgaCfl1pMcAD9vVjEwMdwKtotMSq0T2lhfV81bW9hPvSluqO5uNSJEVxe+H33EsP91qS1U1dBZ3BdJQ4MXbxlVOpraZAMdQa/Gs2Sdtc9raRLg9PWwh7DU1C3C0FeT+FViBNKJPtnEm1k/EcfOj/VNdRZCQMYBl7eBwQZwDgvhgplEAkM7nqYpOTNvGLSzYfLQWedovbzJE5jiVq3q8kegUWJgkUe2UNAACg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 04:40:48PM +0200, Vlastimil Babka wrote: > On 9/11/23 21:41, Johannes Weiner wrote: > > When a block is partially outside the zone of the cursor page, the > > function cuts the range to the pivot page instead of the zone > > start. This can leave large parts of the block behind, which > > encourages incompatible page mixing down the line (ask for one type, > > get another), and thus long-term fragmentation. > > > > This triggers reliably on the first block in the DMA zone, whose > > start_pfn is 1. The block is stolen, but everything before the pivot > > page (which was often hundreds of pages) is left on the old list. > > > > Signed-off-by: Johannes Weiner > > Reviewed-by: Vlastimil Babka Thanks! > > @@ -1652,7 +1652,7 @@ int move_freepages_block(struct zone *zone, struct page *page, > > > > /* Do not cross zone boundaries */ > > if (!zone_spans_pfn(zone, start_pfn)) > > - start_pfn = pfn; > > + start_pfn = zone->zone_start_pfn; > > if (!zone_spans_pfn(zone, end_pfn)) > > return 0; > > Culdn't we also adjust end_pfn to zone_end_pfn() so we don't just ignore the > last half-pageblock for no good reason? (or am I missing any?) > Also would stop treating end_pfn as inclusive here and in move_freepages(), > it's rather uncommon. You raise a good point here and in the reply to 5/6. Let me reply to the other email.