From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B751EDE99C for ; Thu, 14 Sep 2023 10:03:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 968E78D0018; Thu, 14 Sep 2023 06:03:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9194F8D0001; Thu, 14 Sep 2023 06:03:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830258D0018; Thu, 14 Sep 2023 06:03:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7521C8D0001 for ; Thu, 14 Sep 2023 06:03:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A73A01CAC8B for ; Thu, 14 Sep 2023 10:03:44 +0000 (UTC) X-FDA: 81234766368.17.7D42E27 Received: from outbound-smtp03.blacknight.com (outbound-smtp03.blacknight.com [81.17.249.16]) by imf26.hostedemail.com (Postfix) with ESMTP id C07EB140010 for ; Thu, 14 Sep 2023 10:03:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.16 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694685822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xmw4nSPXo3+hrV6NNlXp2SttgaW4cJg//9HzUcBimzw=; b=n50dZHcWG0PNL6UiyDmQI4T4T4xgnECpQPIH5AKb8nZNV+r2bHU0frbYUfGJIyG6PGvihi rw+Bfv86KUxN0qOs9FwOQIed2JZL51w5HIDY59xiwBc6aU7prDY5Fek2GfJixkbY3m+ANI 4bjCu+wRz/jE51EOD6Ah/x/S8KgWCxI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.16 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694685822; a=rsa-sha256; cv=none; b=Kv4ITDRG5A8UmFQyInaipRqRpHsIbDKfkk9dLZvwc+B0djUUkz2liReVjAcYeFWh8JEE9z oWqJYwhf5CsOg5udxbfEkN10GJTaTynCavil0qbrGnDQrUMxMpZrHFaykjrRG9ZBc2x4mr jXEb/jxm/ZIaZVWTXYCKRGDdRBRPetg= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp03.blacknight.com (Postfix) with ESMTPS id E19F0C0DBE for ; Thu, 14 Sep 2023 11:03:40 +0100 (IST) Received: (qmail 9226 invoked from network); 14 Sep 2023 10:03:40 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.197.19]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 14 Sep 2023 10:03:40 -0000 Date: Thu, 14 Sep 2023 11:03:39 +0100 From: Mel Gorman To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] mm: page_alloc: fix move_freepages_block() range error Message-ID: <20230914100339.3dhgvsc6aprb5bbx@techsingularity.net> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230911195023.247694-5-hannes@cmpxchg.org> X-Rspam-User: X-Stat-Signature: p37niknkkepxdyikxuueids8b57yr4iw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C07EB140010 X-HE-Tag: 1694685822-347113 X-HE-Meta: U2FsdGVkX18Eup268Oo83sw4es+J6ZSI8SUdbmPWyp7/RoRzDTeILYQ7RdCyIWnu8jjOqMFmuPLog4dFGAY1Z6VEKmZOa65Z065STTS0JD5yQEciAx61K3Ew2S+H5iP69h+rwN6If9eKLzNIeWOCDlPWmC9klP/Vw+fzK2fqMxH72ebJLHorlhRVwHZHtR1avThBvOYUo2kXXhFqcGg80bYp51VeAQWXdE2p2F3fZXu/59qGj3UvKzjzX+RYWTPkAQkWa/gymHdzciIJAj3uvRkzaCXZE9TmIEy3nslGr/y0ywp99eNQZi3A5kIsAuox8tqUhNTjM1qHQA90zn7cWgCosesrpnE+l+9auYuO5JA2Q1I8mHgE4wxQgmVuzuSNoHIwi6KkAIbNTrN8hGIY4u6y+t/EKB6Kj4YnWT6A7D0t2xE8Klq9jSFErU0gx8kl4/IULbysdppgZb0QmBLr0YdX1hZ3DZQvXUtrR0eZPuio75VWeyCothOoI1qcZrT5NfiAcN4czDijQXZt5DD/Ji/eVfYt10sqc/JVPt7vfaDNl9Gv0pfqRpoNbUW99LhkWlMsDHYYoPxT72wyWRkvMH649sQZN4aC9BG36Ar69egtUvapv8KrMknbhC34oML0Q54faKyrAzBPgz6/K6nUsq/l0EoZK5NfcEF25GQrEwMe1ngRk39jL2LBw2bI3UGhlmRoJ+CEd4+UNW7Po6+CX6JibqIiin3Ko66Sj0oRyq54VhIKJhMOirCQiJ7wZ/Tqt2z6UoRryZfLGrNbJEmG62lCJErOSQn5pRBdzri4uGIHM4AS8cfJmg0s1264CFQBZINOlyH/l1vYiNEfcnfKl/SFNVEc9WRK2+OgpRUbXGGWL3fRJuB99RYFC4Fbiqc3MkWfoLfaLJlBJicRMjodRPwaYPW/G8x2v8IBE66ySv8pGOsETProrEkhTaqi7YsHhKHWIx7FI7+tvKtZ7Eh +sneiviy P4/TSPy5YSIWvCMAcGgPlcNJdQrzxoNR8bWkY5605V6pIIQUWEI9cIWg84EPP7dBo511BQgo7VZz/61g7ADWjsQ3hTaOHnoBk4LS4cAVje4ZfQQRHMyQyIOBGDJGkdbu/NY8zcvvzWCtrPCkFfI8zZ3alp94bbKbWscIFtyp+xjdiGR2KXD9XmFYEpCPIBeTt1d/AeY5AvQQE2hE3WZRmIRkhy+sN2U0XBSIPLZsPKKTR9R66VpRl7Q6WmszWhEebbaArNIWNzA9ShAgzWBVIpKJ746skFfX/t3w+axIZUSGd5/wxvskT/Y/W1z1L+VScIOmdeXBb5DYq4zQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 11, 2023 at 03:41:45PM -0400, Johannes Weiner wrote: > When a block is partially outside the zone of the cursor page, the > function cuts the range to the pivot page instead of the zone > start. This can leave large parts of the block behind, which > encourages incompatible page mixing down the line (ask for one type, > get another), and thus long-term fragmentation. > > This triggers reliably on the first block in the DMA zone, whose > start_pfn is 1. The block is stolen, but everything before the pivot > page (which was often hundreds of pages) is left on the old list. > > Signed-off-by: Johannes Weiner Oops Acked-by: Mel Gorman -- Mel Gorman SUSE Labs