From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BEEEDE99C for ; Thu, 14 Sep 2023 10:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A538A8D0017; Thu, 14 Sep 2023 06:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A03518D0001; Thu, 14 Sep 2023 06:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91BDF8D0017; Thu, 14 Sep 2023 06:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8399C8D0001 for ; Thu, 14 Sep 2023 06:03:10 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 520C51611E8 for ; Thu, 14 Sep 2023 10:03:10 +0000 (UTC) X-FDA: 81234764940.25.5CEC823 Received: from outbound-smtp39.blacknight.com (outbound-smtp39.blacknight.com [46.22.139.222]) by imf27.hostedemail.com (Postfix) with ESMTP id 62E1E4002A for ; Thu, 14 Sep 2023 10:03:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.222 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694685788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cl7Cj4m5WBmJ5WS4LFFq+qQqKdVF2vHZZp4Q/WG1NYw=; b=VCG5mIuyEcGyRYHOOpw9pzcDtRs/qdijy/GynhDCh2vRQbKIwkgn75EIBqpF5Q+E04CpRx 8L01c4MDjj3RcMwXrKpcGYsbT0ouMSON/BAtTLptlAilE60xBmJNwAEKG6u631nriIQh5l sQQhE8TdKdino2YNBZX8lJa+kCqBlug= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694685788; a=rsa-sha256; cv=none; b=78cY8+QjaOw+gkk8Loww6ZMNrg89OisgOpyzBzulaXGh9DXuJ4EzAqzYyNJP5VsJ5m13YD 21poJtTBRLFpABg/ShIUojubQNF3U4BTn+yYEUryNuTcABWML7b3KYpbHOD/2lvqFauT9C rn7D0vgRWuugT2uOnvD1kaH/1nJV3hs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.222 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp39.blacknight.com (Postfix) with ESMTPS id A66D21E0A for ; Thu, 14 Sep 2023 11:03:06 +0100 (IST) Received: (qmail 24834 invoked from network); 14 Sep 2023 10:03:06 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.197.19]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 14 Sep 2023 10:03:06 -0000 Date: Thu, 14 Sep 2023 11:03:04 +0100 From: Mel Gorman To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] mm: page_alloc: move free pages when converting block during isolation Message-ID: <20230914100304.v7ztao3rz6ubp6o3@techsingularity.net> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230911195023.247694-4-hannes@cmpxchg.org> X-Stat-Signature: nurs9fwp7g6699pij4ediricp8mj45oa X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 62E1E4002A X-Rspam-User: X-HE-Tag: 1694685788-882725 X-HE-Meta: U2FsdGVkX19Nr1m6lh3XUFOSx2vV5M3SEAdIEgRpa+L4+A7ja7awPzFkDuxPxPT5KhtQLtYnYc/wCbHPjKlAtu4Qd1VTw1H0XpF83qRFRpBE3ZinheuBSQmS0giVEzTRbqc+mOtwBGoDh33tBz41ouVGFVCT+3azac8hfdbIRbMc5qa5At/xGmZ3w30gKlW2L3lXD0ZeQ4WU591WQUXdbR8ULNwIFmsaghlsx5HO7Kujg3UkPLe5T5kYj2cGzCmPYCLRA1EwB6DceuLXzFsufv/aonf0vI0ly2cxr8sGhPCvULgaqo6MP0jmiKRkKs4skeKW4Lc4RWeSOrf0LygHJwgyHT7geMqOzfOAgee3NxDMDIG5Vc1DuR0zs7nycJunkvftqgjBbOAUOh3C4uflhUEzuMRIlPxLjJs3UDhirceqERQXbai86JVc1fDeM8GHakkKGBnbGtfvIkVotnikDItQlkNYensXjqE31yTJpLkAq9pPQ/ciwdGmMSXkuA1UpVO1LcjTGs37fh55Rgaf7VUFdnIThrErXRRGd91nJzrEe2WrgmEdmysvXfLRAiJ9Zr3r2Z0ygZ4q4spih0k1KOfa60wpniLd+osrtPbhccYIajiv1W/A6p6gTczk97JxN0XfxLpTNjkNvuigG1+cC+r4Z+yyXA0q6ToVUFNWy/7p1eNwWqiRtKlfsM7fFUereFMzOMpM8I2BSQw11H/B+af0dZeAJS0om5RfBwhsEynbyiX7NYoor9vynR4Kd8dmE0SQN5nIWRYDC3sDU9alCM5JPthWSX3QzzvTKRXgsOvp2oIC+CzdtGJbgpeYaZivNE4N1s1Cw9YKxEOO0O/Z5Bi2V2GykSUHLo5vIx2EMAykFOYaLpS8jWX2h4/x9NIJJ5WtxZO1C4ioZlqD23RSGKVbFO3td0mA38b0dqp4XSaTKfkhshmJtFK4ijsEvchZe/d7VBeKngUOhf45sTq Oxno7csQ EO3TyFNVrlyw/iW7YOw++4lorD0YSFpEFwglLonc0JC4csQS3Gi1jAach/P7JFLu48jVoEXoiIKHMe4yBoExzlvk6BQZBG0BgjgMVvZ6tBn7WO5KldYK5TBXV9j5efSPvHcf2ORZo/aieFyUAEeNlmWsdZ2CNzBHbAcdikn4eN7M6XR+TK4wewZh3/7ERixohR6WUfbY7kI2AJWpPIuEB/Lmql6PT2oC9tqSgrBZy/pVRPoAGaaTrJ+oBnARwbJk80PywIgCPAjbl2oNaSePnueYRXB3aQ+M51Z1RzCQ2rSAOOXGkLsfU0EaCCSd4kgHXdnJASG+hwRQwBV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 11, 2023 at 03:41:44PM -0400, Johannes Weiner wrote: > When claiming a block during compaction isolation, move any remaining > free pages to the correct freelists as well, instead of stranding them > on the wrong list. Otherwise, this encourages incompatible page mixing > down the line, and thus long-term fragmentation. > > Signed-off-by: Johannes Weiner Hmm, this is potentially expensive in some cases but it's also correct. Given how expensive the whole path is, I doubt it's noticable and some of this activity will be !direct_compaction anyway and relatively invisible even if I'm not a fan of hiding overhead in kthreads. Either way; Acked-by: Mel Gorman -- Mel Gorman SUSE Labs