From: Andrew Morton <akpm@linux-foundation.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Zi Yan <zi.yan@sent.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <muchun.song@linux.dev>,
"Mike Rapoport (IBM)" <rppt@kernel.org>
Subject: Re: [PATCH v3 0/5] Use nth_page() in place of direct struct page manipulation
Date: Wed, 13 Sep 2023 14:12:04 -0700 [thread overview]
Message-ID: <20230913141204.b32ad42ac917c0e393d82a24@linux-foundation.org> (raw)
In-Reply-To: <20230913201248.452081-1-zi.yan@sent.com>
On Wed, 13 Sep 2023 16:12:43 -0400 Zi Yan <zi.yan@sent.com> wrote:
> On SPARSEMEM without VMEMMAP, struct page is not guaranteed to be
> contiguous, since each memory section's memmap might be allocated
> independently. hugetlb pages can go beyond a memory section size, thus
> direct struct page manipulation on hugetlb pages/subpages might give
> wrong struct page. Kernel provides nth_page() to do the manipulation
> properly. Use that whenever code can see hugetlb pages.
for (each patch) {
Can we please explain why -stable backporting is recommended?
Such an explanation will, as always, include a description of the
user-visible effects of the bug.
Some of the Fixes: targets are very old: 5 years. Has something
changed to bring these flaws to light? Or is it from code inspection?
}
Thanks.
prev parent reply other threads:[~2023-09-13 21:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:12 Zi Yan
2023-09-13 20:12 ` [PATCH v3 1/5] mm/cma: use " Zi Yan
2023-09-14 2:16 ` Zi Yan
2023-09-14 19:05 ` Andrew Morton
2023-09-13 20:12 ` [PATCH v3 2/5] mm/hugetlb: " Zi Yan
2023-09-14 2:20 ` Zi Yan
2023-09-13 20:12 ` [PATCH v3 3/5] mm/memory_hotplug: use pfn math " Zi Yan
2023-09-14 2:35 ` Zi Yan
2023-09-13 20:12 ` [PATCH v3 4/5] fs: use nth_page() " Zi Yan
2023-09-14 2:45 ` [PATCH v3 4/5] " Zi Yan
2023-09-13 20:12 ` [PATCH v3 5/5] mips: " Zi Yan
2023-09-14 2:46 ` Zi Yan
2023-09-13 21:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913141204.b32ad42ac917c0e393d82a24@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=willy@infradead.org \
--cc=zi.yan@sent.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox