From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D866EDEC50 for ; Wed, 13 Sep 2023 13:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5936B0195; Wed, 13 Sep 2023 09:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54E486B0196; Wed, 13 Sep 2023 09:31:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF696B0197; Wed, 13 Sep 2023 09:31:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 294B16B0195 for ; Wed, 13 Sep 2023 09:31:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EA97580400 for ; Wed, 13 Sep 2023 13:31:13 +0000 (UTC) X-FDA: 81231660426.28.FA267A6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id CB64B4002B for ; Wed, 13 Sep 2023 13:31:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=duYyjGYK; spf=none (imf07.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694611872; a=rsa-sha256; cv=none; b=Z/5cPpgqFVJUpeHKfdNLSPhPQwNAP1kAM9zoFgSr1cZ/ZK9MSxkZ+6/vFP0J+o6/68GLt8 T106npHle51yUsUP3uW9VgZYJ3oQ8YsicCh1JSQDd2PWaijeMFwGfo+6lBzplSNeVk/eOq MPdxoPngrKqUtGbz7BT+BwVF7cuITno= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=duYyjGYK; spf=none (imf07.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694611872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J02MLXhFSfuoyeCLtw6xtYkQzGZj8lJYYE1pS362z8A=; b=75i2tN7EdP0qhjhpXxvV3mqDUuz6QHWUB0/QC1DdjQ+aLnf9+5SSkHzQ4pnsH5VahbL2/v iKlc4GSao0oLWQr7xUqqPSeJDL5bGRXOzZ+kBZeKZkzg/fKkivZozWeggATs/dzTcTBU+D hUUph/HzzW2QlqjJh2EUlJnlmjpV3FM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J02MLXhFSfuoyeCLtw6xtYkQzGZj8lJYYE1pS362z8A=; b=duYyjGYKubyex3PQdSScxDz1aF il/Q8YmExU9Mzldgx7QIP0lxDZPqy6BKP2nfpqXXo4on92wG7lMYwXtnn/cdM8QisxCBFT6/YVZp7 zdZfdOVIGgZYiQ9OQzxzORBxaxYqIY2Aqu8zF9zRCoYsD3BLzfCPTTHyQmMbqdpEVR9JQxjyXAhR7 V1G7uemUZylGxIk7FJGyeu6zb4o2kRARWmF7dEVgjF7IDvjpQqEQ3ErQbHcI0mZ8u7k7DZk7O9N3U JNkA5wdNK4IrPbz1xMZsZPwbhxk5Crk3YyatBBCP6invFKI4GX7UPE+Y1kUHz/EXIGQ6mQJiy/mwb ddkr3tGw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qgPxR-00E5zI-Sx; Wed, 13 Sep 2023 13:31:05 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 8BA83300321; Wed, 13 Sep 2023 15:31:05 +0200 (CEST) Date: Wed, 13 Sep 2023 15:31:05 +0200 From: Peter Zijlstra To: Lorenzo Stoakes Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, acme@kernel.org, urezki@gmail.com, hch@infradead.org Subject: Re: [RFC PATCH 1/4] perf: Convert perf_mmap_(alloc,free)_page to folios Message-ID: <20230913133105.GF22758@noisy.programming.kicks-ass.net> References: <20230821202016.2910321-1-willy@infradead.org> <20230821202016.2910321-2-willy@infradead.org> <78cc53f6-3828-4802-afc5-abb71dc59627@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78cc53f6-3828-4802-afc5-abb71dc59627@lucifer.local> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CB64B4002B X-Stat-Signature: sdhjd7fc3drxzurnbthnc7kubdybzuhn X-Rspam-User: X-HE-Tag: 1694611871-83896 X-HE-Meta: U2FsdGVkX18Xh1FpkQWAIY24lQVte0J3TLrYFC/gFSuSc3YTZ6WifU8p0FLJ4/4825q7ruIXEQWqg0as9O5XKp+Id0M6zTHU8oVchOKydUUwJf5ed7fTUq2Rx0wOXwLkj3LXF9BYr4o14o91wlNuG2pFS4Xe/Nv4gDYJVPYElQyvVd4KCN6oiivstYcoDgpeFe/JAXoOmCJARBoCCtNJnR+Emre6t5IP3IpdJhoIVOOZKHRxShsMdCryCvguIKE0yA9jmjaxAs6w5jrj8RJbMEcqQssAkwSI8Tlla7Mikoq4g0Mz8MS5dxatllFjITyIN+xfax1vwS+DrZZVMGeT+5gb1wPrNJ6g+97A0Smz8RtsSvNg6mmTUok+yL80cyJzrsYL7r0vi6VV7KvPnVpBjRlGAI6fyRHHYyNL6+0LMgy/6dguKfs9lCPhhIZw4OQlbOhoDKX8eKShS7ckRPEyimqOrxoHhdMQupCe3T5Md+I9FZ+prRT0ioSojj43sIeUiIMF+dS0ixJUHa70DQlC31aP6zWCQPJg9vl7gy3aBERRyGD6uuEetNphGtiHemva+4Yr32DMY4zo+Ouy1OpMJrW/IB2u+rvZ9LVifCKUBJzVwXrXNNdwPXttX2cQJBxhPBFcSVPl244wauQwqan3RSCgoxJp84MCAUQPpZz/CJHV4KYCeOXkkAA4k/7a/NMPIdSWIoP71zssjWzR5O8WimoG5q06DswJvuElG50zIHkwEowc2I3BdYts7iSxUWun0WrF7gOaKz1OXYsgmGBxRu5ixelhghFt4ZckvEM2UsnJFR4LFcwbbRFZ08zM8VGT6K2UtzKouH9HuUGEI/BLf6RkXJxULWzJD7eI5X6r+NpcjTShs8lnWlzUaeDRU6cVJyqTknCibnSZNN3OFKdOFMoyzqSPrCkhPviuuIH0gqK/2CSuXJgPy8pPH9dLQr6Ax3083mmejV/3Em2Npol tcDtL1UA GHhUqrlggA/N+xPAWPjz3O7NQaWtDPNg03dBf1+8P+7Fr/PA9gbmGFtwgoTPj+C0d/yUSfOm9t2zKzNML7BZIl2yDQzS/FAEto6Rc/hKiBXQ7nKG4Gigj740aMIeoJAEi1HM5U6DJTdwJhIMSCfVZxfqXcaTI8ghsYGLnrPN7y0A18EKszIRmS0whoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 08:33:39AM +0100, Lorenzo Stoakes wrote: > > @@ -785,25 +785,23 @@ __perf_mmap_to_page(struct perf_buffer *rb, unsigned long pgoff) > > return virt_to_page(rb->data_pages[pgoff - 1]); > > } > > > > -static void *perf_mmap_alloc_page(int cpu) > > +static void *perf_mmap_alloc_page(int node) > > Nitty point but since we're dealing with folios here maybe rename to > perf_mmap_alloc_folio()? Since it's an explicit order-0 allocation, does that really make sense? > > { > > - struct page *page; > > - int node; > > + struct folio *folio; > > > > - node = (cpu == -1) ? cpu : cpu_to_node(cpu); > > - page = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0); > > - if (!page) > > + folio = __folio_alloc_node(GFP_KERNEL | __GFP_ZERO, 0, node); > > + if (!folio) > > return NULL; > > > > - return page_address(page); > > + return folio_address(folio); > > }