From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42B0EDEC4D for ; Wed, 13 Sep 2023 13:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 572396B0191; Wed, 13 Sep 2023 09:24:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 522966B0192; Wed, 13 Sep 2023 09:24:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA2E6B0193; Wed, 13 Sep 2023 09:24:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2F2BA6B0191 for ; Wed, 13 Sep 2023 09:24:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFF20803CE for ; Wed, 13 Sep 2023 13:24:16 +0000 (UTC) X-FDA: 81231642912.12.EB0F0CC Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf11.hostedemail.com (Postfix) with ESMTP id D2BF440026 for ; Wed, 13 Sep 2023 13:24:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=uPayS0Zp; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694611455; a=rsa-sha256; cv=none; b=nB3RcQVu0OdLVrtwqjCgGl0YaQiVj2iwnezxc/AoOO+SGvYTuqNpZXC0+hOX/ihkc2sajU 7zex8wL6qpKeu47VDncPgrts/XnT4rI1L+yzoLQjZ/TSPugFhAGVbsnW3DbQ4D45yoo0Hy Wz2cyGISVMLXwFs2m+zk130nQcA/JT4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=uPayS0Zp; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694611455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IAf3ai1JuGA4NVKNvsJwZNxVrsDBH8DKtDQzp9gt1XQ=; b=b/8LwlY8QFgSwDF8iLyQRBQNhkLFSvqGly5yFFnvjr2pPoMpa/LQb6FR0tHCm3Z0oVzL7J 4wfOE0lYU4SQyrBXzoL0ffOvUE1brcodcXeqZiYsO3Ike9YEv69+dcd3xD1IYwIaU1p+nt H1wzOAQi+QVw+ZXr1Q18FYfCrZSvW1M= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-655d3365d88so26423486d6.3 for ; Wed, 13 Sep 2023 06:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1694611454; x=1695216254; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IAf3ai1JuGA4NVKNvsJwZNxVrsDBH8DKtDQzp9gt1XQ=; b=uPayS0Zp4+5JRB34Rzphqu1l1KBlz3tQOU0uNhUbaFZZFFZ0AFKY/u8TBu49C7zNo7 b1JZVyTCqjLFkAtORicP4Q3F60NTvcCd3wL/+yY+d59cuVcjCrAz2OK+xymUVzJWBnN1 pGQSOXFTFSjRQ8Mcl8sZPaqnehJYgLt3B3j9LpjO2m3cUa43LmrnOGY8zbfkqZaWBwjo 2Ur6JylSHKwFZ8KjDhHb3H/yksLsi8qWbzV+VtE6CeTBbLR61y799e+OYNpyDuXNES0g RpkI8U3f1Ww3cvkjGynWi+TKQtyChwhPmSus112VBafyneBN66rkRZain9+srgMtzRdX 7PIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694611454; x=1695216254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IAf3ai1JuGA4NVKNvsJwZNxVrsDBH8DKtDQzp9gt1XQ=; b=UOGnar0ZTDaEBb2mV7oWqRmFc1afrQbSJ1/RjvaVL5QYSJb/NVoHwfi7kG/JyRUN7k bIKvciB/oQdKXm6Basc/ypvmvvZORFuIDT+rJ5R3XHutPYBg5ukIV78HPEwRishDjwgf vLvs0m3usc3D+170yr8GJuQIdpawRjnwdEOhv3IqaDqFY6Ug/KIAkqjL4w3dFMnZ8KGi OHwMGZtxi/jz7OBz+K5KRWrgOvy1yQM0gAtACy/3AeRuhCDSbaykV5btEZOn9zeJulto 1iDtUVJKJP3pNofeMBe7ABYYL0zDEtGgUg2kgWANjxw7Mi+Wbtg5B6GV0n+fiVxKCwfO ryEQ== X-Gm-Message-State: AOJu0YzryWBo+JXDDhf45TEll9XHAGwwVVt1g5n9/HHXJz1ivN5SPu7t VqY0Xr0uGTg1r70BpIlmTfIrcQ== X-Google-Smtp-Source: AGHT+IF9vwW2GPRldJIXMKcI9WkYNOX1cr4N2/uc5cVdKkGOWzuOZPuHQccnppK9u1pfdDZCHqAGnQ== X-Received: by 2002:a0c:f804:0:b0:64f:5228:d4bf with SMTP id r4-20020a0cf804000000b0064f5228d4bfmr2241319qvn.62.1694611453706; Wed, 13 Sep 2023 06:24:13 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-3012-16a2-6bc2-2937.res6.spectrum.com. [2603:7000:c01:2716:3012:16a2:6bc2:2937]) by smtp.gmail.com with ESMTPSA id d3-20020a0caa03000000b0064f741d2a97sm4480552qvb.40.2023.09.13.06.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 06:24:13 -0700 (PDT) Date: Wed, 13 Sep 2023 09:24:12 -0400 From: Johannes Weiner To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching Message-ID: <20230913132412.GA45543@cmpxchg.org> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-2-hannes@cmpxchg.org> <20230912145028.GA3228@cmpxchg.org> <320c16a7-96b7-65ec-3d80-2eace0ddb290@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <320c16a7-96b7-65ec-3d80-2eace0ddb290@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D2BF440026 X-Stat-Signature: o8tijei6m3q34ftx4q33nzi1gwdhe8bw X-Rspam-User: X-HE-Tag: 1694611454-632820 X-HE-Meta: U2FsdGVkX1+24gj446j6JTR0onPXsV27V/3wa5whPK4As3vpD6Kj6DDQ3IZ6hpxUidroApyFtfqvhvncA0TTIp1b3h0p9sdoMQFONy+PvT5KMm9v4SxIcl5NJcaec+cmNkT1TeiwIQOT5pAbHj4VhJC2vevwz+V4C/4HdgYRPY/h2b7U1rEOwxckksZqnZdEvI5eHQ2JX2jhumychCxENgC9XC61M4lVGwvhR+rtmUxhBMKYOK3mJ3R9YGTH1KXO8CW73bPpWtbHg45evtGwhqDzVbO5BV2prOtOvh5J5trOHjTXkiDSy8SgPE6KwumpGSEfrCuIE2RxBu99B0CFHZhMR1YQ5840MYoUVVtzhC0uruIVmBN5yrJpCnYPJA23nkidQN2ub7GA3ZO3+UFmjdgczDJk2FDa9t4rk7JvX5RlVMGojzgezJODB4DaV2yHU0Of6RXswN4mNAYJaiodlGjDqQElnVlTt97KSvacJNc2IYXKWcyxiHe7TnksscpDNrOOeYSCXcMc1Jxt8ZjZCSTTjV1RWclCD+10Ro7b/iLKlMiYx2hnL0YBoiFXNeOX2ev6RvRxBSLSVa+szQjh9e8B+kFXJDkpZPeVDM1SGqYDKO57JASDtMzgdLq1VHLIseHZAk0DHmb2ScMvKxkxSVT9khEELUHVzLAL6GACwRKOKJD9hsdHY60Z5sOFSwuyOV6owatPrbG4EI1y3rkrWdWxT0mXoXGu73LPcVDVT8E8OpSDoxJj1dp0hBZIRjf4l5mIyfqvTo4LA6KDr2buk4KJ+eVvv09hZQk3eVFhxcERqodOXA6lnQlEMWS6hmdCldbNRJlGr1mKI9kYpzeSRzYpCJzewfGcXhv9D+K9WlGFtK7qaq3CWR+87HGMFKu+N6ySddvYoAa5jRmq6OA5LaH6xuMirLF+Br5M7XsXUM1LpjjtRy4ondkg+VaBSGx25vr4zgVlb64jJttVRfv jGlosyXV DtmYTaNCp3kqjzyeqRkjtMi4vEz0HJd5he3Z4otzEeBq0j2a1mIW4GQCRF4XPkn1ry+yAGj7A27zO5R+KZLy7yTnpBwBHK/l3ATnR3a4OE0aVmG8zVjtOr50r5gfQNzxL3f+Y5CLnCPNsqyGvEUbmmui8kjQA25d6D0drpdGjgZ78XLWkkMRE5kZG06F/iJHM6XYSnL2Svx4zzYl9NZ4CKNZd7jiXYQdRxXK8Dv0LgfQFrO/emU5KGOyWovnaLvziyOskFlS043U92xSExKaX1geq9F2HTl77GWKtUKPzgBEN7zcSIA6Nsjv2+EUcsRK0m+eNEY7WvLnfwn/mfZAzxmrvchAAiOG+L0GRkZ6g4Sww7ZVkJTft1KyVN9Gn3tAP6M12IPePeqgdEiTSTrEADfX6UGPfVh/NHOS6rkA0N4r/ledGVPUZfUVvEeY2f9t7wYApVq0CDlYpw9AsZq0csGveo9ODtTLFcIWbbBP5bi6IybSEvKB1u0FpBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Vlastimil, On Wed, Sep 13, 2023 at 11:33:52AM +0200, Vlastimil Babka wrote: > On 9/12/23 16:50, Johannes Weiner wrote: > > From 429d13322819ab38b3ba2fad6d1495997819ccc2 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Tue, 12 Sep 2023 10:16:10 -0400 > > Subject: [PATCH] mm: page_alloc: optimize free_unref_page_list() > > > > Move direct freeing of isolated pages to the lock-breaking block in > > the second loop. This saves an unnecessary migratetype reassessment. > > > > Minor comment and local variable scoping cleanups. > > Looks like batch_count and locked_zone could be moved to the loop scope as well. Hm they both maintain values over multiple iterations, so I don't think that's possible. Am I missing something? > > Suggested-by: Vlastimil Babka > > Signed-off-by: Johannes Weiner > > Reviewed-by: Vlastimil Babka Thanks! I'll send this out properly with your tag.