From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC029CA5537 for ; Wed, 13 Sep 2023 11:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5814B6B0185; Wed, 13 Sep 2023 07:00:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 531156B0186; Wed, 13 Sep 2023 07:00:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41FEC6B0187; Wed, 13 Sep 2023 07:00:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 339AD6B0185 for ; Wed, 13 Sep 2023 07:00:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F39161A0DC9 for ; Wed, 13 Sep 2023 11:00:17 +0000 (UTC) X-FDA: 81231280116.22.61002B7 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id 020181C0024 for ; Wed, 13 Sep 2023 11:00:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694602816; a=rsa-sha256; cv=none; b=HQMGx3nOKPpa0s8RMkUR1NdUaXoM5+fnd0mDXzEp41BLWWN2lKToSMZbCTphg3SwUjiCdz f2kAyiphyYUUxzTV0Hb1oVSygdbcLl7QfPcuNEYGvbHgA2zsrnQeDcLtsuuEWJoP7Nrm4D tA4rq+V66awg3IiBkujpfHwf1dRrHhA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694602816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWpz9gRN6obfJOnKYsp/WP+TvPYvT0l1eRBzzlL5npA=; b=QNY7/hwuZfa0rUZg9QIXQrtXanLkNgjbm0CsNs7jFHic9ljuu9/NN/jJM0rCwW3TEtY8wc ZZDp9E0MVVY7j581Kn0TbMYQcYvh++7IlThYOfuzrmH9z+Ae+ZIw4iP3scYdE/IKc0xym/ rKH5QXIeOag9JAxB+d6ScKe41XxQ5gg= Received: by verein.lst.de (Postfix, from userid 2407) id C3BB268AA6; Wed, 13 Sep 2023 13:00:10 +0200 (CEST) Date: Wed, 13 Sep 2023 13:00:10 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write Message-ID: <20230913110010.GA31292@lst.de> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230827214518.GU3390869@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 020181C0024 X-Stat-Signature: ebtjigug41tbsr9nyuf9xwihwuiheder X-HE-Tag: 1694602815-944602 X-HE-Meta: U2FsdGVkX18X8uSgndpCxKckRoqrATRmiBHgFSrYB5Z2D0sG7QDGWfeVnhneK8R0YVVev3yEG54GQ5XbfoUtBgmMfPeKjyZyOrL3yhTZkAvBIp77oNKjphP31BItSzu/f8sR813+B+n93dXy+W8mUDOSuZcZ/8V3fX1/tEb5DzGz2qv0NJLh20JulHX940iE0uKheUx1SBmLM7sAe3VE82awTY7HUq4GZkxI0zvis4nyjTYOeB4WVAvtuAMAhMBpwK8YMZJcnwy7dpboPfctFSnBbTscAfOET9+GA7ntcWS8tuUm4qU3lJ5gKyX3VtABtl8XoHUbtRVuVR/piejKoVRRo4QjJKwA62LNfwLhMtv9O3YNuA6yqdtlH5ZPe9fazo1wARF+2jU4VsGtshGBXoO+NoD/8/i7iEHkii73pDxv5IKzwIJ4QTDarlJsotV+vpKdivgXW1BgIYYWULL9FzP/ATdOehhVlutR8OrVzIPjSa6oAORzUMo+MB1at341AkmOVIXBZnQ+Dy5n0SHG0ZBMOat4PG9uCdibXauiterRVnadxv4X4v77y7OS8AQ5+eTN6Uf6pbVd2ISdsVIm7i1zqogWyU6qHr+aCVqRzmEGgQrBSthrr2NxR/XAv34EHgvRu1PMImJX7V2t0EJ4S4f6zRE4H54eiOlaZy2rcwecOPLW4J/HonoRPyKqQTX1vN5IRHXpVR1IVHnHOR6uBNFJeoI42UhqPmLpVyTPZzLPWz3sx/orpSBX/qn55PTl2tI34kIznql6tyharvUV4sQy3o3LyILU+BQiHGzKhV+ln1TDoXqWKJ3fCWVimXn14dFRNft/MQ6uMfkG2Pt5eSp91qJLwyj2VLDBxVMy4qWxoL4CThqzv/igEqzYQFLHkcaLKPnsG7QFe0JNEvDDqgj+Z3TCeDCLPCJhZq80ZQQPFrkArByQGqZxLdb/oD8bNGb/YcoBZOUuiMKeVzj ssSxNIK+ LFRQNRZba5/VRihcD7u5cF5nIEk8x6oN5RFxtiiuaopYqnhXPSWdjs64CcW9B3ND+phkFsLm7UWQZ3odGM33Rm5DH9LnyrthSjAVZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > direct_write_fallback(): on error revert the ->ki_pos update from buffered write Al, Christian: can you send this fix on top Linus?