From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC7DCA5534 for ; Wed, 13 Sep 2023 10:54:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD0086B017B; Wed, 13 Sep 2023 06:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59286B017C; Wed, 13 Sep 2023 06:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E7EA6B017D; Wed, 13 Sep 2023 06:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7ECE66B017B for ; Wed, 13 Sep 2023 06:54:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 51C55C03B9 for ; Wed, 13 Sep 2023 10:54:12 +0000 (UTC) X-FDA: 81231264744.04.837292D Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf02.hostedemail.com (Postfix) with ESMTP id 5812D8001C for ; Wed, 13 Sep 2023 10:54:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=EQg1IVhA; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694602450; a=rsa-sha256; cv=none; b=qs8W03RdX1g6nmupvR/mcMunSLUL2FBE7s3EtyeGMRhgt/bfVN6ZpqUOZ9bla6wPdhDsY1 ivEXRpN/kblNG9cgDmnLP+IUxnI+Gvp05WG2BulwH3TVI9XBZtNhp50wMggJcHrLWjmsAT hvqfbEpItgO79DjWq1YyDuE4SF8Sbrc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=EQg1IVhA; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694602450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xz27K9YR9w0fQiJ9Te2x4N9NzQgI00KGt4T8XMBUFg0=; b=ttcJYYnlQqoPblK/A1Amk+S9q21KCNWlDhzacPzZjHkoqA665ldin+7BkQrZ6Egs6JFVyF JjBLxsYciW90XMqHk3vAHE9wc3h56rgzEBXzANzBcOAxJWJp4OMtSE/R9hGs0f09Oi6m3/ ewORppWHqOuW+FGJdayr7QwGIhRinL0= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-402cc6b8bedso75445435e9.1 for ; Wed, 13 Sep 2023 03:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694602448; x=1695207248; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xz27K9YR9w0fQiJ9Te2x4N9NzQgI00KGt4T8XMBUFg0=; b=EQg1IVhADuXDfFXrF+0VBDuNSoybY85KNBlcvUFDvx6yLd3Z9VrOZckFsRn84GSOR0 bqGXhvt5lLyac31QQDUFsXw+YKufsOo/vwRw/TiKlB0TmqD5+o6hmkLMvmXhqcJ6lpJq auWSc2fznqBIpQvrsTzcWRE6TjlnSBwzUxd2i+kfRsooeqMHSOsWKNXQpEPC+5oU3+Z1 GMeR6dLZqTZQZ7TwpjArq3boXCAz/ZH5v+uXwQeLvEmaazmCeFYv3XJDnmxK1h0U4tnC eysPFy1Sb4mur1CT5Ve1y9aXyigu2oC1hWye5kI+JEJ6K/2z/wLqJ2bz8iK/donca3HI fFzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694602448; x=1695207248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xz27K9YR9w0fQiJ9Te2x4N9NzQgI00KGt4T8XMBUFg0=; b=IlfM5v8BtWDUFvVlfVQB+6YRbCdcUS5von3acCBS03NFBoOM0oCMvA9JsIrpb6rlmF I2P4DpWLErm0utJ94eP/8Z8bwQTdiRDAD4axHvyS8PTc7JYorgR6fbbwMAJjlyFazWfj haXmBUf2BPLM5cjaHrrhClFNlkJBjm5XiCoJ4QgWyJvvqt67KbYbtMW37KffamgIxf23 +jo97tU38mu2rr6uIfD34rXrYSUXpUH1u+QisQiQFpaYLvMQQjRb4qRrNdejGjS6eeiV XhKY5oBA6uiQmd1GqOyBZZE1OXjBgN7aOADfPUY9F77KF02FZy5vieZ+78x19ohpDigV nYLw== X-Gm-Message-State: AOJu0YxTxV1g2f27SsU6RZ6nsO2BoSeo+uyI2Ow3dg1+9tWuNNxetS3J sEX9fpdBVlH3enNrH6OXgVnQa5L0+XHDhtWRiKo= X-Google-Smtp-Source: AGHT+IELq4IpOoGAAOVl1ZdlRYGeDT1zMvMdNhwEFXBsF/9A4wBjX2ebeHr30qj0D/lpVvMZsIc+Jw== X-Received: by 2002:a05:600c:ac5:b0:401:d803:624f with SMTP id c5-20020a05600c0ac500b00401d803624fmr1620823wmr.4.1694602448422; Wed, 13 Sep 2023 03:54:08 -0700 (PDT) Received: from localhost.localdomain ([2a02:6b6a:b5c7:0:59d5:28b9:7f13:cd1b]) by smtp.gmail.com with ESMTPSA id p36-20020a05600c1da400b003ff013a4fd9sm1757055wms.7.2023.09.13.03.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 03:54:07 -0700 (PDT) From: Usama Arif To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com, Usama Arif Subject: [v5 3/4] memblock: introduce MEMBLOCK_RSRV_NOINIT flag Date: Wed, 13 Sep 2023 11:54:00 +0100 Message-Id: <20230913105401.519709-4-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230913105401.519709-1-usama.arif@bytedance.com> References: <20230913105401.519709-1-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5812D8001C X-Stat-Signature: z434zxutyhwt16eae8d7z9izxfgb45r8 X-HE-Tag: 1694602450-971195 X-HE-Meta: U2FsdGVkX18Em2z09Mw0rAxkzUquGcy94lHV7cv1apxEiv/7KG22b8cICXXSWpehflzazBnqHm27X3Ez2+39BW7LsLdMUxK83HTVDIOvz31astrPtUawjvZnZsRmgqzhkOIBDOTclQhr/WzcNIBcVfY/PegjdIBY9DrWgrM89s9OeW+vTXPlIeDUwNtRCB3OvimgwOAsc8X+Ri0WkdJIKJQYq4YOFN7S2QNYdmxFifZL/qQrO2EtxfJ9tyWiTNHz+xTLy0Y/CxTb4RwyrM5Wf8SXKu0LYewpL97AXgbmZnyV0SKmiXzc7MWMzY912AnCUif3m3iCh+37TP98mpBBMXhGY/hzmfvfmScMCaq7C1eaD10L0eJ8aWX4poNGS8om9uryu+cQxRWtB3GnqvAgpZDeAbwXImd5lPCqi+5M5mMSVV/e5mXEQ/x197+PYgyqr3b0jvCkeAiYEQqyv6IjPjd8EDgdoXshpdpwt5S5KtK9Oc26Q70XDh88uX3BalZCstF23kHS2D0WzVANwZGNZe03sy6e0idJ84csHIj81g3be9+efsfKH+ROCRl5tRQFJ/rbgFstC/dZUHNuN83IkkWHEnXR2pj9EYJUp2f2DpNATGg8VOctjfEE2eSO3jTAt8CqXtrnpjxLpbptHNYw5hwFdOSwi3H+tsWzIAylG+XJXLKuYZZRPoyNh6cWuzHI2dLNhwtNoEsg6bWve1pnddV8hCiIjJaPHF14nPnoF+FTJh/v8Vxr2wfeWId40be66ln00IbTSyo+J4uWCpipqbCjIY87249HiG0O8hDXEvClQUCVqnWL7Sb3HBtL2L80Y9mYY5M0hMpLkOdJhjMXv6SEDe12tZi+5D2HC4ZjacvSdNQtgVf27DsKM15DfaRS93X6LyqzwsRwJOPsb7YaYAg6l5RplmYngRAECGvMuZEGOOBxMNkTq2FLQtcC7e+uUlt3Ln1UXMyfmgPIlcW eohk9+kM 0HOdV23mmkoCSovZeM04JEmCjD6ooEoB0XsetSpXm5zmzmada03IkeTTl9AMO4H8Rxm4vcjgMgm0Jl3OX5GQg+HWkpdpfLJcFefZIq6gZDRizBDCQ4b0E5lHYLvUdSLsedmgqRY9jajb32WA6/B9k8QGkGk9xQ07zUzB4tLZSCUSmcrAGjnjy/6zCTIQvI+UzEB597pwOCbOK2tUoR0vqbc/firFgB+2iSb8/v2FIgJjhE6ImG9UqR1ccAtBL1TOGoPz/h/LW4OzG7jPD5qd7DKaXLnqCo5xVzHxpF1Dy5MTkOTJeZ7qdkgI6o31xXz2IdZHIHEj8E5xD8JgiXv4fqPKPnqxBl8tSVIOapVx85wZwc9JUEIzOXTypor7uNBWiYXOja/uIAPb3CYNIRZbDc5F168rS1jf3NmOi2pQwcZf5hMCyplmrfbdMzMzYxmtvCzik3INlr805kNmVRtgDGBpNka9zilTQFe4I/9x74BntCRB2JAfdQKcL92jpg0i+z6+e0/zSdoAcRcFg4X04HLNEIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For reserved memory regions marked with this flag, reserve_bootmem_region is not called during memmap_init_reserved_pages. This can be used to avoid struct page initialization for regions which won't need them, for e.g. hugepages with Hugepage Vmemmap Optimization enabled. Signed-off-by: Usama Arif Acked-by: Muchun Song Reviewed-by: Mike Rapoport (IBM) --- include/linux/memblock.h | 9 +++++++++ mm/memblock.c | 33 ++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/include/linux/memblock.h b/include/linux/memblock.h index 1c1072e3ca06..ae3bde302f70 100644 --- a/include/linux/memblock.h +++ b/include/linux/memblock.h @@ -40,6 +40,8 @@ extern unsigned long long max_possible_pfn; * via a driver, and never indicated in the firmware-provided memory map as * system RAM. This corresponds to IORESOURCE_SYSRAM_DRIVER_MANAGED in the * kernel resource tree. + * @MEMBLOCK_RSRV_NOINIT: memory region for which struct pages are + * not initialized (only for reserved regions). */ enum memblock_flags { MEMBLOCK_NONE = 0x0, /* No special request */ @@ -47,6 +49,7 @@ enum memblock_flags { MEMBLOCK_MIRROR = 0x2, /* mirrored region */ MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ + MEMBLOCK_RSRV_NOINIT = 0x10, /* don't initialize struct pages */ }; /** @@ -125,6 +128,7 @@ int memblock_clear_hotplug(phys_addr_t base, phys_addr_t size); int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); int memblock_mark_nomap(phys_addr_t base, phys_addr_t size); int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); +int memblock_reserved_mark_noinit(phys_addr_t base, phys_addr_t size); void memblock_free_all(void); void memblock_free(void *ptr, size_t size); @@ -259,6 +263,11 @@ static inline bool memblock_is_nomap(struct memblock_region *m) return m->flags & MEMBLOCK_NOMAP; } +static inline bool memblock_is_reserved_noinit(struct memblock_region *m) +{ + return m->flags & MEMBLOCK_RSRV_NOINIT; +} + static inline bool memblock_is_driver_managed(struct memblock_region *m) { return m->flags & MEMBLOCK_DRIVER_MANAGED; diff --git a/mm/memblock.c b/mm/memblock.c index a49efbaee7e0..8f7a0cb668d4 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -996,6 +996,24 @@ int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) return memblock_setclr_flag(&memblock.memory, base, size, 0, MEMBLOCK_NOMAP); } +/** + * memblock_reserved_mark_noinit - Mark a reserved memory region with flag + * MEMBLOCK_RSRV_NOINIT which results in the struct pages not being initialized + * for this region. + * @base: the base phys addr of the region + * @size: the size of the region + * + * struct pages will not be initialized for reserved memory regions marked with + * %MEMBLOCK_RSRV_NOINIT. + * + * Return: 0 on success, -errno on failure. + */ +int __init_memblock memblock_reserved_mark_noinit(phys_addr_t base, phys_addr_t size) +{ + return memblock_setclr_flag(&memblock.reserved, base, size, 1, + MEMBLOCK_RSRV_NOINIT); +} + static bool should_skip_region(struct memblock_type *type, struct memblock_region *m, int nid, int flags) @@ -2112,13 +2130,18 @@ static void __init memmap_init_reserved_pages(void) memblock_set_node(start, end, &memblock.reserved, nid); } - /* initialize struct pages for the reserved regions */ + /* + * initialize struct pages for reserved regions that don't have + * the MEMBLOCK_RSRV_NOINIT flag set + */ for_each_reserved_mem_region(region) { - nid = memblock_get_region_node(region); - start = region->base; - end = start + region->size; + if (!memblock_is_reserved_noinit(region)) { + nid = memblock_get_region_node(region); + start = region->base; + end = start + region->size; - reserve_bootmem_region(start, end, nid); + reserve_bootmem_region(start, end, nid); + } } } -- 2.25.1