From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FCACA553C for ; Wed, 13 Sep 2023 16:33:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 198796B01F0; Wed, 13 Sep 2023 12:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 148A86B01F1; Wed, 13 Sep 2023 12:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010186B01F2; Wed, 13 Sep 2023 12:33:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7D676B01F0 for ; Wed, 13 Sep 2023 12:33:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BC276120E9F for ; Wed, 13 Sep 2023 16:33:23 +0000 (UTC) X-FDA: 81232119486.01.ADADAA7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id 051E4180017 for ; Wed, 13 Sep 2023 16:33:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JEIWOoDe; spf=pass (imf16.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694622801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q6aPtxLCYed//nrPJlN0YolEEgZg0w4fKTNV4B0HzRo=; b=ulOK7wIo+i7VxMVhSqbWU8H2QJIJIIAfD+AQa8Sj0C4KzgcK6NfHGQ/ZK9AyIPrOBpSH0J 3bxWpCFkIwlFpb5TXwqcjIQ2TkKyBH9wARDsef5N5Yh1afOLXgRmxGdpxq47LWvVVB6X4Q mcB7jZgdc2wIPBMhn642UMmzTr6Q8fg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694622801; a=rsa-sha256; cv=none; b=YRv9U6G365NZuo4FjwGQjQ64w24YjN+sNLy7Hf0QoA+97Tf/SLJWp3dTO6dCJ7x6LPltZl aaCivl0uVTXQNlMVZci31w/L4MNVy+NFXFZ4Rndo8SmY2VodkeWOrlc3Ai+flKMrYvuLz+ 8RQtX6Uz9a66K42KeVNpZuTHjWgS+IE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JEIWOoDe; spf=pass (imf16.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3E1D5B8252A; Wed, 13 Sep 2023 16:33:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C43C433C8; Wed, 13 Sep 2023 16:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694622797; bh=/BE0SzPSHWJUDQnPrCfnTnaEO0Ee7ixrpqIiDWWi4pg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JEIWOoDeYw0Lf9hWj/zCyZ4x/rGCa/NQnygF+m0lMZeczRYWp/+IE53tvWyCKZsG+ up2zc8mQP9OdLjIt3ieHpSW+DbqQjZbKoxHgYka+ox5B/duraDYwWYC2flCW6yQuBT cv0SrfJZcsbNKoo8+UUGobBcO+5vSh//zaB0oCO1AkX/JNOxsSLnUA74YuG8d2qy// xSekU6sH/2OHlD59lMaI3d2pMSviFkxZRQRw7TX7MfD7+om+CEtOj6/4xJ6+C+s9aW E5R98PPdfp9ZT0xmFjYnC4VDDVH+LzbtHDEh8winSlhdDUVsFOEtHvfQKUUr5vKlnV kky/flcyBX0+w== Date: Wed, 13 Sep 2023 18:33:10 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write Message-ID: <20230913-aufgreifen-fehlleiten-204b36f3069d@brauner> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> <20230913110010.GA31292@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230913110010.GA31292@lst.de> X-Rspamd-Queue-Id: 051E4180017 X-Rspam-User: X-Stat-Signature: s3n4ebmdi1sxd5wuh5ses85dnfazof6d X-Rspamd-Server: rspam03 X-HE-Tag: 1694622800-881948 X-HE-Meta: U2FsdGVkX193l3tDDBmLo58iW+jF2wVibF2idKf3bz33IQAPx072Cxsgue7UbHQehvhVGhpOkYvoRZVQlvN50Lye1A85gkVe0umGdqBtiJ2HbgLodKDMfouhUy2EchAev5tRCp03RrQ3P+xiyOAaPpsR6LhDyEtYXq+NKEmmXvIo16XIEno4yFsO1EIHcF5vK0pKUZZw0el2MN4x1LayQvsq8JqDCY2JLk+BMxgXF4uGpja5n7V7dARX+PSLeOVeQU8y4pswg2zppYuY6l4oHtEah0g1e69oYOhdOu/pIsVez4aZIzht1A4eMuJ6neqIXLXiiyCWXLCEw4e/rgLtVuGaaAyX5hEVeiMwfzqJnYTV5CnsonLKgGLTceyMzIFK3xsBTevlU785kjRzKdkjcx2ZPITET263ggwcmGEyg64RYU01ZOKbsfCigDP/WF9N6OS1tQjse28bJ7vtF+Mlr4BtsLakgSh505X+zySdUjCiCKh52b7CLUPUBJQ/9LvvJ8FMco6WcKE2ziroHvlkjT5+02endrA35FEl9OtJ7XWkHtKN9GGpdaVzjhxpylHn14xBIh8J1MLp+Sbvs6SflMooJam8GZsO5niLgfPIYqnM8sLpbWlYbsWdM0qmjWcal45r+yBaPoVUrZxB2xZkFhCDolRYoq0NYRdXJGOE4Xb2GVKluMoMUED6Jsg5cJd9N/3Ec0Q6Z57lH3DtlkUVHPGP8E3e04wkUL56kRzRNHYxNLB5bPOucZo+HdizKUfEPqYeYsWYFUJR0VjlyPdL4wQqBiF/KqLPNc4BYTAiJhVxSYx0eKK0eUWKcpHrel9Aj7KR77OlbNCDxVTYQiy4rnTJVP1TiTxx9BxYRtii5DPed6NIyeaV39LO01jseJZ95AUjAWeRt+3WfD+9b573MHRzta2B3th2jSlv9DE7uYPX1uHkIAUFBeYF8QoGz+C3NaLXkS85dB/TlPUd5Cd 0CyVNW59 YRlzGnWCsrZbqLkdpzfbFEmdxyHoeLE45KIE0MGWxpXP6Mr6z4qOYIrhjIaMiXAnPk7EZ5b5ZAnWUUxkisSGYvgX99QMawxSyyDLkAmTWRYssH2jaho8VKqZZf+DO71+SUwQ2+eLKspPTSfb153aLVOwPURIxwrt7KIzfDTP30JqkHp4Ei/PWCCOmVbzXfFps169NceP1PGXLe1mniiNnD1Y1rKoBPmNJ+QY9tJxNygcYczkr62VJeEAIReDHBjNzrylzt/Imn+SMj1nURVpDgXAi9mchby1ZiZ/yjSP97wHpQIQevLGe/olaqZ1t//xR37o/KkhSywP7cz0q5Ewq1h6qdslR663EP+G30WvgIWosFe8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 01:00:10PM +0200, Christoph Hellwig wrote: > > direct_write_fallback(): on error revert the ->ki_pos update from buffered write > > Al, Christian: can you send this fix on top Linus? Wasn't aware of this, sorry. I've picked it up and placed it with another set of small fixes I already have. I'm happy to have Al take it ofc.