From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00521CA0EDB for ; Tue, 12 Sep 2023 13:52:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A2E76B00F6; Tue, 12 Sep 2023 09:52:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6524C6B00F7; Tue, 12 Sep 2023 09:52:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A2F6B00F8; Tue, 12 Sep 2023 09:52:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 42C3D6B00F6 for ; Tue, 12 Sep 2023 09:52:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1E81B80140 for ; Tue, 12 Sep 2023 13:52:22 +0000 (UTC) X-FDA: 81228084924.12.D1E7A9F Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf28.hostedemail.com (Postfix) with ESMTP id 4E550C001E for ; Tue, 12 Sep 2023 13:52:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Y8ILCw8+; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694526740; a=rsa-sha256; cv=none; b=MM5AkuwqeYyQbi2mk5m0ygen3ljXVdQqB0hR1WkDypo1wdsjXE01D8fUmtrQdc6orjUB8N NOINLcohGU89URdWnPfxFZkHWLwxFDzUx1/iqZ3k/ndIa1qKS+sC4MMFRxQv4zYIdvQMQZ YBmAwkOlkGU7NL2/bmgDXYpVae2z5j0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Y8ILCw8+; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694526740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/lGmwZAGVMbAJBhdY4pCtnB8dKwZ8xioPPey8tPDV/E=; b=sCqZvQWeV+TWs8vR5fnF3dMewkvTeodn4dgW7EjvxvovFBZBmoBrehtg1+mP3UZJ+koP8V T5FLXgkhlyxnZu1wusTK0/Hm4EO/SPLHcZnNO9Z2291QK3polO+9MNDQqrIHQLXVXJI27o bOz7mDL+wYQAZHTMMsq+7dY+w14CyGQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/lGmwZAGVMbAJBhdY4pCtnB8dKwZ8xioPPey8tPDV/E=; b=Y8ILCw8+nxVE2RTsviiozG8ZeP X3EOwOyJ+cezyoO9pn8QnmZ/QDgXpW1S1vMcNYXRuBNHyiTg4XiNcK06lSg4OGl8FFvHCYtZcNA3Z G4t2VXuMxl0OwhuCyli6PHmmOzOKjF2BtsTrq87SxetEaH8rccl8UcM3x+TAgOSHR8QJBOWoNg5T1 rld3iacnCZyiCpu7j1D6biV4LbWCRUpuTMjZPKubwzGTLPChg19ZFy6gSqm2AJfMr5ynfaBf+S7/G Q/EKMIb8PJByExiSM203u9+glibHuLM9d6JvpTH9uLlyehrHmlPCwkcnsqgwuR0MAJMJ7zpLR93WC sekkITFg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qg3oK-0069ce-0O; Tue, 12 Sep 2023 13:52:13 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 2EE7C300348; Tue, 12 Sep 2023 15:52:13 +0200 (CEST) Date: Tue, 12 Sep 2023 15:52:13 +0200 From: Peter Zijlstra To: Matthew Wilcox Cc: Dave Chinner , Waiman Long , Ingo Molnar , Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/5] locking: Add rwsem_is_write_locked() Message-ID: <20230912135213.GA22127@noisy.programming.kicks-ass.net> References: <20230907193838.GB14243@noisy.programming.kicks-ass.net> <20230908104434.GB24372@noisy.programming.kicks-ass.net> <70d89bf4-708b-f131-f90e-5250b6804d48@redhat.com> <20230912090342.GC35261@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4E550C001E X-Stat-Signature: ms8xtiy4rdrhd9pph9rhjd8ezr49s5ih X-Rspam-User: X-HE-Tag: 1694526739-258138 X-HE-Meta: U2FsdGVkX19gfg/JaTpKlyTwpj0lKtnH/5cDL11qqNRWWSJTut+J33CWB38RCiptvI//qsMxJHz12nGRme8JcLUhjJsYPi/86xDJAI6skx22MVC8tHiYFq9aog1Gk9NMulIo75H+f14U3sdH+YQm32//yDVs5jfv9GRuptlLxGiQ/kSjLqEQFWX8i7Sl1v8TdsGkdwZykn+x8o4cW+qG44FUPFKlPk9kA+lVLS2r5nn1LD81M22DRjVAUOCSaHJRvslTtA9ZoMfTAYTMEcQr6d/+31Jk+Z5/mdu4H3VZcVq3vZvQ8TD6KPiHRN4iJnrohDbAxy19oWf3UrFd7TuIH+YHm50nfc6i6qvOlziggqnxw55pOOgScqKejKMc35y8TOyHdObdmHftxEaFkgXlxrE+Lm9dPC81BbgFLqaX3foScPVvyFx/nU1Wf03m52y2SjW3uZ1S54HPhL+yhDONqX29Bay3LtvEsVL+hN1zK7U0lnXfm9mn4hm0eyLdlhM4lLZHdnzbmhnr2HikP2x2Sjaj5oK2s6Hlmhsn90L+KkMKUebe3amu/elkFF3p7GAzeXd/NEIicTlewm9kOi+pwF7M0lIS7y2QRCfNU9SZ4Y1/I9NtOPEBW164gNlICJGl3yqThw4xHABqTbSqIipH9M8qeIX2LDkM1T0NIwG9ipG2EYSq85XH0GQVc8l8Yifpyy7AUJrWPdVD3RuFo0xJmhrEtZCs9+28LpIWyi/GnuIeEzVVgJ4tko0rW/MAdVl/umMq80aT49gMrvJCBUj2Zz6GooXdKKZaJcuDOFO7Y6AlqUjirF9Tb2rOGzcssRVTX3+Or7uTYUwI3p5t64q35mZXb50yuk4sprnzusAJ68Gyu1DQM6lOGmQAHajl6XhcMSG2wsnJ40WPZPeZHlPsf4DaSZrlGZMMxlCRVD8PwVxTXA0MwUfRh/gsMNqH0Lwcz7QdmbZ32OgZsPpqnHC 8i7CuFIx TZfzj8MN72SamDL9F8vHTKajJ6NgPlSWU1awlri+MiDYqJuR3OJ7DL9ZDpKrk7SkDVufv9iY//1sO1F3blOFEhXBzC9dZ1k0bzPdKmHEy7UDkZvdduF00FPqLP+ku7wHymWv54I9IdDw4iU7dSimoW9BA+KOJQ3jTllN3cntuXzUGuDdHyu/BCaM//T5lIp5pqRnj6YseheVki6EH/bTG8qFH7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 12, 2023 at 01:28:13PM +0100, Matthew Wilcox wrote: > On Tue, Sep 12, 2023 at 11:03:42AM +0200, Peter Zijlstra wrote: > > If not, then sure we can do this; it's not like I managed to get rid of > > muteX_is_locked() -- and I actually tried at some point :/ > > > > And just now I grepped for it, and look what I find: > > > > drivers/hid/hid-nintendo.c: if (unlikely(mutex_is_locked(&ctlr->output_mutex))) { > > drivers/nvdimm/btt.c: if (mutex_is_locked(&arena->err_lock) > > > > And there's more :-( > > Are these actually abuse? I looked at these two, and they both seem to > be asking "Does somebody else currently have this mutex?" rather than > "Do I have this mutex?". It's effectively a random number generator in that capacity. Someone might have it or might have had it when you looked and no longer have it, or might have it now but not when you asked.