From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CBEFCA0ECA for ; Tue, 12 Sep 2023 10:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86B556B00D5; Tue, 12 Sep 2023 06:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B6A6B00D6; Tue, 12 Sep 2023 06:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70AEB6B00D8; Tue, 12 Sep 2023 06:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 644C36B00D5 for ; Tue, 12 Sep 2023 06:43:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 36DE21601EC for ; Tue, 12 Sep 2023 10:43:11 +0000 (UTC) X-FDA: 81227608182.17.2E78F43 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf11.hostedemail.com (Postfix) with ESMTP id 8892B40018 for ; Tue, 12 Sep 2023 10:43:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Q6HR9dzf; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694515389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IAQHVZXW2MalUHCANwdojX2cYCNpNFefug3dgvRipAE=; b=0D5Dm8o81HDrniT7MhzCCAQUzJB98vGzus0p+WpVBgCi0I/PHoquCG3Cjx4fy6m3SO748w 3e4gh5VzlxTmcVo64qLUoAn5WS5015fPAHah7mBPXkmH3NcQlwe6Fx4Ggm2IAgkBLiWxFn ywCChLd+MS/LFPy0M9iRNUAOPKqLuHo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Q6HR9dzf; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694515389; a=rsa-sha256; cv=none; b=EPea5njV2U5inZhbZrodaZjTPXNkcHtgO+0Yetu213d0g80GX3eX5QmV2bHLVE/wCuHNAl TKWrhRBlkc0a8CnBp1y5U61p8xQ+qg3+QR+8hjVc1aB93+NLVhlbeuLYgAgNOm8Mx6EmRw igiddSXnF7wyneZaInQZiOKF4yRy3cc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IAQHVZXW2MalUHCANwdojX2cYCNpNFefug3dgvRipAE=; b=Q6HR9dzf2TMHSrq8jQklKZakU+ MjSFfT6C1Zk/ATgGOA0v7nJZ4Dl9ODWXrPMFDqOLWCedzcQt9VN4T+TRLazJS3Xap18jH2V63zSKj XTu3oPmQ74A20TkpjSjM5RRmDdsJCXAEiuQcpE9cSXWpifEfNZV3w+GxQaqgbtFGsNI7hPOWFnlOR wzbxMrkqhZ5rN3C9I0uwmVM7FzAwLRTDkSMD+MdFdQiaGXMs4DS6NBCc0y7yqxfpnf83nAv9a//ge yt24qrsDorks+T0+D44MQTPTN5q42EPKlx0Ue5jqejnuDnCFBadFjY3jQFC7HV7lODqr/XpK9o59J 8cO3MDiw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qg0rB-00634n-3B; Tue, 12 Sep 2023 10:42:59 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 1932F300348; Tue, 12 Sep 2023 12:42:59 +0200 (CEST) Date: Tue, 12 Sep 2023 12:42:58 +0200 From: Peter Zijlstra To: Bartosz Golaszewski Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup Message-ID: <20230912104258.GA12405@noisy.programming.kicks-ass.net> References: <20230912082643.13144-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912082643.13144-1-brgl@bgdev.pl> X-Rspamd-Queue-Id: 8892B40018 X-Rspam-User: X-Stat-Signature: 7a4unncmic4ozinrokj75a48x8e1iwcq X-Rspamd-Server: rspam01 X-HE-Tag: 1694515387-815809 X-HE-Meta: U2FsdGVkX187cQZacenrjNcNYCP5EWSZSFK1iWb1SPUWFzI43wtj7+XGNqrYfOjwzwWyGNCtrF5GDzEuqhSbw0290lGFCnen+qnYHZaRHzhiLoYIWrPfE31A4384Zy81zgkOFh4reuTyBqJIrfndxwgLoERbq2wkStAGhrtK7T6trRzKb97y9eepk853OxtQoVudWJugbVkp3UX+eHijDsbDTFGDhQDh5gkSrXZcpK+njWHESl7/Ahfmt65k91bzJs6Teo1PaTklj2w5nzeyyAlDVB1TZ7a9LXlnUCtVX33cwphkRJQxNuHJPx1/2rRd0ALINGERhIUhEZJFfNDjGC+Jour8umsjRjdZJIY+Pt6yGrqVpOmCt0bZCJRhKPr5BuruaKDE4DABXrrao1UbyEf/pO0Fi/Z1vP+/dHmRUvcjRg/T/CbMn/fGpxsjEJGgu3VJ4tVXtDkM8LYxua0jVqtjG5sUQtGGnxOCNP+M+fLnrsXiWw/x5n3Bw2MBE4BqLX0PuPhAP/x6d2l/9St7CjVFBSfRGUkpG4e8H0FfHOB8QcLYm52QUxghQC1+pSudTMXWzjRBt3DWJlDlb9MBRYtbgYlotqjlqcl0iWw77Nk9omurCU1g3RECBYsZkX8J9coafSe2JFiXZyihYstsc9s3o+hChRHH0hcQJ19bsm/3bD9E7rU5XipIIb/6pjNUJ0Go/gO6B6gsebgsGzB36ygi4bEi1VcL8JYsBQc+D02FJdSG1wFgoI1Iiy3clXMTG1iB0Kl7BpWNB+gn9HWUcei76guNmYoakBI2cKYzg0DkoI3tEQo4iRHGzLJPV2fIJmkImSPL/yfJo6yKWrjq4RQ9G8eAe5TyRiFBg0N5HDrbsfAtK3guAwJHu31CZtVcl1uuA7fuM0hCfI7YkMtG+44grTT7I+SW5ghAPzQnBdt19Nr+BDddv9+6aYjXQ47u7zbIBpBmX+j52C9P7fo IJrL6Pji ThF40K7fG65I1P9wiQn1Bj/lH4uNeVwakKZVQg03hav/C4F8b0WN6huRuY9Oqqsm4M86pL/cbe4uIeGpA9IJO0nI15TtOOf4yh6QTWqTEXp0w+k+nH1Ck2sQnQ2auA+SBxkoYk+EcO9j/LPNIgACnB1mxtBDdqVi7Jhgb9WSGuE6eJ0FjMS/HSONmTZ/dlZZGIAhq6tTu80FwDmR747DVxvjwDykLn74V5u0nYas9xr/5MzzzNJI46V5zf51XBHu7ufBxJ842X215Zn4E5UUm5YjX6OEjZgGuNd9NL8xaNr/7R2Cj+y4wMXHaNSWb73d89PuS25nDOWiIckA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 12, 2023 at 10:26:43AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > kfree() already accepts and silently ignores NULL-pointers, there's no > need to check it when running the auto cleanup routine. There is, because now the compiler can't help you anymore. Also see: https://lkml.kernel.org/r/169451499208.27769.5856056754166699857.tip-bot2@tip-bot2