From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F72CA0EF4 for ; Tue, 12 Sep 2023 16:23:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B7FA6B0125; Tue, 12 Sep 2023 12:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 768B06B0126; Tue, 12 Sep 2023 12:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 630116B0127; Tue, 12 Sep 2023 12:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F9BE6B0125 for ; Tue, 12 Sep 2023 12:23:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D3E7C0221 for ; Tue, 12 Sep 2023 16:23:57 +0000 (UTC) X-FDA: 81228466914.22.BEF798E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id 019394000C for ; Tue, 12 Sep 2023 16:23:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mWaTNNuV; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694535835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f7qTdsHjh7Aj5Hg/dnFyUCotlSV9Zzbk47wUe7yiHlQ=; b=Ck0Zzi6VsvPhbYIvXTXBNNnQ9IxE8nBNVjjV2c3jjIjkaG8S5kDRecs8XKeSaiqvPW4wIQ CIfOVgFtYjvBsdr1dzJ597K+cuH61lWf05CT3MmPRCxJAyVGhQco4LmfA0QKez+GW82q8O yoDBvV+1c5qB5v5jqeLIfSQAH68n+HU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mWaTNNuV; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694535835; a=rsa-sha256; cv=none; b=dpPJATf2aRsLifDf7OIwFAMZ0Dmlgt2i7zdqMT2NFNQL9mxB8ZxxxOKkuymZ/dDwOoD7U1 j/BGGznsNi16fm0zKDc0Ha4pErqo30rMblhuhxK/4ZUD9amTnfdmarneVog2qjUvUrVEZ6 2M9Oydv65v4/jieyxvfPQ//ecFb0R5c= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0EE88B81EBE; Tue, 12 Sep 2023 16:23:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DC37C433C7; Tue, 12 Sep 2023 16:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1694535830; bh=cM9usqpqAjvNAVl4RACKoLLLMEuBld91IwmymEvqjW4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mWaTNNuVKpdDr3c1+zVME8cRWR0WIwZwcKSZtVf4Ow7eG3TiyoJpfXllu0c2auzbX IBadXeYFOy8PBUEHRLQ/9aBbg1F5ArAFwd2nmcDVuajIoRetRj37U2Ar5MUIfbdI66 uEWrjLDz6hOsDQPaL28fnLBGF7+BRE67SUvy2Lxs= Date: Tue, 12 Sep 2023 09:23:49 -0700 From: Andrew Morton To: Johannes Berg Cc: Kuan-Ying Lee , Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , chinwen.chang@mediatek.com, qun-wei.lin@mediatek.com, linux-mm@kvack.org, linux-modules@vger.kernel.org, casper.li@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 1/8] scripts/gdb/symbols: add specific ko module load command Message-Id: <20230912092349.2ec5bf4e20bed10d27410076@linux-foundation.org> In-Reply-To: References: <20230808083020.22254-1-Kuan-Ying.Lee@mediatek.com> <20230808083020.22254-2-Kuan-Ying.Lee@mediatek.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 019394000C X-Rspam-User: X-Stat-Signature: r89y43q53ytksjqd7ahiprc7dpat43zq X-Rspamd-Server: rspam01 X-HE-Tag: 1694535833-570388 X-HE-Meta: U2FsdGVkX18joSbgrIFSRE7wr6iaK0MnKxKFmXb8ZXv/AYUexyzQgRFPOv9mNYFqHrddvft2jH1YRpUbeJOOYzGjS5M7T0394gDR248VHc9Jvc0E2OulQMnuxOt9eRQcJnkWeKo3wyZV+tMQpfKj+9/C3CiN7WwrhTj9POtMV8Lc79JhbEOOT3389YS4MXzgZ09q5lzQgVlbF7WeaV/6ELwB/I+ebuPrSqxvH/KWB2O6JEvjY2FjicMds8mS4/Al+ZViyMs4rXRFyvuc3j/jVSRTQ/89u+rbH9q7CU7VZXeKgTSy8MmsRPTaHJixezEl9Syeyto7DTXaMOrle8GfKgqBeM2Gvj/1B99Zi86b16MyDVK6q9hPu5RtqG6JYMdW28r9ZWUcj554h6sHzm3tFwIxVUyjZxCcMuOeNmN44fIhHb0Ti6ORiIrIBc4HD6eBOnfTQ8GHFm8Plyld/E0sObheDoCCh+WRDpxBbApI1VXIN9W87EKyxwiVs8rKC9qx1GZNxpqJiC8kJfxPocPfMf2TKr7HaFYmygqZZS8sRAEWO6I6LDKdPIR5tpnQe0ltsfVwsNWk7A4/v8vBkcqfZMtG4ySJ9sOE7E05v1Zs5AogeRI8YNaDBWqcy+WOjI5wpfpi6jM00LINgsMedOB4qLhRlHOermMKdDKsZIwhbQtHkIr3aAZ0/4ccQmZCan+jUqCUINWgFugX40aZGUbc0dq3EX86j9VLbmk4K+Xt3/4wjV1c+NtPdC9pc8UOHmmTqaR81awpbXITgIIuYyjBotMR639xQHRZzHM9YnDC586lSatTfnOBXW8OYgEm/xupmHIgXzfM38VJDq9GM4AlxPh2L5N0rOzA6Sh/NJMrEMwZW+TX356N7F6/CMwbjIdKhml59c+UeTfLHIVuPjNR4QXXDfc39edYHh094RcP6BBtAe0Nc+zdpGJtH2N56XILbWMl9MHJm0/TNjt2Zdt +DBwsqYZ W+jiPAfr7Lxg8B+zsh02iLNWAS/+6rAS79gJ6JfDX9ql0zZJKFD7q8XpOXmq6X5bbdHbvJseeB/uFkRkS9F10qMO3KYTeg//ed40B3fzWOltItA+niE6dCtRf/7B7tmdZ1lks6nP1LgarPK+x6sbMYrREB0ySOhVBCDptx0lKzMKKgcQ1TK5Rv2x+4kE3kdBs7N6pHpfP53GdZx+d8aw5AwJ4rIuNMgouNcjqOuvEFUXcvNHVxsMGGsbQVxL1vQb8Il7mpKks5UBud7sIpo+gWvPCqeQR5ppd8gRD2M090I+mg+mr08av+y5D4ASRrhR8AI3fkScVe62eb9zghRfBeUB2uJEx3k879fOI0Zf097OcLJe7IegAuSCzShoxw/ItyKLXCtykOUnc4Z5AvJsQlYngxroEB4RAuw52t0yAZ7OF+ODhfeEATGSGIHBn9n+z7szbPJdu04c5QWTuRg7bIzvbU6tBn0UUIP0VInkhenpR0oippfrah2zxHeH44dT5rc2PojB5802wJAO7Y7+0ehsTSXyEZNDzkK42Chu2F4aqPmwSRDO+mDMaSdc7wWauiewY5fC0wWJAjQXOJ6VJwqx5urqME9IN1uDmr7RpxwvEN6vcHsgELajZt154Qwc7Z5rinn28o1RrA2Mwr6yRfnOBbwd6zHKXfixzhuKk5Nfjb6tROTwlX0vdScBMvuzTKCjsYSXUQYsZHaGT9KHADkVql3cqd3+2e4YOyWrtxgGMtJftGNIZ74tQ6e5MfVEXGurMyw6Q1g//I06CI0yQk3DZNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 12 Sep 2023 11:41:29 +0200 Johannes Berg wrote: > On Tue, 2023-08-08 at 16:30 +0800, Kuan-Ying Lee wrote: > > Add lx-symbols command to support add specific > > ko module. > > I'm not sure how this was supposed to work? It should have updated the > documentation, but more importantly, it shouldn't have broken the > documented usage of this command: > > The kernel (vmlinux) is taken from the current working directly. Modules (.ko) > are scanned recursively, starting in the same directory. Optionally, the module > search path can be extended by a space separated list of paths passed to the > lx-symbols command. > > Note how that talks about a "space separated list of paths" for which > clearly a single path seems like it should be accepted? > > > @@ -138,6 +139,19 @@ lx-symbols command.""" Thanks, I queued a revert. From: Andrew Morton Subject: revert "scripts/gdb/symbols: add specific ko module load command" Date: Tue Sep 12 09:19:10 AM PDT 2023 Revert 11f956538c07 ("scripts/gdb/symbols: add specific ko module load command") due to breakage identified by Johannes Berg in [1]. Fixes: 11f956538c07 ("scripts/gdb/symbols: add specific ko module load command") Reported-by: Johannes Berg Closes: https://lkml.kernel.org/r/c44b748307a074d0c250002cdcfe209b8cce93c9.camel@sipsolutions.net [1] Cc: AngeloGioacchino Del Regno Cc: Chinwen Chang Cc: Jan Kiszka Cc: Kieran Bingham Cc: Kuan-Ying Lee Cc: Matthias Brugger Cc: Qun-Wei Lin Signed-off-by: Andrew Morton --- scripts/gdb/linux/symbols.py | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) --- a/scripts/gdb/linux/symbols.py~revert-scripts-gdb-symbols-add-specific-ko-module-load-command +++ a/scripts/gdb/linux/symbols.py @@ -111,12 +111,11 @@ lx-symbols command.""" return "{textaddr} {sections}".format( textaddr=textaddr, sections="".join(args)) - def load_module_symbols(self, module, module_file=None): + def load_module_symbols(self, module): module_name = module['name'].string() module_addr = str(module['mem'][constants.LX_MOD_TEXT]['base']).split()[0] - if not module_file: - module_file = self._get_module_file(module_name) + module_file = self._get_module_file(module_name) if not module_file and not self.module_files_updated: self._update_module_files() module_file = self._get_module_file(module_name) @@ -139,19 +138,6 @@ lx-symbols command.""" else: gdb.write("no module object found for '{0}'\n".format(module_name)) - def load_ko_symbols(self, mod_path): - self.loaded_modules = [] - module_list = modules.module_list() - - for module in module_list: - module_name = module['name'].string() - module_pattern = ".*/{0}\.ko(?:.debug)?$".format( - module_name.replace("_", r"[_\-]")) - if re.match(module_pattern, mod_path) and os.path.exists(mod_path): - self.load_module_symbols(module, mod_path) - return - raise gdb.GdbError("%s is not a valid .ko\n" % mod_path) - def load_all_symbols(self): gdb.write("loading vmlinux\n") @@ -190,11 +176,6 @@ lx-symbols command.""" self.module_files = [] self.module_files_updated = False - argv = gdb.string_to_argv(arg) - if len(argv) == 1: - self.load_ko_symbols(argv[0]) - return - self.load_all_symbols() if hasattr(gdb, 'Breakpoint'): _