From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31735CA0EC3 for ; Tue, 12 Sep 2023 09:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A98A6B00CD; Tue, 12 Sep 2023 05:03:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 759496B00D0; Tue, 12 Sep 2023 05:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647ED6B00D1; Tue, 12 Sep 2023 05:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E8E66B00CD for ; Tue, 12 Sep 2023 05:03:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2644B1C9D06 for ; Tue, 12 Sep 2023 09:03:51 +0000 (UTC) X-FDA: 81227357862.06.B095688 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id D5C5F12000E for ; Tue, 12 Sep 2023 09:03:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S5Uyc7to; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694509429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUN9qvOhvSclaajkaF7Yf2ZvZqXHPIr54l2XhmMy2iQ=; b=0deZZUBRN2VRZyA98K8Tmdh7bfR22Tz2cSXvqEB0cxwdzIFUArORJ4XYGuPl0RxEIGXt5f EqOdjKJsK0SVcziHB5rtJ8pHF1pdbajEEDJuMRkJE6nfT5uOzun3NLfHs1NLzqchrNc3qO Z52Do7207ifq90sOtJ5jfEsggX/OHHc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694509429; a=rsa-sha256; cv=none; b=T0aTQBx9YfyOH2MvJyi+Lz2THNm3D38xpohgzPh60xfQS7zg71QWAc1522KFT88sZSHoAo yNn5PIHLN+tvWVjoJUHToL2KwvOjMlIipsiX6RiLShFgcJTWx3i5qavUEa45tDive9z0Qt IS/buuj4XApUAC2WElX/YeUGng0n6bs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S5Uyc7to; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OUN9qvOhvSclaajkaF7Yf2ZvZqXHPIr54l2XhmMy2iQ=; b=S5Uyc7toBN82oKnjq/FlDxHddn Rjo96XKH3esWhun3HPvT/LPYurgyYDtqSovgloklKRrD4xV/A6OSsQOpEmRQv+/Dc7Uxd6R2MsVph Tin0q0YT0h/IqrkCanL2ebgbXdndUBQ2vkkE0WDOIpl1K5K3z2CJpQGa9BXO12uItdSIpW9mHaNI6 a4MgvZCXPavoAIZvD4CaI3mYb9TLW8IWuySpqgUskFMexlLLkjPBFbzqAUiAHFuvvbvm3Wo3kJR/K IDMyk/bIDSx8uJ6h+xTDqZacgvRG36C+IKFdR7hT3TTKQAb9n3e0xL7XeO55Dsv0pyvstVmyUxDYu e7MV/V/A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qfzJ9-006grO-DR; Tue, 12 Sep 2023 09:03:43 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 8110D300348; Tue, 12 Sep 2023 11:03:42 +0200 (CEST) Date: Tue, 12 Sep 2023 11:03:42 +0200 From: Peter Zijlstra To: Dave Chinner Cc: Waiman Long , Matthew Wilcox , Ingo Molnar , Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/5] locking: Add rwsem_is_write_locked() Message-ID: <20230912090342.GC35261@noisy.programming.kicks-ass.net> References: <20230907190810.GA14243@noisy.programming.kicks-ass.net> <20230907193838.GB14243@noisy.programming.kicks-ass.net> <20230908104434.GB24372@noisy.programming.kicks-ass.net> <70d89bf4-708b-f131-f90e-5250b6804d48@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D5C5F12000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: npjyjeb5t1gexcgot9uqyuf9ygfy7ekq X-HE-Tag: 1694509428-488530 X-HE-Meta: U2FsdGVkX1+48JnC77959NkWrcU0QifbbvgDAbtt6+SeU5GjXJ35gFuVoX2KFEydV9Tpkv/plknE9mi8BJNGI9+exUwbcGhU8VoeqG1uZxwqnQ5j/ceK0Bg9Dnx2hqHd47CkiBeDxhsRtf0bdqNIkANMAJFI+UUAtnyUG1X7CTzxjqUce0xe93VVrI1nJ0P+QTF1zxkGDvapxJRifLEFEjIuBtr7EOC/q0SoQpjNUkkSxox2pqWun0hmF7hSk7i5rpI+SLLae+8nC8PH9f2ROZKDMmZ1ZpS7DO7OKx9Buhgxf6ZerrHIIRvtj+d5NqaQvDBz3GQ8ZsreczfYVfZYtPgDJGk2uXG6x5R8RkjVd5YjZrsIBKfv9N01f2c/1BQOc5WyNyBKjCdWpw/h70+R5wrdBoJSMqc7PAozfxxCUQdn8ewIv0VgYJLEjqK/DhzGsFaeY9iC5euAIdy/5tXw4GeiGg8ZijkJVDX8Iob2u3XJlO6M8fE4ruOBEKDg72/j5FiYl0b9FcN3MuyDWbVhtxWoCd0G62zw6LT5geCoFvLIAb7kgMD7rJfhMLTJy05E1UXtW5KPa6bLsJZZ45bJRhUTwtj0XW5jHnEqSOZCW6EQY2NW1CMDzGbZx1bpMpwKyvg8wptW97Ndd8hLMqVisrIaBHWP5e5GoQyoN22USs1Niul2vovB8hwOMUPoHw4B+7whDpt4Vao87i1PlAhQFh6JxjqK+HhUXV9Lrwx8fk1mwb62pksUWIYR3EFIqSi9UYU7hzMdOBs4PZWRmJDL+RrMJpw76rHrSUhFYmPm/ydMnxn+RmVV8ROQjIctKe+7WDCcq4iyevNST5GBgzMLq5M8dwtbpk+hNtZ89LXGOYZKot76fmR6+JM/0iynx7ZwCknA/6v3+csFac2pW8w/wFHG+sFlbRNEz6QHd1B17+uCluDB0JtRPWrmrrtFPW/xu1uE4zZC6K8xGOaEa8v rvTXmLvJ G8Ku/vKw90IJDrT+WbLPGUawhrBALPaHiwOKRNfJVq+dthQjbfpVf9XmWfeUHg/6h/Y7R/OlW+72S9dLnY5D56HRzz72HrDe2IBkxMd7UfAYdtoukG8CvQRE1M8Ey0ucVCCbz3naBYMbG/plm6VHQdK0iIVkQap/v2Fq0enZJn23TEg2Z6FpTUSxwrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 12, 2023 at 08:29:55AM +1000, Dave Chinner wrote: > So, once again, we have mixed messages from the lock maintainers. > One says "no, it might get abused", another says "I'm fine with > that", and now we have a maintainer disagreement stalemate. I didn't say no, I was trying to see if there's alternatives because the is_locked pattern has a history of abuse. If not, then sure we can do this; it's not like I managed to get rid of muteX_is_locked() -- and I actually tried at some point :/ And just now I grepped for it, and look what I find: drivers/hid/hid-nintendo.c: if (unlikely(mutex_is_locked(&ctlr->output_mutex))) { drivers/nvdimm/btt.c: if (mutex_is_locked(&arena->err_lock) And there's more :-( Also, please just calm down already..