From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02119EE3F01 for ; Mon, 11 Sep 2023 20:51:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 534506B0301; Mon, 11 Sep 2023 16:51:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E4B76B0302; Mon, 11 Sep 2023 16:51:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ACAB6B0303; Mon, 11 Sep 2023 16:51:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 278656B0301 for ; Mon, 11 Sep 2023 16:51:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5024B3D26 for ; Mon, 11 Sep 2023 20:51:33 +0000 (UTC) X-FDA: 81225512466.13.3A7BAC4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 3680B40021 for ; Mon, 11 Sep 2023 20:51:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=M4tJ=E3=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=M4tJ=E3=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694465491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8t7h5YioeWOMprl58uZuG5KHbsTDjFW8RNuztVvP0SA=; b=B0pAgn/l45aktut4LU79Q0MpfQUq1vXOBqUYrOy+FpLx5yyAwhSr+pCMDEPbzXOAEQ6Ctj aeVHP5wMM6En/+Re8dq7q4LhR7S96n9Kj7fmbP46sJzmM4OaUUCQ9TmMfTGvTHv9hKb3Ef MfkK05RJdu0VthwT6PjY/yIHTKQpcvg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=M4tJ=E3=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=M4tJ=E3=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694465491; a=rsa-sha256; cv=none; b=wLd/UuyEE3BecmwOPzd07bnvBlOLEWajCSgwl8MrbJ+kC+l+TebQR5SelkjcskLLa/gHAe fwAeG5LbyvvSRN6TfP7lgytfcvE5rnbRbLmwHbuOiw14BXpJmh8YG85s2ufJgMVqhJbDFH hvzl2+OLFaOY4fBFAB+exYBXAmXTT7g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 234EA61200; Mon, 11 Sep 2023 20:51:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D463EC433C9; Mon, 11 Sep 2023 20:51:28 +0000 (UTC) Date: Mon, 11 Sep 2023 16:51:44 -0400 From: Steven Rostedt To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions Message-ID: <20230911165144.5002a0ac@gandalf.local.home> In-Reply-To: <20230911203642.1788-1-sj@kernel.org> References: <20230911163127.167dccc2@gandalf.local.home> <20230911203642.1788-1-sj@kernel.org> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3680B40021 X-Stat-Signature: jrz173h5nznaapr9gi4o8awfahh1oo3c X-HE-Tag: 1694465490-1447 X-HE-Meta: U2FsdGVkX19EM9u8d1XA16DHgexZWcBj/veJgP5DTCzaaIolzxaHrGPZHy05eg9KbNBcdHLT8d2OJ+TsZTIBqmvImDcThsLE3CL5inehDjJ+TQUBOIgAVD8Qg0IwsiS8l2MgsIQgv7O/OVQv4zj0En6eys/nMvAYZwTKOUXyeeTkNazs53cPieUPxcAb1b7hSOlAyNB6N5ssevJPjD/CxklmID4ZzvXCL58POdlRTdMEF0wAAYZrwS1UQtmEZD/lzQ5POERElOYUl9DNsJbpXEtQDVWv1d3qnhoTzaXsHQ3TKJ8iCCJPljsSJ0zG33DH/fpsu5rgSKnkTWEYJMUA9rqEBAk08EhdbP2pJKS6cx2fW8ALg6Bnuwz1+bs+Ir13F+QqOJt1CL6T9EdH1AmoDoF1rziFTypFSCHNLwr/1uku2De4rESh4bzd7NKHhyjbnjFDLOycLVU1MrZGabhtRDU4vhaXz2ZntRcvkav/ri0fGhRIvaDZKWtyyCO11Qkio867U3/BXnOgMvz5tT4eitcDoN839ADnfSzk8O+xwAMbiA1WUplLJ2wc8AIxSqH11eZ37jkpk70N/6eIm+kgj5hkkkdCxN2MRYfXnJ3Bbk2OQqmI5jyPMszOetPP+2ONqWO1t396+S9XywTBn9kjW1aJ3QZU5JdY1/ETyTL4RmOoXV3sA492A/hEF2JuWlQKdQpZoFFBqUNZHWoWFCNc0pq5QcVMcWMxXmjvjbtz6WboJ8jnkq6dyaVPDVb4TYbLJA0VHPrdxbE9TgZYIHo+UybdFJRPx+F96uj9Y4/RBjSWSwYv7HTe6mgMaBAWdQFB6LeTQJSYzE+b8oChUU8xdC7nbgkjPAmA8473Z8IP8k96dCuuTkA6PV01qEhAWMxRwCqNEABDYaVpAIHjRB6fdykLv7HowAZ6Z/RlX4CKoCTYU2tgCe2i010yP9AVxiTdqSVF1nBS+WyFkjPyuXM 1yzkp0Af B5HCdo4iLKRYG9wYtnZQyn9RLJ7JfjIcqwq/uozc1yGcg345QRyb4o+N+Nh81OEYjJZqH7Dwcv+ZQ+/QFtzegs0UhjsvqUzZMP18XA1Tr6l5X5x5o1lk2u3DYS21Mri3dxvzmFZd8dIQkxXfhtK4jn/C+5bpf62tC/mqvVEm2UEYKwgBBrxGeCprb83BcVxxftiLob3eHEYWDLdu15O9PNDHMQ/+4QN1P0nPcYQwrwSWwA9yzwZI6eAe6w7oPhBDEDeBCtDB+kRfDnbJcjM9VviMRaqVuTHs47kgtUTF4a7R8bN/b9qUq6NfvhfmjGf+qWniioze9gIbSJE+1PE+1YDJzSGgq0iuyIyfDdu5F3W+L4ZPPlCuJgApKcawrGNRMJyioI+6JOJC0quP1P5DHKGfKfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 11 Sep 2023 20:36:42 +0000 SeongJae Park wrote: > > Then tracing is fully enabled here, and now we enter: > > > > if (trace_damos_before_apply_enabled()) { > > trace_damos_before_apply(cidx, sidx, tidx, r, > > damon_nr_regions(t)); > > } > > > > Now the trace event is hit with sidx and tidx zero when they should not be. > > This could confuse you when looking at the report. > > Thank you so much for enlightening me with this kind explanation, Steve! And > this all make sense. I will follow your suggestion in the next spin. > > > > > What I suggested was to initialize sidx to zero, > > Nit. Initialize to not zero but -1, right? Yeah, but I was also thinking of the reset of it too :-p sidx = -1; if (trace_damos_before_apply_enabled()) { sidx = 0; -- Steve > > > set it in the first trace_*_enabled() check, and ignore calling the > > tracepoint if it's not >= 0. > >