From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F22EE57DF for ; Mon, 11 Sep 2023 16:05:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806046B028E; Mon, 11 Sep 2023 12:05:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B6376B0290; Mon, 11 Sep 2023 12:05:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67E626B0292; Mon, 11 Sep 2023 12:05:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5513B6B028E for ; Mon, 11 Sep 2023 12:05:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2019FC09EE for ; Mon, 11 Sep 2023 16:05:13 +0000 (UTC) X-FDA: 81224790906.21.8A8CBD9 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 3A693A003D for ; Mon, 11 Sep 2023 16:05:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=pIOeEqfv; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf15.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694448310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3NcImq2ANXyTU9IjWwqj61QAzOMpFgaQdLTxRaWVzyQ=; b=oqyn01SKMnDInq1CF3glUYjyxndepq0kavQ8uqQ+yd9JWfRh8DyPhJGbrbkDNuhhDcFMP9 5K7XHmXuFIxY4gAMr+j1x1y1o63JW5mvblbLXQZCAPrpAEeej1UI+FIBg3qwqknQo7+Yrt LfMPxM1Y2npp4/6XKC4XDwieOebTY/4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=pIOeEqfv; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf15.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694448310; a=rsa-sha256; cv=none; b=n5jKHxDnMWnzHmtw8B/T7KGE5ROSJxVODWiQKemDJEt2foqef81tfC1pknQ0qqUNsd4qsM 0xbUVoEl1kuqBNPfsgHm0ZqDmcuuek9K69QK4v1Z9Lwrf8vn8jG+/ETzIkMq6I1TA+DG6A 2dpS90d/IcPM8HXKvzYlZFDE4wnTMZQ= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6b9a2416b1cso3308957a34.2 for ; Mon, 11 Sep 2023 09:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1694448309; x=1695053109; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3NcImq2ANXyTU9IjWwqj61QAzOMpFgaQdLTxRaWVzyQ=; b=pIOeEqfvimq21Q3zRZBKRuV23e8OZIT9xX8bKTD1UR36E7od3mogfMukMt6G7il6zk 8izcOcQuj9bmBFUXpv9qhWnZvTNK1BOHydvNEyc6pyW+C04PZ/IsNT/DlF7/LmG0BZ6K 8SuGxw8Xk9UNXhhwBpUAV2dWMNyxOoQZJlBr+gq90AHeVL875m9Bz8GuPAC3YtRrOQGX Ay+D5baBkaaiduggWHL3Gkntgv1wzTATSEXoMRVbJq9fO5Iz50zruzVD8sTURAkmcNQi FCFPGmnEnQ9H+JtfxivjOy1JY/lQxCaOS536ahhIiaDhnwraJtBv1q10YYy8kI1f3nVU vmjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694448309; x=1695053109; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3NcImq2ANXyTU9IjWwqj61QAzOMpFgaQdLTxRaWVzyQ=; b=oNmA9wT9B8AF6JcmMxoUOU/ja5YCL0VcbaXnfOsdLWbYHom+268DABKS9XziIEJWIz bj9nu55EfZdFlzNCvmPojOXGIqzUYbpH5ZZEb9gzWU0qJkrBB6GeqiwN6i1AJ39wpnrA jIA4m4VxIi9Mu+exiz3hWKoq7slpyWKF62YiEoGHDLi8KtXLQ0MvlIlrzdyuFQi0V6Bv KX1t6r63Nmscehns5UfEtF0rsLD2GpYGUO4PNqDmDCs47Zw23wUycfL8KJewNNnul01A 0pJo9DJt0q9mSE3KJZCmquaYqcYV6bsTGgld5Eo9e9ga5NNCHCsdHi3onKpRZgPbR0vY UTXA== X-Gm-Message-State: AOJu0Yxv/BBlDfx7/OxQyLfC3aCl5z1K3B6OpqScefMMSaMTpbAWwgzy 0Nxq2ZBvAhh4KHuR2hRWPifPxw== X-Google-Smtp-Source: AGHT+IFgu4s3lCy20ZYftOE3FaCBjP14GK9MBKMm8PyBTvWDIGobThLDoRnBJtB+3pRvIgkjSWIaJA== X-Received: by 2002:a05:6358:9491:b0:134:d559:2590 with SMTP id i17-20020a056358949100b00134d5592590mr10251018rwb.14.1694448309102; Mon, 11 Sep 2023 09:05:09 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-3012-16a2-6bc2-2937.res6.spectrum.com. [2603:7000:c01:2716:3012:16a2:6bc2:2937]) by smtp.gmail.com with ESMTPSA id k5-20020ac81405000000b0040fdcd391d8sm2688274qtj.72.2023.09.11.09.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 09:05:08 -0700 (PDT) Date: Mon, 11 Sep 2023 12:05:08 -0400 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zswap: change zswap's default allocator to zsmalloc Message-ID: <20230911160508.GA103342@cmpxchg.org> References: <20230908235115.2943486-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908235115.2943486-1-nphamcs@gmail.com> X-Rspam-User: X-Stat-Signature: h4uz5wdz4bg483mjkq6pmxar96jxjuxn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3A693A003D X-HE-Tag: 1694448309-491371 X-HE-Meta: U2FsdGVkX1/jcN/xVWeQCCogmAcudJPIxgVUj5D2aaOYSUoqpZZgzS/CTcp2oHNd2OMy1RTPffeKQCqpM0PxEsHO5WU/EEydG4cLB8SrLQ5CY3DejSgV0TVeDtzLbfZosXtQ0dl3Zt0c7GSQ91xa0IF309omnkA8mcl3eZpOzKvThEg9X22ijjnRTPDd63h0JSXpfXhDp/bVs1rpFgq0dwkmOiRCsNsPS3VZt4dBFu4d+va/8naefl81R6dE/oYKF66Oe5com7rP9T9+TbrpEGZn8/C8r+t/2gYa5sZYe1pJyrUbS6Ysw35jgDkz0QEp38chbKE8fvmi0b5VA2rDHyJ8ExKd2PCT6M6SLBDWnSVnH4Swn5kVHRARa28uzmBwGkFD2QiaOhz63RR+l+GSrMzQGmOhm2KlsL6bDxbCEsTieDol1GzTq2nKrhpH+REOM8mzb4Y7m7SuHUp2diPlcC2rzUaKahcFtTlJ73pQrQKzG0bZkYLG/yXNBmezJ/yYpXTHHfmsF1q65e/KR54fgeYTTTBS0qrRPPnHI+ZZzA1VqxDGOJGmWURfAk0wh5ZTg2WaeDbYQYd7kK9VpDjj/YLJHItk9pcsj0bE+GWNsoIP8szt6AmL6BjpW46yDYl7PjlsD7zJqCgzmR9yTXBmPd7HVED3tcmPXOLe3avjfwujxZaL1fbvMTCnJyXHduR4D00MYgpS7VWD/rSFkhd9K6hSvk1HTbwJi1bwpXS8DGgcHARMGKMHp8bH6xZXRCTW7BQAPfiYzBJgMTgLumbH7cmrO/Bznes/HPBt9NXfUcBCIRD5Slws2l7l/9VMmzzQeVr1EpLer5D9eo40V3fUafXhQmND1vwfCHTGy7xmRgdfGF1JoIFPYhdeXcOmqnBsnR+gi7ZwTBvim6oVF4egJu6MFMPUZcY4Zt1kwIDWljoBU0zJcB7Y2DolR3L1neJ6eE/kQRP9MbUNiG20mwh +OvLhqtC Fl4Wn5h/uNNTJXxDR4hOxPmfq3gMNHjurkabZ1tmet4z35BZulAUiiKcsIg+pXSDx1RdExaCbA83qxAqt2N6d/Mqe6KyqScQtGPxIQwmsxZrC95b1z4jNtTFQB90MBoI78aDrWN/s9SMpIqKqEXczAdsPQXX36tm0MH8MAmzJF+3B8/Gfrs6Vl2PbzuBrWvvl7XMY9BziPi/MnSOffDka3QcYQ4L1wIoTWgz+TO0/VVQ7/Khxm/P8oIkfr87SBqqz9rFKdHT10PIWRd7jDWI6qz13gZOKR0IvolK4R5Bc3YhXiqafqcTz4ucdxuyUnek29+OcaAO6tbqPY3ofe+ZAFUaLtrH3lhlm6H6LYuxM0U5G2x4NgSenWvApp3v1cKAfVM8oORfPwR8nUyoDEmXEh8WHkhECwlhXzBgdC20/wh+mfWDkgxLzzeEzLtaO16nUyjvr+Tev7W3U2SXwRW6WWY2pR9+u/4KSyzm10mjSxGUiZ+T+RBzLrAULD8mF/GfaYEKL8am2QH7bIPbeoHieCqHz5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 08, 2023 at 04:51:15PM -0700, Nhat Pham wrote: > Out of zswap's 3 allocators, zsmalloc is the clear superior in terms of > memory utilization, both in theory and as observed in practice, with its > high storage density and low internal fragmentation. zsmalloc is also > more actively developed and maintained, since it is the allocator of > choice for zswap for many users, as well as the only allocator for zram. > > A historical objection to the selection of zsmalloc as the default > allocator for zswap is its lack of writeback capability. However, this > has changed, with the zsmalloc writeback patchset, and the subsequent > zswap LRU refactor. With this, there is not a lot of good reasons to > keep zbud, an otherwise inferior allocator, as the default instead of > zswap. > > This patch changes the default allocator to zsmalloc. The only exception > is on settings without MMU, in which case zbud will remain as the > default. > > Signed-off-by: Nhat Pham Acked-by: Johannes Weiner