From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95884CA0EC1 for ; Mon, 11 Sep 2023 21:09:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F9616B0301; Mon, 11 Sep 2023 17:09:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A8946B0302; Mon, 11 Sep 2023 17:09:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1972A6B0303; Mon, 11 Sep 2023 17:09:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09BB16B0301 for ; Mon, 11 Sep 2023 17:09:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B48CB120C11 for ; Mon, 11 Sep 2023 21:09:39 +0000 (UTC) X-FDA: 81225558078.25.AF1F94D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 0D7448001A for ; Mon, 11 Sep 2023 21:09:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fHVl2kE0; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694466577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4Tq/DC3bKWKckqpaeQh5Ti0/bWogMaL/mRvxeNhp14=; b=75r5rBNgwJ1c7GncIm3LDZ6xoE2qZEQDKfoLJCTdaZGDcE+j8L25o3pDbHZ3P+TlKJrKG3 UFr2MAb0TMKwv+w4ErBP4dap22ttBnyk3UIQX9wbItbn0fVSChhStEUElwwmCcHg8Op7ot IXXzoe0yHE4JCvnwJvA+aItbuJZiKaA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fHVl2kE0; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694466577; a=rsa-sha256; cv=none; b=1fkvpgLW1oMc3aojBeWnjkiQqHZKvU6Ur9NChD5aI6TZ9YgCKAyc+XDgIpnkSNbthKne5/ PPQ2gDV6FOFBTeE7LcMTLjkCWAQHHHUSC6j7o0Tk+nOm2T+Qpfj8wIR8X53QTv3TXGS7Dy jiLVaiqeAzL/aGTkeFl/FH5NTDBVaDk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B5116148C; Mon, 11 Sep 2023 21:09:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BD24C433B6; Mon, 11 Sep 2023 21:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1694466575; bh=y2UYJ9xO0/iU8CVs2qutTCIZNaR/yPIdNWIpjtYqvS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fHVl2kE0nI05eFV42Myffm5EGR1WdFEyEv0Zy7Hw+qCXrVE6NOwd5MDtDlFL+cvK+ EjiDK8VqsxcMhxo84Kzour//v7cOwVUl+6cTZJGEs/NmrvQmdfc1f5CNibK8/FCxyL PQkObg5WLmMgXYUaFy/HIHaL1mN+foNviQCXg8zI= Date: Mon, 11 Sep 2023 14:09:34 -0700 From: Andrew Morton To: Zi Yan Cc: Johannes Weiner , Vlastimil Babka , Mel Gorman , Miaohe Lin , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching Message-Id: <20230911140934.4fb3cb429fd1b4623c68e3c8@linux-foundation.org> In-Reply-To: <931839F8-3D9B-4203-9FD1-BDAF998B3C97@nvidia.com> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-2-hannes@cmpxchg.org> <931839F8-3D9B-4203-9FD1-BDAF998B3C97@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0D7448001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 88f6gy8ntd4c3mrwj6jporeq3kii6egz X-HE-Tag: 1694466576-178697 X-HE-Meta: U2FsdGVkX1+C/KtNTtKYqsI0MV4XhiBQnlyui3MCxPeGM+qEpziT4ppkISDtUbLSM9PbgHCCnEQxJ39d8TwBBGzz41kbVZj6haTbq9659PbPmoby/qS4OEhYPieZGv3SBtWWMPbXLlPIfdC6NR7bFOG0h3FJbOZC2EcNFVoRKh7OPpgestdsBqOSMPhYa6EFl1a3nU/G+xCemT6NgNXbnIATkUlLLHVkFqqJ0KxYR5zWRrBD8N433wQzfmPFLRfsZQUsBLVaRVi0rP+a+SZhaPR3StTPp/z3RdpMFI8jRWkmPGWkPllE+nEiFA3pf/ErpA0ApTXA4F8Wk6zwlbgmv6GxEsii8tTT/sJ7SsI9THWmJgnWR5xY93sJeLwvUsPVdixIJHignybYj39p4pagYpLj0BN6CAgr29jpuvwMLaIR0wIcJ3TjyBwD2kQHbX8s709QaElp+q2AWm3TJemqI1PM6a2Qd/fXPNBLhw6Aq0gmDASd9IwrT4XEErNzg//aGjOmkjWVKdSviOtroGkuQ1qOx4ARNm8xC+74RCfreqCL/58hwBSVvb4TdVBH/h8OM20YWytJhRbaJ4pDsViUBCKOtqLYKzC/1YnhKIUA9hKv6JMv3wiFLx/RNL6+oNmVGfqKnr7cZlpxTezak/QbbL83WvU1i+E3QB7AgPAnN/OaVHfrV9f8uur9HtVFqCSn8hKtbcfiViZUya7ANQctUG69UZ3KNFKxVlvWHptlQIwGUCLi9aTWPZLjHhn0i6YhLCbXlEY7fqQxHOrVSTpohgKzdpl0HWn3FbsUbflESw9lkiGLp0zEB/GPnaMbQPFyOwFkYhKS45s+yRomYkyzX4MywNH6bP5bKdCnsQVm6FWjJfkHNmTfQiMsnJ7Juqw+AQf0kFgcwk/Jjg/5Kg4ZuWWQRqStRk0zRbMX2sV6DWhnbdm8BvOx5a6fLtePDDvtbXHMF2mn3X3vulEuB1P ef8J3nVr 96YJ4OhOVIl7o5erbE18tFLxEFPzP47vAzGZyv/NJ78KRKT0Rbshgl1sCZjClYWg6izyZddBqVuFPx4y7V0qhp95AUVWPpbvppEKYVs/HZzkBCSS78V5+tYi8pY922AjPNW4QOm7GXkaVKvDEk/7RkXdZlrj6ng1mr+QDQ0i/YYWGQDbA5xFEeua+e74+XIjfx2kN/LvaZGVVUfSVRRRbxSc09UoLEzC9qVBFrTegYFfbFZuEDDILu60CxrOeipsNcEp1A/gjUnuiVczPHXerSOfLBqQ2sHieRGda74xHEtLpTbQgK9HLzMyh6I0eqo/+NRiJNYb8a4VzW3J0IGzhnCc5+09RyuHQX9SA5BmSxXTQkjN17baipnoymnp8qmqyCQRSjPFLocYvCDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 11 Sep 2023 15:59:43 -0400 Zi Yan wrote: > > A side effect is that this also ensures that pages whose pageblock > > gets stolen while on the pcplist end up on the right freelist and we > > don't perform potentially type-incompatible buddy merges (or skip > > merges when we shouldn't), whis is likely beneficial to long-term > > s/whis/this Thanks, I did s/whis/which/