From: "Yakunin, Dmitry (Nebius)" <zeil@nebius.com>
To: "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: NB-Core Team <NB-CoreTeam@nebius.com>,
"tj@kernel.org" <tj@kernel.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"Yakunin, Dmitry (Nebius)" <zeil@nebius.com>
Subject: [RFC PATCH 0/3] Helpers for debugging dying cgroups
Date: Mon, 11 Sep 2023 07:55:09 +0000 [thread overview]
Message-ID: <20230911075437.74027-1-zeil@nebius.com> (raw)
This patch series is mostly based on Konstantin's patches which he had sent
years ago [1].
This functionality still seems very useful for debugging the difference
between entities in cgroupfs and counters in /proc/cgroups, e.g.
searching for files that have page cache which prevents destruction of memcg.
I saw the comments in the original thread but didn't understand the Tejun's
comment about usage of filehandle instead of ino. Also I saved the original
output format in debugfs with extra counters. We can rework this format in
the future but now it seems straightforward for just filtering through
cmdline utilities.
[1] https://lore.kernel.org/lkml/153414348591.737150.14229960913953276515.stgit@buzz/
Dmitry Yakunin (3):
cgroup: list all subsystem states in debugfs files
proc/kpagecgroup: report also inode numbers of offline cgroups
tools/mm/page-types: add flag for showing inodes of offline cgroups
fs/proc/page.c | 24 ++++++++-
include/linux/cgroup-defs.h | 1 +
include/linux/memcontrol.h | 2 +-
kernel/cgroup/cgroup.c | 101 ++++++++++++++++++++++++++++++++++++
mm/memcontrol.c | 19 ++++++-
mm/memory-failure.c | 2 +-
tools/mm/page-types.c | 18 ++++++-
7 files changed, 159 insertions(+), 8 deletions(-)
--
2.25.1
next reply other threads:[~2023-09-11 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 7:55 Yakunin, Dmitry (Nebius) [this message]
2023-09-11 7:55 ` [RFC PATCH 1/3] cgroup: list all subsystem states in debugfs files Yakunin, Dmitry (Nebius)
2023-09-11 18:55 ` tj
2023-09-13 10:33 ` Dmitry Yakunin
2023-09-11 22:16 ` Yosry Ahmed
2023-09-13 10:35 ` Dmitry Yakunin
2023-09-11 7:55 ` [RFC PATCH 2/3] proc/kpagecgroup: report also inode numbers of offline cgroups Yakunin, Dmitry (Nebius)
2023-09-11 7:55 ` [RFC PATCH 3/3] tools/mm/page-types: add flag for showing inodes " Yakunin, Dmitry (Nebius)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911075437.74027-1-zeil@nebius.com \
--to=zeil@nebius.com \
--cc=NB-CoreTeam@nebius.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox