From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20AC6EE49A4 for ; Sun, 10 Sep 2023 21:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AD826B014F; Sun, 10 Sep 2023 17:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75D1D6B0150; Sun, 10 Sep 2023 17:35:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64C236B0151; Sun, 10 Sep 2023 17:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 56BE26B014F for ; Sun, 10 Sep 2023 17:35:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1CA19C082E for ; Sun, 10 Sep 2023 21:35:10 +0000 (UTC) X-FDA: 81221993580.15.484AB82 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 52464100008 for ; Sun, 10 Sep 2023 21:35:07 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=czdkTWqm; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694381707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XA2c0IT6Aq3X55vDkdd23iLLPYLoFfYHGtZKCPv3hyc=; b=rmZGEZCKFb+9Npw8I4f5uXATa1snwFZ5C5gk0FJ7LqA6Zeio74nO7puWxWXi/DoHgXYB1A LWH6mc28kKB6DiLKtdg38uKdBh6ntVYg7VkCPKnSkEF2EXqlt3WxUoXjEpnLa5RxLIejxJ q13wsdwFfgWu8dZNtGqmEhI0xHQPdHc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694381707; a=rsa-sha256; cv=none; b=qXclc1TJ/1vytl+2tAkaaoBmLCmBUcBWYV06HkywCEG5LlD7S2YUemZ+DQSdIXUjJkXKaX DrlijXzAFVo4D/zsKVL2wCrbQwQpfJVza+QRWH7bCA6lLyDJCs+M68ki28oxZCp+C2Ewqh KnPlNTYK/HQrLrKSUCGSosNBIdvuIag= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=czdkTWqm; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37DBB60EA8; Sun, 10 Sep 2023 21:35:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CE7AC433C8; Sun, 10 Sep 2023 21:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1694381705; bh=JPXOur3rM+l3ssv9EopwzgCejOCqHQeR72cDSEWxoII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=czdkTWqmnpBoMzhS0k0mUBpf5DvUSwikIafRVXUiyMDDVIBrpQhGZG+0YBCF2XQV0 D4XYP1ch28nE4hBJadZG+5hcZdwS+TKc9JQmaAMmHD6jQYdRXJ+JRxrRyiaou9HyNc 7pcsWWwXNlyBncy1UKeOBIWojjsmfHCmls6ENOoc= Date: Sun, 10 Sep 2023 14:35:04 -0700 From: Andrew Morton To: Aleksa Sarai Cc: Damian Tometzki , Christian Brauner , Daniel Verkamp , Jeff Xu , Kees Cook , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memfd: drop warning for missing exec-related flags Message-Id: <20230910143504.6ebe71b01b3d23b96ec842ec@linux-foundation.org> In-Reply-To: <20230906-memfd-reduce-spam-v1-1-1f0d35facd95@cyphar.com> References: <20230906-memfd-reduce-spam-v1-1-1f0d35facd95@cyphar.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 52464100008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sbk6kq7og9399477zw9aocrjaqj7tixa X-HE-Tag: 1694381707-632125 X-HE-Meta: U2FsdGVkX19lm8eI3zpd/UkTlYBkXxkdjcHxDfdTmemoLLZjLSKqg6N17QzNOhrAO+ExA7jxs3jLxmiDUOdM7ftTNWatr33CqQO2DM6Gv7osCEll0faMI9Cqa2JDO2YXNvZew5K3vHUIu3QQW/qZ+We663q/HJAYASPd9Fs+nJc58CcL83QBKoizAbLgThDASlUGrRN8vwwtGxBUPewn7gPbakyjFXvCFajDHgbqqvDtfjSkqozJPKNe8TEtJPLgUb5tR08J0ePgFWry9B+ZROyeEpqMP2KrYoX5Q9Qc7c4kSmr93GeEPztCqe0D6G0g7bo1dmrWihawfDkDLf9oK+pXaJfsnV2vbiA88LGScM1pu/p8QQdwnfKZY98sBPvhVhZ48y3DPSW9Mx0Vbaxair9IcRVeQ3R1kiC1PvaOal2Td/dW1uMR/R1620ctUPbSNq3y+AbFp4qsyKroj94jd+JgfM4rYSm8ZUpEFUV31Rcfq3g+tkr7Nd5qNEkip6u0gKuzANUw+cmShjc5LYVbLI8hY3wY7QHI/5JP22hiZy6J7Iu94lYD9r9DiMvkA+l7aXe7efxCdlSnM8DOEBklyDCtYwUb6MdsIa/U+ACX/X/BdicUMFMRd43doangL/biD8caH1r2E0PuC1xB6lW3PtaWzGFItqDqEZKkfN9SJkyYGPCmaOTHeyAM3S0HC6C0YPkSpvqtWV4hNXqDfgKFo28rdJQiflPuCzInfXpNTIsO+sOUxnXL+kvXp00EpKXIxvuhhXVqe5uWk1QQ/KTLBOngmSdYJgq1c+NfIpqlcLGLZ/laKuvjUwzFuk3aAFiYcoHrOhSlYp3o1KSkl+byZ0s77GpPt1wC0TWwz0hjdpYmW9RZrKvGiGoDoX1+FTX/CUv5tpQAkRD1R4W/oBnutvvHxaV3r05zoUq9sfpsHE7zGTqLhEiipB1aKaUM0SzJrzAKGTaGYIKVx9fvxyb BJTJG93e VEHFW/nbVqNNPEJ3Ndb2TnGGBPfU+Wn07FHOX7jmJnVpYuN3lK6w/fFLg4Ff4PptFl6PIRgsz9tPI7oTmr9700awLB04euV9RmHCQxJQMFKc5SISxJVm2MqlilyUYwO1CO4JUqP3eDl1SVxr/stEuN8RJBrOEFL4aszQjUkcpAeHADjVGg7Y3sSorsBIWTokv6PUEJ2+25x4ScbguUbnPb1tjjp3wVs/Zu7lFqepFJ+EAEdWWqLEtPBp1B0dCYtSokL5KOvyPhLl0zFrc5gWmj3O1aJx0Fnlz0DTylemSRYP7nMZIZf4U+tV5Y7CkBqxW7PM+eeBLlQY9GXuoqmm1bHAe81lWKiWU1fMxPnjMOFbMDpsf8W+ONACmse/3cJcZLkLJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 06 Sep 2023 17:02:06 +1000 Aleksa Sarai wrote: > Commit 434ed3350f57 ("memfd: improve userspace warnings for missing > exec-related flags") attempted to make these warnings more useful (so > they would work as an incentive to get users to switch to specifying > these flags -- as intended by the original MFD_NOEXEC_SEAL patchset). > Unfortunately, it turns out that even INFO-level logging is too extreme > to enable by default and alternative solutions to the spam issue (such > as doing more extreme rate-limiting per-task) are either too ugly or > overkill for something as simple as emitting a log as a developer aid. > > Given that the flags are new and there is no harm to not specifying them > (after all, we maintain backwards compatibility) we can just drop the > warnings for now until some time in the future when most programs have > migrated and distributions start using vm.memfd_noexec=1 (where failing > to pass the flag would result in unexpected errors for programs that use > executable memfds). > > Fixes: 434ed3350f57 ("memfd: improve userspace warnings for missing exec-related flags") This was reverted, so please propose a new patch against 6.6-rc1.