From: Andrew Morton <akpm@linux-foundation.org>
To: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
Cc: Liam.Howlett@oracle.com, willy@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xiujianfeng@huawei.com
Subject: Re: [PATCH] mm: remove duplicated vma->vm_flags check when expanding stack
Date: Sun, 10 Sep 2023 14:26:27 -0700 [thread overview]
Message-ID: <20230910142627.0dce42578bfaab7c4c67e316@linux-foundation.org> (raw)
In-Reply-To: <20230906103312.645712-1-xiujianfeng@huaweicloud.com>
On Wed, 6 Sep 2023 10:33:12 +0000 Xiu Jianfeng <xiujianfeng@huaweicloud.com> wrote:
> expand_upwards() and expand_downwards() will return -EFAULT if VM_GROWSUP
> or VM_GROWSDOWN is not correctly set in vma->vm_flags, however in
> !CONFIG_STACK_GROWSUP case, expand_stack_locked() returns -EINVAL first
> if !(vma->vm_flags & VM_GROWSDOWN) before calling expand_downwards(), to
> keep the consistency with CONFIG_STACK_GROWSUP case, remove this check.
What are the user-visible effects of this change?
Do you believe this fix should be backported into earlier kernel versions?
next parent reply other threads:[~2023-09-10 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230906103312.645712-1-xiujianfeng@huaweicloud.com>
2023-09-10 21:26 ` Andrew Morton [this message]
2023-09-11 2:04 ` Xiu Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230910142627.0dce42578bfaab7c4c67e316@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=xiujianfeng@huawei.com \
--cc=xiujianfeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox