From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CAFC71153 for ; Sun, 10 Sep 2023 19:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5896B0149; Sun, 10 Sep 2023 15:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275A06B014A; Sun, 10 Sep 2023 15:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1649F6B014B; Sun, 10 Sep 2023 15:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05BDA6B0149 for ; Sun, 10 Sep 2023 15:46:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B81E4807A3 for ; Sun, 10 Sep 2023 19:46:28 +0000 (UTC) X-FDA: 81221719656.23.0A48DBB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id AD773C000A for ; Sun, 10 Sep 2023 19:46:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2V9lg14d; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694375186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cSfBy0BmW3KIbm1ByjRbjUY1LAeMmrzd3Zi/of0RRd0=; b=F+Z9e9FSFa9YtEOeavBolaFgNjTKQwkIZDe7rVyi5jEDIM9oGFDBNcW7tVxfTjabDnxQzn FmnjAH6T8JiClZHlbJ5iVXTiUxb97dlZAg55zLoiIrYWsTnses2HDQRk3adVgA2QVvZfi6 LZJ7Hz73B29ME+JUSftxhwwiT/4Dd28= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2V9lg14d; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694375186; a=rsa-sha256; cv=none; b=EH7F9xu8qwreZiJ2o/1sHfg1cEAyhEEURIkn8DXq7+5hAUNhTG9OJmh34w7FxWEGRmBwoR 4SAAJx7gCsK21usDWFJcTEBRLUR/wMI784+xe1e3T7QCDSglX0Zbb1XYOUFq7OMwbg5Row cwEddqBE6UhBEEE3reZfwHfV7gN3tG0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1F46FCE0A2B; Sun, 10 Sep 2023 19:46:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39736C433C7; Sun, 10 Sep 2023 19:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1694375179; bh=/RdVFooXsrbyX8Eta6x7htXabnWy2twp0h77zhMGNPY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2V9lg14df2D/mgk2t2MzpklZGlXD0fSgDj2B1xO9oTEOo0tWcfKvLnzI6IzxQO+nI 8jquFpiRQYfwFrS3s4ytrAXhsLyCNm/mhJXYBw0GlPara4S9uuL2pxGCWqGOF1ScRx 5fIsrrT1RU2JjcxqIjAdjhDtkACEXvWGkvWvWtRs= Date: Sun, 10 Sep 2023 12:46:18 -0700 From: Andrew Morton To: Jane Chu Cc: willy@infradead.org, nvdimm@lists.linux.dev, dan.j.williams@intel.com, naoya.horiguchi@nec.com, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: Convert DAX lock/unlock page to lock/unlock folio Message-Id: <20230910124618.06a8284ba0e059da11cfa823@linux-foundation.org> In-Reply-To: <20230908222336.186313-1-jane.chu@oracle.com> References: <20230908222336.186313-1-jane.chu@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AD773C000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5taffk5ogcnhk51xi8u3ciim1zaohc8s X-HE-Tag: 1694375185-546552 X-HE-Meta: U2FsdGVkX1+y5bxWz73s7dvKEwkAqV3t1o07butZn6EcZsBtP8fme4MphSTGr1Ll1if3q/gbDaqTN1xIh/WtAHTrSufSUo8jFiYtgNqXuILOgxMJcLuujGpDGtIXsyO5ODsIArJ/BpQkla8ni6BkZOiwnCS4EPXa5+KKu6BAOn8/bivyk8ZSzFIgNBXeM6p+ISaSaQnAd/tOmgx7A2ttrGpUW0tVVVVkPB+lzEtlQLzYj3stp5LAJ8UJO695NAn/aGuWIhdiXzIREmF8CKvlnMZ1Va3y88g9nA0ybEfGdl+Q+y8RS4wVjaYt6tamQK7mAhY6XXGkiqYrE9SGmARgheeAgAieQJ3VXgNvzmy6c7Kw7qCSTYpeCRfJYwwN+J8Fqx10dKqjLcEzhKRvoCFq3TgQc87I4JfwOrTj5XzstCHLMxUaIKwmN3qkwygHNafxTw1H7c4RmVBXiEZQoDjH0PzxoKBzmuHz/QJUUjreGLpvyMWjHHXfjM69S2//uEus56fAixXvotN21CS1w8ZrGm0dJjcJwQNUQoMFY166saFoY1kcEOhxGzdcjJw+flgK2gwh4/0vAw8583mj7Hu3wJflgyHWDYsb7DIIXi+syroIzno/fPZu/RQqsKd87jeFnUDceuGHu0W7adKNwKT7XzZIK03EdkayJPq+H7BH5Hy63wtUPLpk2HGW2mxxo0/amnnmi0d/qF4gctS6YWLCux8tufZx5z/iHdpWQISHI+UsQpiuLZghv4UnIkrmWYio+O77mLPhrNUzqOtrE8w0eUBNqxF4A7m7k5a/LBfuZho6OcUJpH+rd61m1NwOKig6i6ORW25GZs7hZKD2REBB4SZPYVKBNYN28y/STvZoBxaEgX94nqQq5XV93n/pBytSeTWfXueX0mOLi0KLh3oX0k7dFshd/aGh/yUrmRDJB6hbSIZrmUHrddikVbo3PLat+jTIWqMWP7BsowRmXFi RtT0itou vxpil/vKOliMayKW0zbiqcn2e/w8jjqM+zPWAmIqgeSi1Dh0tLuUzeGY/AGJWzvKHvwXKDb7uCRfwnLRAMq06Fry+a7uIwMu3OYBUSI6VodlV4AoLmlj3IgTA1U2eH5i5GxcamkguJmK3zCbpZpYd+ndy9QcHzwD//Tsp6ndQ/TgdbxlGXSxEGN+o0VV+Yy8r0RqSS2k7Yf1j+mHb8cmFiTp2QYXZtWcwwMZjNvC48z76hgf6Eqr8VnWw9/KjEYX7mdVkTWgKpc9cDejgW7f7oLb3caZufQcFQbBKcsdX4oQgzPVrJx5c49pbRG+Yg7MjUsC6WZyH7MdoPnCKHT9ILApfze9B/4dql9OQBsGuwnKhHnN1b+5vw1ixTBf5z265r1GsbyIJ6jvDbRf/WftSHAMlqncaZd/JSweut873hLXb8uutomrO9gHGB7aCMpAYA3rLz3dVzZ90yyg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 8 Sep 2023 16:23:36 -0600 Jane Chu wrote: > >From Matthew Wilcox: > > The one caller of DAX lock/unlock page already calls compound_head(), > so use page_folio() instead, then use a folio throughout the DAX code > to remove uses of page->mapping and page->index. [1] > > The additional change to [1] is comments added to mf_generic_kill_procs(). > > [1] https://lore.kernel.org/linux-mm/b2b0fce8-b7f8-420e-0945-ab9581b23d9a@oracle.com/T/ > The delta versus the patch which is presently in mm.git is: --- a/mm/memory-failure.c~a +++ a/mm/memory-failure.c @@ -1720,11 +1720,19 @@ static void unmap_and_kill(struct list_h kill_procs(to_kill, flags & MF_MUST_KILL, false, pfn, flags); } +/* + * Only dev_pagemap pages get here, such as fsdax when the filesystem + * either do not claim or fails to claim a hwpoison event, or devdax. + * The fsdax pages are initialized per base page, and the devdax pages + * could be initialized either as base pages, or as compound pages with + * vmemmap optimization enabled. Devdax is simplistic in its dealing with + * hwpoison, such that, if a subpage of a compound page is poisoned, + * simply mark the compound head page is by far sufficient. + */ static int mf_generic_kill_procs(unsigned long long pfn, int flags, struct dev_pagemap *pgmap) { - struct page *page = pfn_to_page(pfn); - struct folio *folio = page_folio(page); + struct folio *folio = pfn_folio(pfn); LIST_HEAD(to_kill); dax_entry_t cookie; int rc = 0; so I assume this is the v1->v3 delta. I'll queue this as a fixup patch with the changelog add comment to mf_generic_kill_procss(), simplify mf_generic_kill_procs:folio initialization.