From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D137EEB57D for ; Sun, 10 Sep 2023 19:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92E4A6B014B; Sun, 10 Sep 2023 15:46:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DE8C6B014C; Sun, 10 Sep 2023 15:46:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A70D6B014D; Sun, 10 Sep 2023 15:46:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 698846B014B for ; Sun, 10 Sep 2023 15:46:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 455E61C9F52 for ; Sun, 10 Sep 2023 19:46:47 +0000 (UTC) X-FDA: 81221720454.28.BC29B0D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 711B24000C for ; Sun, 10 Sep 2023 19:46:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fNu7XQCO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694375205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0mvlneHp3c5CaAZWyTI0H0bsvFFK1kORjGTdIZMpYRo=; b=TnBvAZjVDAGpgWZbpMc2Joyid55prr2vfw0tVUaTsW831ppGJodFfuUTjtQJ7F8MY/X90M EoO+CoaBoD4CZTNQg8hTQdiVzHYGfh3j4/RbmRjkhIDKLSW9/hdqYwXOaqzJ8oHkkaf6RM Igb9QNO5qA1JMdLngWmy9yvegbTlEcM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fNu7XQCO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694375205; a=rsa-sha256; cv=none; b=Ox9S3m/ojpw39WDesMFxp/HSFzVVHaXUlbhic5nXUwGBsunNQn0/5yMVe3IztEOGv9kJ8y jBSGhKGv33zf9BeUiEE7+OIrzPvwjc3O3Pxj8K3aRIlRL9o21JF9aEZ7WDdWDHKJBio/sw Q0ceDSQrlPGQt8YtU/EJKOU6vMYM6fY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7ECAB80D0C; Sun, 10 Sep 2023 19:46:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11FC9C433C7; Sun, 10 Sep 2023 19:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694375202; bh=0mvlneHp3c5CaAZWyTI0H0bsvFFK1kORjGTdIZMpYRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fNu7XQCOOWWxuhn83tvc45l4SurevbxCseaO3e7zweDPnkiFN79JVQ8NBbOSw8zF2 rxppa4yUMHfgC7ofTpxl7BseKR9GMA+GleM5xt+C7Q7t1sTHk7NF7satVwjWYUN66e s1E8q9k6ge1M6v9dAaH6NVkiqkz3HuvGuQ19JmQtxNUJp2nfesCePg3nhCBL6Rv0Xb b+Cy0UbkeWqHMtoguJxOtLLglVtRgTOb7HYFaoH1Mkt8d7MSzbGUWCn3qploEb87q/ PAlXt7DmRi4bIgLM8+SxCPYdY1tCZ4CRVjymtWbG3vwwE8KYMmXUtwvz9HuT7R3pit zugbaYRnjekJQ== Date: Sun, 10 Sep 2023 20:46:38 +0100 From: Conor Dooley To: Samuel Holland Cc: Palmer Dabbelt , Alexandre Ghiti , linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] riscv: mm: Always flush a single MM context by ASID Message-ID: <20230910-haggler-barrier-421cefb0cc79@spud> References: <20230909201727.10909-1-samuel@sholland.org> <20230909201727.10909-7-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XAP+SDGC73uO892R" Content-Disposition: inline In-Reply-To: <20230909201727.10909-7-samuel@sholland.org> X-Rspam-User: X-Stat-Signature: t8p63xctsgtsdtijgcwrsn7it63bik5h X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 711B24000C X-HE-Tag: 1694375205-71083 X-HE-Meta: U2FsdGVkX19Mge+I0yIE+FdeUyUtI/H6JeeO0iskEOW0OlxCVY6oJxou7Ut+ON0cZYqwqaUanEmKewT+bpA0ZBM8scN80cRVmFhjAokQ0qRMmU5DIUg+clTFfcpRMgvHN9HcDg9/V9udUzOXmMp+2gqKwJM+zcr3pD8fS5HKKURHnmge9EgJGHiv2RkOU1BxmyFxE+2m1+q/9RlCTaKR3/6OXzePBc7H7u/EoUM1++4TCW1vea0hJ1gjyVifWdqFDfsu+gMTbKjY5coAIZUI/n3E+Tkf6jfBh3Yafz6EgRFC2Iy5L5rTNBhCJrncVk5EH6JpvP6ixs62Dipp529h4lH9Voiq9VTgk+sPdQP8rrNn1boErEca2KKlfFBXPssnOtszXhJ8rQjzh034VuWeJkDRufJ0Jso0Qzv+lYOt4O0K41c44iS1eZ14NM+9o0lrhAjzJSQB8PCiopT0dPML2JHLIh92aOqImKpaEhV5MLSUkS32aHx8cVCgz6txxfkQ35r0hhCutdyOQsOEkAF/UeNF0jL9NSzyb0aG4dbXJJzp8MOHfw/7Spg0x7TI3Xr7c99rK7Y6Fy/rt5xbc9ah0RQ5Biixr7+ZIAWW84Qswb2XhnZCW9W6DZLNYOm0ZsTJI7gSydJLdrvSzbYlkNJjghIPcZb8PP9uKZh/LDMUJx6ZMj/w6Z1HxwRvZkp9XzXjXvP0lB3+c44uAdMzOD4NwsJDHdGGa6GjpBcphDs3UXzMcUPFcrDq6wvt7QQfQj9VSstI8vV7o3QJhs9eKOf1C5AQB5GCqV4BxruJ6po2vqZouVf4+iLuhZbt5JnFW2EZSBPQOD4nsV7tFt6W6wZQOZn+Qk4A9FF9KDlrrNazac4FUupvParusT/zdsE5BfgjGwzzg0jlb9s0+zOTswCMOET7Gwg2OFohaxjhMOp/c3E8GaaCE+p8QLgHsm2Z4diBmHnBh349DDw/3xcgaWN PA+UaCNQ 9RzkHP5h5ofBL5Z1hTXvBt96dqlIN1PjPy0nzoY1X96+qnbIH431IXMXPT4UqwkC6QnSpYisnrlVycbvjpGWCngs1395o5QQH7ajhVMyXd2n0zOaRu5HCd1vZV9eY+qTsvxt9ybzA1qv/ZqDpGhkp771YRQFp1RvcZ6uVqg6+W666P4omZAS819ZYvrlG6ZbSUkgRt27ptn8YGHv3HBPcOATBZQ7pDopu8h7+9yvdxPdNNmExRpFWvysxO6MzHUPUlMpE5ImwwozPvfnMhVlcEAP4JU6S+E7fna6x/VEh4A6yhr1l65qJPi9vsoyiEyjFF/OBtGPaCjwXd74JzUqiEuB8Talh/Sx6Ut1kYKJHSJfbnnofQ1n0IvVT6z+oXPfynwt2nhvxWici0G6b5lhwovDlL8CfLxpNa+tB2AQ+BTxbPnZMXNoMd/zRiKXR7EIQfFH5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003532, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --XAP+SDGC73uO892R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 09, 2023 at 03:16:34PM -0500, Samuel Holland wrote: > Even if ASIDs are not supported, using the single-ASID variant of the > sfence.vma instruction preserves TLB entries for global (kernel) pages. > So it is always most efficient to use the single-ASID code path. >=20 > Signed-off-by: Samuel Holland On nommu: arch/riscv/include/asm/tlbflush.h:59:69: error: 'mm_context_t' has no membe= r named 'id' arch/riscv/include/asm/tlbflush.h:61:9: error: implicit declaration of func= tion 'local_flush_tlb_all_asid'; did you mean 'local_flush_tlb_all'? [-Werr= or=3Dimplicit-function-declaration] Cheers, Conor. --XAP+SDGC73uO892R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZP4dHgAKCRB4tDGHoIJi 0m6yAQC30XIJEbs6GqdPJenN69cc0QqOG8mlUD4J0NJQ1HsG6QEAmbJu7+FKS0oJ Cv27cSMuq/YLDqJFq8GD2qPkVIAsywE= =NMxL -----END PGP SIGNATURE----- --XAP+SDGC73uO892R--