From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628FAEEB58E for ; Sat, 9 Sep 2023 11:27:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9CFF6B011D; Sat, 9 Sep 2023 07:27:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4B856B011E; Sat, 9 Sep 2023 07:27:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61E26B011F; Sat, 9 Sep 2023 07:27:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 982806B011D for ; Sat, 9 Sep 2023 07:27:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 50A711603EC for ; Sat, 9 Sep 2023 11:27:25 +0000 (UTC) X-FDA: 81216833250.10.452717B Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id 89BAA8000E for ; Sat, 9 Sep 2023 11:27:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694258843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NTL73TutL7tdPc60fT72FVmrOdQSR7SjLdIqm3n22tg=; b=pcm9km2yz+k/Ep8yk4FsGZxcoeExVC4u04/5o5uULM9bHM2ySl3Qn2R50+jIFLGF/bXihA rjkGQ/j6OiIRZUPjAqlPDRLov0wOFN0kTxeZiONFvukkXE7l3TDnE6TuNwDnFJ8mAULinx CkS4FqzsHWlLq5/V7YXGwG98pZaGGNk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694258843; a=rsa-sha256; cv=none; b=ypOQmhwvxUvKo41kATua+IqOS87rnqdKhLDGa5lcWRLqoJkJg1EFGFkiXmnAvSATxnzL+a HjMM8Midi3Qz3osw8C0uP6o+OQZRIBYHcZbs3q56+ut8jtj6mZjk3TMeQjb6k4WqOHDV5H jnZt2RJ1A12EYNnhtUabZGzT5WNxd+I= Received: by verein.lst.de (Postfix, from userid 2407) id 4F09B6732D; Sat, 9 Sep 2023 13:27:19 +0200 (CEST) Date: Sat, 9 Sep 2023 13:27:18 +0200 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Christian Brauner , David Hildenbrand , John Hubbard , Jeff Layton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] iov_iter: Fix iov_iter_extract_pages() Message-ID: <20230909112718.GA12045@lst.de> References: <20230908160322.1714302-1-dhowells@redhat.com> <20230908160322.1714302-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908160322.1714302-2-dhowells@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 89BAA8000E X-Stat-Signature: nzw6xjkqcghdw9u8znsbx38uin83h8mn X-HE-Tag: 1694258843-927519 X-HE-Meta: U2FsdGVkX18ihEATmxi8tiEdXL2SzL/YNjU+v/EVYmfliJHvlGjCGzF8xKQ08Y/30EhsJtGpVTwzCcXqCHlrIhJDacHSnBD7LDLyP5aubJzgBEElsVaFzb4lwwPemwVw05pQI9erHsCXZZs830lc1tGIvlEsHJKaGCn3diIf79NeCrIheaK1V4EliLpRPLG1AxyE8apzi9CdhNBqhyITDk1ghvNrLweJMsvlX0gqpcivGT3T4WUpgEUHCTeAW528mNpikrKyxMyT+agGpYGLM07LPC8r/yZH5ia+eKYULlctyG0s+pNBLvWLl5odnKd1dLZBJe+5jjv7q1TTFchOhcWOguYcOjbvFk/M+HExjNGDqgxn6hjkmZrsu2TT0+1rfAGJxHqgDNKOCqro67NsCuh/i8+9XBhJLJkwyFhAZt9utmgCR9dsDrIOOXigrEJTixKP+CVQn/2I2zq7OInMh5uFf38fykrkaOH3IQYbHsIRtlRgA0xS2oqA5cx614PCQn4nkfJz5fgwmT567PWbluDTruM39+DVdirYu8E/ChrWO0BdhnSx+K/XYBfV++nFXxnaUQ6kiksb3KF7DRlL1dyjSGrDqYY+glVlYpGbzxmE3aKOxJzVQhqHUS6itm6jOncD81j5vSEweks7t0VyjIXg8QCa5d5um7m79qzVT9lvO3C5EtVozEAbxQnZmR2WvyKTJ+HvsYfpEFMSlVsK07aTVDrCbsrfqw55HqHaYeyIT787h8rdDKNVB6L7ZpHFojS2DSiNGUPNx6h73RUAL0Q5H26h80RFsu07jFnKTLvjAGVM5Q3lEzOnGKt0h0g6CWJTSipCFgGSJlfYXGQ76BcR2oon19pjR6ItRitDh1cdlVPKTSsyb4v7O5WSTAoyIzfuokwBktUAKXIUCxepu2ZfxVaY0z8q+HgeKpPJbr2q+yAXD6+DMzaCuCKlDcxs0Huk25X8wQWgkqboISN UP8XuxAL Z/U4GAfG+h89YeY7ipJZ4EwTKhkoKAM0dK+HYKb3hD0N7Bh3yFMzFdwWJ89qMbR9iaySl9h8lGp0DP68NQVccq2xE+ZqLgoAjHoyWP3aucAiuke0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 08, 2023 at 05:03:20PM +0100, David Howells wrote: > iov_iter_extract_pages() doesn't correctly handle skipping over initial > zero-length entries in ITER_KVEC and ITER_BVEC-type iterators. Maybe put a little of that into the subject. Fix $foo only makes sense when it is completely broken and not for a corner case. i.e. iov_iter: skip over leading empty vecs in iov_iter_extract_pages The change itself looks good: Reviewed-by: Christoph Hellwig