linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [RFC 7/8] mm/damon/core: skip updating nr_accesses_bp for each aggregation interval
Date: Sat,  9 Sep 2023 03:37:10 +0000	[thread overview]
Message-ID: <20230909033711.55794-8-sj@kernel.org> (raw)
In-Reply-To: <20230909033711.55794-1-sj@kernel.org>

damon_merge_regions_of(), which is called for each aggregation interval,
updates nr_accesses_bp to nr_accesses * 10000.  However, nr_accesses_bp
is updated for each sampling interval via damon_moving_sum() using the
aggregation interval as the moving time window.  And by the definition
of the algorithm, the value becomes same to discrete-window based sum
for each time window-aligned time.  Hence, nr_accesses_bp will be same
to nr_accesses * 10000 for each aggregation interval without explicit
update.  Remove the unnecessary update of nr_accesses_bp in
damon_merge_regions_of().

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index c813407c09b4..1ba7c4669263 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1182,8 +1182,6 @@ static void damon_merge_regions_of(struct damon_target *t, unsigned int thres,
 		else
 			r->age++;
 
-		r->nr_accesses_bp = r->nr_accesses * 10000;
-
 		if (prev && prev->ar.end == r->ar.start &&
 		    abs(prev->nr_accesses - r->nr_accesses) <= thres &&
 		    damon_sz_region(prev) + damon_sz_region(r) <= sz_limit)
-- 
2.25.1



  parent reply	other threads:[~2023-09-09  3:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-09  3:37 [RFC 0/8] mm/damon: provide pseudo-moving sum based access rate SeongJae Park
2023-09-09  3:37 ` [RFC 1/8] mm/damon/core: define and use a dedicated function for region access rate update SeongJae Park
2023-09-09  3:37 ` [RFC 2/8] mm/damon/vaddr: call damon_update_region_access_rate() always SeongJae Park
2023-09-09  3:37 ` [RFC 3/8] mm/damon/core: implement a pseudo-moving sum function SeongJae Park
2023-09-09  3:37 ` [RFC 4/8] mm/damon/core-test: add a unit test for damon_moving_sum() SeongJae Park
2023-09-09  3:37 ` [RFC 5/8] mm/damon/core: introduce nr_accesses_bp SeongJae Park
2023-09-09  3:37 ` [RFC 6/8] mm/damon/core: use pseudo-moving sum for nr_accesses_bp SeongJae Park
2023-09-09  3:37 ` SeongJae Park [this message]
2023-09-09  3:37 ` [RFC 8/8] mm/damon/core: mark damon_moving_sum() as a static function SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230909033711.55794-8-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox