From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C5CEEB582 for ; Sat, 9 Sep 2023 03:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C73426B0106; Fri, 8 Sep 2023 23:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEEDC6B0108; Fri, 8 Sep 2023 23:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C51F6B0109; Fri, 8 Sep 2023 23:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 819636B0108 for ; Fri, 8 Sep 2023 23:37:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5C5E6803C4 for ; Sat, 9 Sep 2023 03:37:33 +0000 (UTC) X-FDA: 81215649186.12.31D68BB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 2BB0A1A000B for ; Sat, 9 Sep 2023 03:37:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rusog3te; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694230651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ah0N2wcnfsJahuzxk5G28ObKAJFHz+yeGpKpeyogRrc=; b=PSHecNo4sSdpLd/DvpitwbPXu2eyVAdzrAmIyf9R1itM7DUnmGcvMfJouoNUuQtesvFK9M KQSVtAs1PKgOxpLKKF7oSjPJhEm7S0ozM1T3vGz+WRw/mlEQTANthE1ofuq5ghOevN7pQU DqQ6KztrTyoa9TPHVKktQqPOl3wWkrI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rusog3te; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694230651; a=rsa-sha256; cv=none; b=6AGLKNNk2l5A/ZvVN+qynBc4kMBfytO7ALYcsMP2suYjPuEgKF8Ep9nd6Goy6zmOUBCByr DB+P+wlengnYmlCuROWzw57MKQah21qW7XCMY+bnzdnblsDCKqOtnhLXP15X+8T1n2Z5F1 DyU2sEMyz5UZRCh2fACsMB3S7Zig04U= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2BFAFCE1D55; Sat, 9 Sep 2023 03:37:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8618BC433CD; Sat, 9 Sep 2023 03:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694230645; bh=1JPnDKE1W//tJKT6oD5avrUOMToQr068Qq2WbN1Xk+o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rusog3teG9hcnEOtFyrYq2Kl4tI6tcDkZHp8n1Y4H16VjWB/4DsOGZfuLTLsJm8nS /KC1kgaBiz/iwm9Mr+LOZkYK+jSgGPPIWvD+2zxifQDAR46fduvL1wLbxmfj2msgTQ pN/SHQdgeA2UmefHF2RbIODyciN8YusgRbTKifrDqmCndCNyUO66LeDAEmPihhRw9T 837t6pOuHXZ4rYjplr0cE5XHFi7BnwTZs4HC4CQl6RKBSfh3FuScz6o/+wAcle06Xz YZ1V1VZ2DLJma6bJ/qucOOstW6arYNziXh8dDPJl00i1FKQEKo70rgEhWHM1nRFZpX tjCjSSs1RtP5w== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC 3/8] mm/damon/core: implement a pseudo-moving sum function Date: Sat, 9 Sep 2023 03:37:06 +0000 Message-Id: <20230909033711.55794-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230909033711.55794-1-sj@kernel.org> References: <20230909033711.55794-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2BB0A1A000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ekgpnmmyjabz8j1pxg3cis8k4nay589i X-HE-Tag: 1694230650-317709 X-HE-Meta: U2FsdGVkX1/R3TWqS6qrmGm6KJtMFTOrl0OxI55kKh+89ZHc+0sGRYUokcSCbJyq7nP1bINxvKbgkKBV+iGeyJM8Txl6Ak9ClpVmPE5myJsi014l7awAin9Oa4UKVgHPpHhAtXgvz1BRao7y114nIKZpMYfuRlksZvqMXFF6Ks3FvJNCDnOYpEamuXkovlvFio6IEGjCHTF/EB47Wugf49hvyrUoVAwiC2WgWI1ypTn7g9QgtPrY8e2S+ZUkPdPLfic8rU81kszjhMaxOJR5sRUl2kWx/0Lf3HwNSonA1QLdL98nhP6b5Ai13XUfBXebGiCfJCFSXp7IKRhxooE7BvDjMfhe7fMI71qdDXqUSVa4Hm2meNQ7AV5IcE5+DSKPaQ8wO7ZIyTcSqv4Pd04ZboPR23srMdwLvihud7olL6gnspRyvJUbp3FdsCkIvFD2pN1259wI3gruUyjultaAAH40E5wLa89mws6TvrZ1+X3FTeM91ZbwwSacj+0OA7fTyL22Lzydy1x8MB6elYr0jDtlDFf4XI+OTIk4zmZHssV5s6jv59Q4C9YR5fUvtW2I7YQN+Ib73cWTE8vVMqbzdEB5FGrphiiW5z6eVTaNZBb4hYy/sctheJ74MnpGGp+mvV45rdPcPIOHB9s7P1mF6sae4TILQ6d+jAP1eSvylKfTuGINIKfBw9iGGdrPgpAEjN6YnnqNlaMiinl7/0GalnR2Ri86HrrcZ/yAsB/spvJwb4jvULkvUOxImUnzWsGXzBJ6eKMdUTrDGgbsfVF2xDrtahPHdkZ6kzBfVw/4pWfW8C8LNj4MoSA2cVyMm/ux+DZ3uIDh/Vv7V6M8DajkDavPlTzMV15wpX4zo/03qaPXc9vALzGf7Rlq4mXR92t79CrDSnrepwigWpnbCjxqcU4Qvy92d62M1XxR7UlIlz/dOsWZlh20aOvp5qARLhJaINMOqKAjI9Jr51Ak0tx JLT8f07U ARDC+8KkUWMKq2KHr+malSk1jdmjC0MtwzVecCH60lkYpopC6Yi+2rongHt00wpbgeLW3L9CIwSjlNjkDVShjtFjyf9jZLz2afjlLB7pk67j+drQf6EuzOY9RZRp//JtOfK2K1DpsbuRDk8bInDi38IFDZmYLtoRriexGLiit1HQV52M+kCbNkyO4VXdmc74EX3EYdWlqxIAKskuybmb/FqylxC4F4sXuiA2k1FTdtR1Fmf28Z0bepqCnv34Z/PqcgEA40UMIB222pSHPpQMCgYp/CThXaJzlgWNQI+4tNeq5jXH9/brL++CPPkXYp4+RKxiNd5ZBH83if0rQIq/nHcTmTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001083, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For values that continuously change, moving average or sum are good ways to provide fast updates while handling temporal and errorneous variability of the value. For example, the access rate counter (nr_accesses) is calculated as a sum of the number of positive sampled access check results that collected during a discrete time window (aggregation interval), and hence it handles temporal and errorneous access check results, but provides the update only for every aggregation interval. Using a moving sum method for that could allow providing the value for every sampling interval. That could be useful for getting monitoring results snapshot or running DAMOS in fine-grained timing. However, supporting the moving sum for cases that number of samples in the time window is arbirary could impose high overhead, since the number of past values that it needs to keep could be too high. The nr_accesses would also be one of the cases. To mitigate the overhead, implement a pseudo-moving sum function that only provides an estimated pseudo-moving sum. It assumes there was no error in last discrete time window and subtract constant portion of last discrete time window sum. Note that the function is not strictly implementing the moving sum, but it keeps a property of moving sum, which makes the value same to the dsicrete-window based sum for each time window-aligned timing. Hence, people collecting the value in the old timings would show no difference. Signed-off-by: SeongJae Park --- include/linux/damon.h | 2 ++ mm/damon/core.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/include/linux/damon.h b/include/linux/damon.h index 17c504d236b9..487a545a11b4 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -622,6 +622,8 @@ void damon_add_region(struct damon_region *r, struct damon_target *t); void damon_destroy_region(struct damon_region *r, struct damon_target *t); int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges, unsigned int nr_ranges); +unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, + unsigned int len_window, unsigned int new_value); void damon_update_region_access_rate(struct damon_region *r, bool accessed); struct damos_filter *damos_new_filter(enum damos_filter_type type, diff --git a/mm/damon/core.c b/mm/damon/core.c index 3d51a1dfe104..5bc0544b9f50 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1589,6 +1589,46 @@ int damon_set_region_biggest_system_ram_default(struct damon_target *t, return damon_set_regions(t, &addr_range, 1); } +/* + * damon_moving_sum() - Calculate an inferred moving sum value. + * @mvsum: Inferred sum of the last @len_window values. + * @nomvsum: Non-moving sum of the last discrete @len_window window values. + * @len_window: The number of last values to take care of. + * @new_value: New value that will be added to the pseudo moving sum. + * + * Moving sum (moving average * window size) is good for handling noise, but + * the cost of keeping past values can be high for arbitrary window size. This + * function implements a lightweight pseudo moving sum function that doesn't + * keep the past window values. + * + * It simply assumes there was no noise in the past, and get the no-noise + * assumed past value to drop from @nomvsum and @len_window. @nomvsum is a + * non-moving sum of the last window. For example, if @len_window is 10 and we + * have 25 values, @nomvsum is the sum of the 11th to 20th values of the 25 + * values. Hence, this function simply drops @nomvsum / @len_window from + * given @mvsum and add @new_value. + * + * For example, if @len_window is 10 and @nomvsum is 50, the last 10 values for + * the last window could be vary, e.g., 0, 10, 0, 10, 0, 10, 0, 0, 0, 20. For + * calculating next moving sum with a new value, we should drop 0 from 50 and + * add the new value. However, this function assumes it got value 5 for each + * of the last ten times. Based on the assumption, when the next value is + * measured, it drops the assumed past value, 5 from the current sum, and add + * the new value to get the updated pseduo-moving average. + * + * This means the value could have errors, but the errors will be disappeared + * for every @len_window aligned calls. For example, if @len_window is 10, the + * pseudo moving sum with 11th value to 19th value would have an error. But + * the sum with 20th value will not have the error. + * + * Return: Pseudo-moving average after getting the @new_value. + */ +unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, + unsigned int len_window, unsigned int new_value) +{ + return mvsum - nomvsum / len_window + new_value; +} + /** * damon_update_region_access_rate() - Update the access rate of a region. * @r: The DAMON region to update for its access check result. -- 2.25.1