From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0A5EE7FEA for ; Fri, 8 Sep 2023 12:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5596A6B00BD; Fri, 8 Sep 2023 08:42:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 509376B00C0; Fri, 8 Sep 2023 08:42:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4208C6B00C1; Fri, 8 Sep 2023 08:42:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29CD86B00BD for ; Fri, 8 Sep 2023 08:42:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ED774120DE4 for ; Fri, 8 Sep 2023 12:42:35 +0000 (UTC) X-FDA: 81213393870.16.70FE798 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf04.hostedemail.com (Postfix) with ESMTP id C2FAF40017 for ; Fri, 8 Sep 2023 12:42:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=NS+uzqd0; spf=none (imf04.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694176954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ftcfDlLzJYtTTNZ6CKVdMzoar0kugl5/EzZRiB/4Zb4=; b=gNHYc3/l4DTITNLJ9WiPJ5g4d4opDgaOf6B89HWzkNZMAPrDhuk5DzaP2OIdf2tky0yfxJ +1v0bKsBQRCsz2V1TfizwwqerUUh0Wh6GiJ3zN0f6qRZ2/pi66t2n1GP+a8Jl2a5/3YVjp 57mqYecLJk/QFEIDV4Lm3ZGlbhnMjPk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694176954; a=rsa-sha256; cv=none; b=fB2VxO2zPi5FX9T1lifSEliq7r5/7t/Fc1dBHZAMikfpxH0c7+PyH9Mk5esTpEOTyCVTyU dihkk1cJrgqx1ofN9/Ame1BuI0D6+A53EOuULY9vOLgtDsuZSu8T5e/D5VrVeLINOKkzFG ZArNxQzh4si3vOX25e0k6A8rEneJaYo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=NS+uzqd0; spf=none (imf04.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ftcfDlLzJYtTTNZ6CKVdMzoar0kugl5/EzZRiB/4Zb4=; b=NS+uzqd0/vDlawyoCmejFdl/ig CsHSzockNidVQJ+sIyyEoUkeHvebdFkP7KBk1GZVobLbGHS2u4i0T+4PL2hFFCq2+l/S3xto9cAnw AeRhW35iy5mfuFRX2ECxg//HQo4OHbY8x+4hNgFs/muAtMuHPEp0yhITN7fPcldCdoxBXx8eT5MB8 mSKEPVorteiitCJKEZRC4TmdAwngTeGFygIHeNiWXCBDUJL2Uxzq3TvBZtOXXpP05VlqBj4JG/356 ZqvSanl3sXj9RuXjpzVEix1cpK/3mXHVlUINPEsTn4qqRiNERFbpNVUXu55yyygqUyBKAVod/Lv6d +brxrFyw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qeaoC-002WUe-0y; Fri, 08 Sep 2023 12:42:02 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 688493002F1; Fri, 8 Sep 2023 14:42:01 +0200 (CEST) Date: Fri, 8 Sep 2023 14:42:01 +0200 From: Peter Zijlstra To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, rostedt@goodmis.org, tglx@linutronix.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v2 8/9] irqentry: define irqentry_exit_allow_resched() Message-ID: <20230908124201.GC19320@noisy.programming.kicks-ass.net> References: <20230830184958.2333078-1-ankur.a.arora@oracle.com> <20230830184958.2333078-9-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830184958.2333078-9-ankur.a.arora@oracle.com> X-Rspamd-Queue-Id: C2FAF40017 X-Rspam-User: X-Stat-Signature: 153ezpzskqz7r3cd8t9ngr9bxo98bh77 X-Rspamd-Server: rspam03 X-HE-Tag: 1694176953-235908 X-HE-Meta: U2FsdGVkX1/9UUjL7fo26m8Mqjt2HsjBPrYwY6DIP29sYWM6Y8Os0U3LQ+678doh70N8SK0K1vFro5Ru7oqr6a7vLuT7g/pbG1QDtWJ6d+EGSwqjQc479JTDgresKiP7PpVJTRL98wrDuP+SA78FQeWWOrxR9zfQAmWWBn6K1xdgEFa7NmAQhTABFiNAlNnZ47paqRTguzeXuEg6MBq4BgeVvIQZ+69wQQ3J0dihQEsIHpNeRpGjv1BaLotc6AEmjQmf27CzoOrd/P103GbZYmO8NGQKrs3srFXKc8BVLhzv3mw1oGJrbGSLK6azSG1TEH60FUkhu/xgCkphzSja+/9ChbLDwmwqc/nR21SC6pH1bXH3g9wfMivgYMY6xy4+kyfBglPz/WPVwcJuxqi5KRoFyx0uJpLfT6VqswTdAqbOX3uEze+OOIIaCvGebUr5LE9LYxoehmWPYa2pKhJGu0+nO5hitB0vX6XfSqUOxCB3jiqq9/94AaJLwqK/GF+3CeaOMPWIJM3otGsZBBAcf6ry6Y2zQ/K9oWl7NojY3RCodsuTCiIEu+dVGcqm+5U01+Mz7Cd97kOZZPiUVgNVbxVX4EzrHQmEQeVk/dstW+Lqv+787t1BEB3IcN8UCi0ZnJBjsTJHSPOuCQHy/lrFPGVJbLpVyzPt+U/FwjehNKQ0GfAbb5o5MWTbz3rUzqQkK039ngyO9h57u7BiTnF97opJKbwWf0ysuNXqGM1RgI4JIBlBCCxNzUXW13XvpHUsLnxktuxriojwp+HJPpuNzU8Gxsyuk/9bswQycaBonpmtR275iQSw3qwOdL42cUOMhKjq2q5Bc0g4r64OAPJjKV81cVo8nYJb5yXVQR4417g1sQ5sKxuG+uRTdP85/cTJOtZgv0n3Oun0RyCCff5/bU3ZOPg2xHmTVEBPqkvH1BFwXNg8twzHgNYlo8QH4dIgsgViTJAVXwGOAGM8RWG HomMnmiZ WsD6NRWrUM0E1GVCzHwMLiD4jVST1bl/4IA6Q3msxC8jqwwJb5x8qagOEc8DqVRieaXnZ3ZjCdHg6Q8xvM1gmW2BYkaFVEjufVRa2JGMMJBFej79y3neDRBdru9y/UZymDW2FO3MkD4ABZ9YrkrgYyGHRqcG2x0Zi80/1r28OFdnukhF5F/Vr/yDA0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 11:49:57AM -0700, Ankur Arora wrote: > +#ifdef TIF_RESCHED_ALLOW > +#define irqentry_exit_cond_resched_dynamic_disabled irqentry_exit_allow_resched > +#else > #define irqentry_exit_cond_resched_dynamic_disabled NULL > +#endif per ^, the below comments are not entirely accurate, since not every architecture has TIF_RESCHED_ALLOW, perhaps make it: > @@ -8692,25 +8694,25 @@ EXPORT_SYMBOL(__cond_resched_rwlock_write); > * > * > * NONE: > - * cond_resched <- __cond_resched > - * might_resched <- RET0 > - * preempt_schedule <- NOP > - * preempt_schedule_notrace <- NOP > - * irqentry_exit_cond_resched <- NOP > + * cond_resched <- __cond_resched > + * might_resched <- RET0 > + * preempt_schedule <- NOP > + * preempt_schedule_notrace <- NOP > + * irqentry_exit_cond_resched <- irqentry_exit_allow_resched + * irqentry_exit_cond_resched <- NOP / irqentry_exit_allow_resched Or something. Also, why did you add that extra whilespace all over? Makes it a bit harder to see what actually changed.