From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59021EC875E for ; Fri, 8 Sep 2023 00:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C14D8E0005; Thu, 7 Sep 2023 20:47:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 849508E0003; Thu, 7 Sep 2023 20:47:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2D58E0005; Thu, 7 Sep 2023 20:47:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 541678E0003 for ; Thu, 7 Sep 2023 20:47:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2928AA034E for ; Fri, 8 Sep 2023 00:47:22 +0000 (UTC) X-FDA: 81211591524.11.E6A1D2B Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 51ADA1C0019 for ; Fri, 8 Sep 2023 00:47:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=pB6tkf51; dmarc=none; spf=pass (imf18.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694134039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t6+Cb3bRZZ47LN9y3HtMWq4ggj2G/LWgJo6DkgIzUlc=; b=Nzb0aKW2+ReK0OmDJVm6V6asBOEwcOTebOdxtWJwKLz6EIUWVnY0W7yLFg+pkXhp7WpC6b KWQBuTrEUMue7opSnHyAxWaTsas28U8xfdqNq2xB3XULeznpW2mPJQljhQTxmv+3VdpSKr sFSnBRHf3Yuu1gi5zcYdQ1UgX5Wz6WY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=pB6tkf51; dmarc=none; spf=pass (imf18.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694134039; a=rsa-sha256; cv=none; b=mB/D+CxfY9MufVwWmLOa2xgmIDPgCTHYtEK1fn1UFzTBa3oyJWxv3yWAIvEoKdq7Q8NYQI HC7bVChddoaWvW6jR6c+0XHhBN4rpq1G/qfmjlALq9Mz0gJbHOwICCC6YWMS4SvV1iz3fl pmsCAcCR5DH0g9YtPUuvOh85SM638ec= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-34df008b0e7so3946845ab.1 for ; Thu, 07 Sep 2023 17:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1694134038; x=1694738838; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t6+Cb3bRZZ47LN9y3HtMWq4ggj2G/LWgJo6DkgIzUlc=; b=pB6tkf51xn9XbPTOuiw8Z3sByV68LGcqzBLjIQ76KB4MyMFMMuxHY6BYHhLw3Ejs/M utBe3RQ2k7P7JdSa+UEl7Ktf+OE+f0WDHcxUYw6JC1rCLiVHUVH/mX++NimaiiQ+QK41 nAWq4rRRDn01Hb2Ie7n6drKYg0jQ21E27nj7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694134038; x=1694738838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t6+Cb3bRZZ47LN9y3HtMWq4ggj2G/LWgJo6DkgIzUlc=; b=jsL5e3HFdA6rOmBqhyQ9zGRR62ykEfttjQtpmaLzsr+9kqO+92hldjFO9rERMZincV ZedRZXNVSAo1Sc3Rq9yzD1ZZdd/P/RAkjnhJJYBDkI19Y1rJHtqaJ8mlXZeADfjQNupr D92jaJ0atoKjFY2Z6NXN1aBmS+WaE0I44Yy21cSwiWHg5sNgS8k61+MiGrwLeKWUz9gI 18lBMCTYWxC0tT8NVAj4HOhQJw1e5grJPttK8hNIBefuAiDqnNB3tIbNzSgAjAbEb9EF Tx9RhkINW21wX0G3Wrm7u98ck3zHZWMiyZQuWa1wGlz6sxGWjFL48klvfpFRevjPLmXA zzSA== X-Gm-Message-State: AOJu0YzOaysD6w9bXpcxmAMKHWywF9kGTbb9LXVLyhM6cmBhgDFIYkHm 72XGL7vZCZYFuCrCeDTuXFIL9A== X-Google-Smtp-Source: AGHT+IFlR/Sv04z3ajcLWxvVrekQpqo/YeMso2oRkKwCsmdeMdYUZgv6PkHDs2VEqkf0Y0xCQWfyfw== X-Received: by 2002:a05:6e02:1ba4:b0:34f:1e9c:45d9 with SMTP id n4-20020a056e021ba400b0034f1e9c45d9mr1238857ili.12.1694134038520; Thu, 07 Sep 2023 17:47:18 -0700 (PDT) Received: from localhost (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id z14-20020a92cd0e000000b0034a921bc93asm158378iln.1.2023.09.07.17.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 17:47:18 -0700 (PDT) Date: Fri, 8 Sep 2023 00:47:17 +0000 From: Joel Fernandes To: Vlastimil Babka , Andrew Morton Cc: linux-kernel@vger.kernel.org, Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , "Paul E. McKenney" , Zhen Lei , rcu@vger.kernel.org, Zqiang , stable@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Message-ID: <20230908004717.GC4088026@google.com> References: <20230904180806.1002832-1-joel@joelfernandes.org> <49ff5505-5a4a-1ad5-8552-6e79a91ee8c9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49ff5505-5a4a-1ad5-8552-6e79a91ee8c9@suse.cz> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 51ADA1C0019 X-Stat-Signature: yp4cj3rehneadfh38e5sgpzkhq3ezyyz X-Rspam-User: X-HE-Tag: 1694134039-125412 X-HE-Meta: U2FsdGVkX1+W/LildDbDmHLDBawbm+FghHTghrfYw9iuX8OMwHOUvwWPWwE5ODkrcDCOi+ODHaKKB8GOHQR5Ii/Ib4mAe8TW9vHoSxM67oOm/aBkm75FsVBQd95pLR3dNwkCpMIMGzN10pm2jRWZcRJC2C+BjRhYWlMMw5xAXmE0GE7CRJ+ZBu8M4C8FsYs+G9ijbZSl7UG6xPlDimtdUTvXNKxIIUi9qgBBiu2x8h3XYYa3jF9RqGSg68IzyHnW5EjGK170szOns3zjJsd80kohEGsebAglkQNyjDjcOqS/FoarafyJI+SJcy6IRjLBkUXKyoIyrsbauiQ0AtGvbrhT06oNTa9dFkPJ8BbmmOkcm8L/w/Cxy0X5pRqp4Ea3uJxcthnLCg96iDp/H7hIsF5uR657jYPuUxnojaD+9JDNJxktUaQpO23lP07BYIp1A5SjtMX4Bs8zqe+LVucOoj/Jso7cwhvT/W3QfkRn5qOn5h0i5YNXBnUNQYRuHd5P3t7AuDYpAp6LN4ofQeJr+nZYyTXau6+/nei6UL7L+2aPzNALHke6Cm9tAl0XAUQ5aNbyItpf1LiGfs/h0vTMqoyf8nowBXm2VkeI9bzx8lABbkiE1XjxC0ItgiSp383tezZ8uK7CWEA1enRe9itZfjg0fPjU+/wUywRV9lYNgEqmY5/fnOgKSZXX1ARFM1VVRD/HZ8yXIDVDHZllu0kHdtyxBvaZxNuuziZFWLN+8cin2A2/6rfJ818pgyIyIda0igWD1iOaJLAgo7BrnDwQH0XZsq6+u70eDbp26GYgSW4PR8E7oXNzgEKijcqupUOyZqX9sOuIci2z5mVanbkyRveAqmeHjeJ5VvjO6jEvvvVa0u07dhqiqw6WI4xCHeWg2ulj7D4WLZRvUy/9aQ7QYt38dWAo9FQpg5AdPDuYfiOVMCiB/6Zkmrl2nDWh5VIdrVKSBG07YAmAqQ0eXoG /7PkcxbJ vEczU5a5msC7XzalvMKBJ4sOjS2DfC0CCUHAGDWHWlj+IyHjWoBkicelGP4FZQOhskrN2OKbD2GFo74tEvt7sTvLDmzjZT6BkLrJELJiUikn0R6yLrh9NDJhl3jqwa2/ytWkMTP+5eI8yH8ixQrF5fJ3kHloDjUBptHVE1KhPlUozWhObvzwRiJTbcOF7PzV8ACfXrObVJlA4GVDxpIDiMTPb8NnKZjtiWuJgYIm3UoSxOO+PjlgK+BWpxw77DkfAoD7Wyvq3cZCsjLzvhd36x/CzZAo1t8uvh1zSyN06ukJAX8SC3VDGcpz+uu1O7NLkCX6p0TphxYO+SQlV1443HKcziaEMG1TniBys4trhPaAoCtXs6PnVsJNFb7+33caK6Z75pf3a2My2k8WIiitWvExG/7IOTlvxv8ytJWGV648v1jnEc0JuK7zzbvyL8SrQPbmGi972kzUcgJnqm5y2tVTGozVY9pK5X+aoSCCh8w+Z51Hbo6OFJscgBaSxSezz6PRAX1n/2eQ2FgOJ8gKbdsaGQZYFLq9mvC19R61T7UQeHgPr4hiIouVG1mWBhstCBe2Vew2yZc9TJSj93izD5X+fe5tz8fiq1KhJTyCxkI0WQdnt1Pn4HQVBOprIOa9NkOc+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 07, 2023 at 08:53:14AM +0200, Vlastimil Babka wrote: > Hi, > > On 9/4/23 20:08, Joel Fernandes (Google) wrote: > > It is unsafe to dump vmalloc area information when trying to do so from > > some contexts. Add a safer trylock version of the same function to do a > > best-effort VMA finding and use it from vmalloc_dump_obj(). > > I was a bit confused by the subject which suggests a new function is added, > but it seems open-coded in its only caller. I assume it's due to evolution > of the series. Something like: > > mm/vmalloc: use trylock for vmap_area_lock in vmalloc_dump_obj() > > ? > > I also notice it's trying hard to copy everything from "vm" to temporary > variables before unlocking, presumably to prevent use-after-free, so should > that be also mentioned in the changelog? Apologies for the less-than-ideal changelog. Andrew would you mind replacing the merged patch with the below one instead? It just contains non-functional changes to change log and an additional code comment/print. Thanks! ---8<----------------------- From: "Joel Fernandes (Google)" Subject: [PATCH v3.1] mm/vmalloc: Add a safer inlined version of find_vm_area() for debug It is unsafe to dump vmalloc area information when trying to do so from some contexts such as PREEMPT_RT or from an IRQ handler that interrupted a vmap_area_lock-held region. Add a safer and inlined trylock version of find_vm_area() to do a best-effort VMA finding and use it from vmalloc_dump_obj(). While the vmap_area_lock is held, copy interesting attributes from the vm_struct before unlocking. [applied test robot feedback on unused function fix.] [applied Uladzislau feedback on locking.] [applied Vlastimil and Lorenzo feedback on changelog, comment and print improvements] Reported-by: Zhen Lei Cc: Paul E. McKenney Cc: rcu@vger.kernel.org Cc: Zqiang Reviewed-by: Uladzislau Rezki (Sony) Fixes: 98f180837a89 ("mm: Make mem_dump_obj() handle vmalloc() memory") Cc: stable@vger.kernel.org Signed-off-by: Joel Fernandes (Google) --- mm/vmalloc.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 93cf99aba335..990a0d5efba8 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4274,14 +4274,40 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) #ifdef CONFIG_PRINTK bool vmalloc_dump_obj(void *object) { - struct vm_struct *vm; void *objp = (void *)PAGE_ALIGN((unsigned long)object); + const void *caller; + struct vm_struct *vm; + struct vmap_area *va; + unsigned long addr; + unsigned int nr_pages; + + /* + * Use trylock as we don't want to contend since this is debug code and + * we might run this code in contexts like PREEMPT_RT where spinlock + * contention may result in sleeping, or from an IRQ handler which + * might interrupt a vmap_area_lock-held critical section. + */ + if (!spin_trylock(&vmap_area_lock)) { + pr_cont(" [couldn't acquire vmap_area_lock]\n"); + return false; + } + va = __find_vmap_area((unsigned long)objp, &vmap_area_root); + if (!va) { + spin_unlock(&vmap_area_lock); + return false; + } - vm = find_vm_area(objp); - if (!vm) + vm = va->vm; + if (!vm) { + spin_unlock(&vmap_area_lock); return false; + } + addr = (unsigned long)vm->addr; + caller = vm->caller; + nr_pages = vm->nr_pages; + spin_unlock(&vmap_area_lock); pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", - vm->nr_pages, (unsigned long)vm->addr, vm->caller); + nr_pages, addr, caller); return true; } #endif -- 2.42.0.283.g2d96d420d3-goog