From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: [PATCH 1/5] locking: Add rwsem_is_write_locked()
Date: Thu, 7 Sep 2023 18:47:01 +0100 [thread overview]
Message-ID: <20230907174705.2976191-2-willy@infradead.org> (raw)
In-Reply-To: <20230907174705.2976191-1-willy@infradead.org>
Several places want to know whether the lock is held by a writer, instead
of just whether it's held. We can implement this for both normal and
rt rwsems. RWSEM_WRITER_LOCKED is declared in rwsem.c and exposing
it outside that file might tempt other people to use it, so just use
a comment to note that's what the 1 means, and help anybody find it if
they're looking to change the implementation.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/rwbase_rt.h | 5 +++++
include/linux/rwsem.h | 10 ++++++++++
2 files changed, 15 insertions(+)
diff --git a/include/linux/rwbase_rt.h b/include/linux/rwbase_rt.h
index 1d264dd08625..3c25b14edc05 100644
--- a/include/linux/rwbase_rt.h
+++ b/include/linux/rwbase_rt.h
@@ -31,6 +31,11 @@ static __always_inline bool rw_base_is_locked(struct rwbase_rt *rwb)
return atomic_read(&rwb->readers) != READER_BIAS;
}
+static __always_inline bool rw_base_is_write_locked(struct rwbase_rt *rwb)
+{
+ return atomic_read(&rwb->readers) == WRITER_BIAS;
+}
+
static __always_inline bool rw_base_is_contended(struct rwbase_rt *rwb)
{
return atomic_read(&rwb->readers) > 0;
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 1dd530ce8b45..0f78b8d2e653 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -72,6 +72,11 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem)
return atomic_long_read(&sem->count) != 0;
}
+static inline int rwsem_is_write_locked(struct rw_semaphore *sem)
+{
+ return atomic_long_read(&sem->count) & 1 /* RWSEM_WRITER_LOCKED */;
+}
+
#define RWSEM_UNLOCKED_VALUE 0L
#define __RWSEM_COUNT_INIT(name) .count = ATOMIC_LONG_INIT(RWSEM_UNLOCKED_VALUE)
@@ -157,6 +162,11 @@ static __always_inline int rwsem_is_locked(struct rw_semaphore *sem)
return rw_base_is_locked(&sem->rwbase);
}
+static __always_inline int rwsem_is_write_locked(struct rw_semaphore *sem)
+{
+ return rw_base_is_write_locked(&sem->rwbase);
+}
+
static __always_inline int rwsem_is_contended(struct rw_semaphore *sem)
{
return rw_base_is_contended(&sem->rwbase);
--
2.40.1
next prev parent reply other threads:[~2023-09-07 17:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 17:47 [PATCH 0/5] Remove the XFS mrlock Matthew Wilcox (Oracle)
2023-09-07 17:47 ` Matthew Wilcox (Oracle) [this message]
2023-09-07 18:05 ` [PATCH 1/5] locking: Add rwsem_is_write_locked() Waiman Long
2023-09-07 19:33 ` Matthew Wilcox
2023-09-07 21:06 ` Waiman Long
2023-09-07 23:47 ` Waiman Long
2023-09-08 0:44 ` Dave Chinner
2023-09-07 19:08 ` Peter Zijlstra
2023-09-07 19:20 ` Matthew Wilcox
2023-09-07 19:38 ` Peter Zijlstra
2023-09-07 23:00 ` Dave Chinner
2023-09-08 10:44 ` Peter Zijlstra
2023-09-10 22:56 ` Dave Chinner
2023-09-10 23:17 ` Matthew Wilcox
2023-09-11 0:55 ` Dave Chinner
2023-09-11 2:15 ` Waiman Long
2023-09-11 22:29 ` Dave Chinner
2023-09-12 9:03 ` Peter Zijlstra
2023-09-12 12:28 ` Matthew Wilcox
2023-09-12 13:52 ` Peter Zijlstra
2023-09-12 13:58 ` Matthew Wilcox
2023-09-12 14:23 ` Peter Zijlstra
2023-09-12 15:27 ` Darrick J. Wong
2023-09-13 8:59 ` Peter Zijlstra
2023-09-12 14:02 ` Peter Zijlstra
2023-09-12 23:16 ` Dave Chinner
2023-09-08 0:01 ` Matthew Wilcox
2023-09-07 17:47 ` [PATCH 2/5] mm: Use rwsem_is_write_locked in mmap_assert_write_locked Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 3/5] xfs: Use rwsem_is_write_locked() Matthew Wilcox (Oracle)
2023-09-08 9:09 ` Christoph Hellwig
2023-09-08 9:10 ` Christoph Hellwig
2023-09-07 17:47 ` [PATCH 4/5] xfs: Remove mrlock wrapper Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 5/5] xfs: Stop using lockdep to assert that locks are held Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907174705.2976191-2-willy@infradead.org \
--to=willy@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox