From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: [PATCH 0/5] Remove the XFS mrlock
Date: Thu, 7 Sep 2023 18:47:00 +0100 [thread overview]
Message-ID: <20230907174705.2976191-1-willy@infradead.org> (raw)
XFS has an mrlock wrapper around the rwsem which adds only the
functionality of knowing whether the rwsem is currently held in read
or write mode. Both regular rwsems and rt-rwsems know this, they just
don't expose it as an API. By adding that, we can remove the XFS mrlock
as well as improving the debug assertions for the mmap_lock when lockdep
is disabled.
I'd like acks from the locking people, then it probably should go upstream
through the XFS tree since that's where the patch series touches the
most code.
Matthew Wilcox (Oracle) (5):
locking: Add rwsem_is_write_locked()
mm: Use rwsem_is_write_locked in mmap_assert_write_locked
xfs: Use rwsem_is_write_locked()
xfs: Remove mrlock wrapper
xfs: Stop using lockdep to assert that locks are held
fs/xfs/mrlock.h | 78 ---------------------------------------
fs/xfs/xfs_inode.c | 61 ++++++++++--------------------
fs/xfs/xfs_inode.h | 2 +-
fs/xfs/xfs_iops.c | 4 +-
fs/xfs/xfs_linux.h | 2 +-
fs/xfs/xfs_super.c | 4 +-
include/linux/mmap_lock.h | 2 +-
include/linux/rwbase_rt.h | 5 +++
include/linux/rwsem.h | 10 +++++
9 files changed, 40 insertions(+), 128 deletions(-)
delete mode 100644 fs/xfs/mrlock.h
--
2.40.1
next reply other threads:[~2023-09-07 17:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 17:47 Matthew Wilcox (Oracle) [this message]
2023-09-07 17:47 ` [PATCH 1/5] locking: Add rwsem_is_write_locked() Matthew Wilcox (Oracle)
2023-09-07 18:05 ` Waiman Long
2023-09-07 19:33 ` Matthew Wilcox
2023-09-07 21:06 ` Waiman Long
2023-09-07 23:47 ` Waiman Long
2023-09-08 0:44 ` Dave Chinner
2023-09-07 19:08 ` Peter Zijlstra
2023-09-07 19:20 ` Matthew Wilcox
2023-09-07 19:38 ` Peter Zijlstra
2023-09-07 23:00 ` Dave Chinner
2023-09-08 10:44 ` Peter Zijlstra
2023-09-10 22:56 ` Dave Chinner
2023-09-10 23:17 ` Matthew Wilcox
2023-09-11 0:55 ` Dave Chinner
2023-09-11 2:15 ` Waiman Long
2023-09-11 22:29 ` Dave Chinner
2023-09-12 9:03 ` Peter Zijlstra
2023-09-12 12:28 ` Matthew Wilcox
2023-09-12 13:52 ` Peter Zijlstra
2023-09-12 13:58 ` Matthew Wilcox
2023-09-12 14:23 ` Peter Zijlstra
2023-09-12 15:27 ` Darrick J. Wong
2023-09-13 8:59 ` Peter Zijlstra
2023-09-12 14:02 ` Peter Zijlstra
2023-09-12 23:16 ` Dave Chinner
2023-09-08 0:01 ` Matthew Wilcox
2023-09-07 17:47 ` [PATCH 2/5] mm: Use rwsem_is_write_locked in mmap_assert_write_locked Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 3/5] xfs: Use rwsem_is_write_locked() Matthew Wilcox (Oracle)
2023-09-08 9:09 ` Christoph Hellwig
2023-09-08 9:10 ` Christoph Hellwig
2023-09-07 17:47 ` [PATCH 4/5] xfs: Remove mrlock wrapper Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 5/5] xfs: Stop using lockdep to assert that locks are held Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907174705.2976191-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox