From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9BFEE14D6 for ; Thu, 7 Sep 2023 04:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24788440174; Thu, 7 Sep 2023 00:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F74444014A; Thu, 7 Sep 2023 00:41:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09819440174; Thu, 7 Sep 2023 00:41:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EE74744014A for ; Thu, 7 Sep 2023 00:41:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1D2D121058 for ; Thu, 7 Sep 2023 04:41:27 +0000 (UTC) X-FDA: 81208552614.02.60723DB Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf16.hostedemail.com (Postfix) with ESMTP id 52374180011 for ; Thu, 7 Sep 2023 04:41:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="bPhZ/2pt"; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf16.hostedemail.com: domain of jason.sim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jason.sim@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694061685; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eq3aD04zH4Q6fDKq/qjMHfmEleavMO89GLo6g1kQJic=; b=rXbKEnBXWSwVaIaeWdVGwwoLN6i0pLmU9B8DKi+itcSzEZB78s8vBe69qaDQ+jT9asZk8k Kjo8qUS94io/EDRJz9v4212pQZApPWhDBL1PXznB/sOBWNV4/vAxciucgBlonUHaSeijcL GasJKgqss0qB7n6wRHcxxo10EHkOYh0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="bPhZ/2pt"; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf16.hostedemail.com: domain of jason.sim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jason.sim@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694061685; a=rsa-sha256; cv=none; b=D67YgaIVTQQh8gKcJWndW91fJra1Qu2EE/2V2gSvCYG96fl1myWQNNkQ6ESlblTGcRIXM0 pfF9hbj+x5c8fuuvsfYl/7yzvyUeYBzDvJq9gONMfIvzsp2y4oPTmWXbDWa3y5F1FzhQnn bhYNcdzXv8z1Q20n5vAgfnhDLtTGhN8= Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230907044120epoutp019f6e6132c52269723c08f569e288eaf3~ChB9zNnzx2881628816epoutp01L for ; Thu, 7 Sep 2023 04:41:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230907044120epoutp019f6e6132c52269723c08f569e288eaf3~ChB9zNnzx2881628816epoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1694061680; bh=Eq3aD04zH4Q6fDKq/qjMHfmEleavMO89GLo6g1kQJic=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=bPhZ/2ptCo67AB1BUvC4vDWR9E7wEdrFrnl4XJvsD9Np1xxW3OpaZ5zljFcWuJJz5 fdScJoiTk9JisfLV5RXTmUZpejg/lcdbJ+V0ltTpPhoLwMGsLoVFQz0wFzjrsw/tGv K8Iwbm25T57knQDukzl6kWCfbSVkKxIQu3MQtr1E= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230907044120epcas1p1f0e5f63fd8af6fbec9d65f8d3d15c132~ChB9Y7cGs1985719857epcas1p1F; Thu, 7 Sep 2023 04:41:20 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.225]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Rh65C6ZbYz4x9QJ; Thu, 7 Sep 2023 04:41:19 +0000 (GMT) X-AuditID: b6c32a37-39cc9a80000025ae-19-64f9546f6dd5 Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 19.4D.09646.F6459F46; Thu, 7 Sep 2023 13:41:19 +0900 (KST) Mime-Version: 1.0 Subject: Re: [PATCH] maple_tree: use GFP_KERNEL on mas_node_count Reply-To: jason.sim@samsung.com From: Jaeseon Sim To: Matthew Wilcox , Peng Zhang CC: "liam.howlett@oracle.com" , "surenb@google.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" , "maple-tree@lists.infradead.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230907044119epcms1p3ff1dd04b02119ff11b77fe40b4842afd@epcms1p3> Date: Thu, 07 Sep 2023 13:41:19 +0900 X-CMS-MailID: 20230907044119epcms1p3ff1dd04b02119ff11b77fe40b4842afd Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOJsWRmVeSWpSXmKPExsWy7bCmgW5+yM8Ug9/njS26N89ktNje8IDd 4vKuOWwW99b8Z7XYsLKByWLypQVsFr9/AMWe/vnL7MDh8e/EGjaPnbPusnss2FTqsXmFlsem T5PYPTYvqff4+PQWi8fnTXIBHFHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZK CnmJuam2Si4+AbpumTlAdykplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJVSC1JyCswK9IoT c4tL89L18lJLrAwNDIxMgQoTsjM+TL3GUvCAo+Lh2d2sDYzrOboYOTkkBEwkljx/z9bFyMUh JLCDUeL0vy9MXYwcHLwCghJ/dwiD1AgLOEr0bp/EBmILCchLnN3SwAgR15Y4tfIiM4jNJqAp 0XVhCzuILSIQLHFl6mKwmcwCJ5gkbvZdZoFYxisxo/0plC0tsX35VrBBnEBHfLq5lhEiLipx c/Vbdhj7/bH5UHERidZ7Z5khbEGJBz93Q8WlJM60LYGaWSyxfs11Jgi7RuLok/1QcXOJhrcr wR7gFfCVaG79DTafRUBV4sb3P1AzXSTenXrGCmIzAz22bOFrZlA4MAM9tn6XPkSJosTO33MZ IUr4JN597WGFeWvHvCdQa5UlPn67wAjSKiEgKTFhlzmE6SHR8dsEEsoLmCTufetjn8CoMAsR 0LOQ7J2FsHcBI/MqRrHUguLc9NRiwwJjeNwm5+duYgSnUC3zHYzT3n7QO8TIxMF4iFGCg1lJ hPed/LcUId6UxMqq1KL8+KLSnNTiQ4ymQB9PZJYSTc4HJvG8knhDE0sDEzMjEwtjS2MzJXHe W896U4QE0hNLUrNTUwtSi2D6mDg4pRqYGJRMJ2b+6j+iIZK7pfImp1WdWerWzf9+Ck3+8cnz 569c83qJ8n+bnNTEz743U58d1RkXvO7wZMdDZ+QPTej+xlN6w3n51JaJs/R/bjreVxtcZXva WvvSDuWSsFz95hX3m4SMe17c1PwhnmQl903n+6G+o65/y8TspNul0hd+eLWowuPCbOUzXb1G F/Z9fvGQaf2HcpuCetNnXuIlu0MPtv+buNpowsOA/XKTmSrOee6d8LJRVsNg/u3f8SazpN8r MEy+4b5S6WLapoaZ/LdK1Fwy89p1cjb93rlrwoxNjiFshXcVD0Rcm3JjfXh9TvnR+PXT56wL WfKt6EC3TNnb6FpXltuT/36fv+xlgFjvKiWW4oxEQy3mouJEAMNN+NIqBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230907033914epcms1p61c5eed4d34d5c4212436c201f33292b3 References: <20230907033914epcms1p61c5eed4d34d5c4212436c201f33292b3@epcms1p6> <06a8624e-00bb-a332-4271-860847faf4a3@bytedance.com> X-Rspamd-Queue-Id: 52374180011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pkpenggznqgo65sg1en6z3f5e6m7jcyb X-HE-Tag: 1694061683-270427 X-HE-Meta: U2FsdGVkX1/6GwO5T1re9ZLk9gPBoh6DX0ntQaC/4CKnEz4xazvQM/bEuOjGEr7Bju7klnkFbmGm41WFAQn96VDdHvpMxI+guJbLMcyt4ejktr6mfXhnb+U3ekTvGyPg8bGMFhQZBtsFvShbJgYCKaUHtrH9xHhDudnmuO4XkiKAwGdt+lx/4h5cXN/qQBi95PBfhmUszVL6BqrNOirOP+nCceXGJs5M9UWaiUHdVVFOYpTv/kcG2o/bZFYxpbyQfDpdLhqf9M9N8G7s36F8B2Q4ry0yaK35RK89sMGyouUUJfoVq2wlnFArfPl1pv5b+t2GODuM3r7920dIX4hqhgJUzFaKCYNdSvNhngkBr9na3DUGsGN2WoZIpfZV/u3QedMXZ9XUBwZOpsfy4pXfnIdQzfzjgXKMRKg4vVLB0eoZ2Sl/YvtoU29X/uc+8ut0yn57NgSPOLSiQ1WCtDxM9s5xkZBF/wp80Z6gLDrHWycAmbjP/36avRdNmnG3mfxgNtSJm8JM6ORZY/xWHxBiket5xdjTUzlyJ4sNqpPJHyqsspTrAIA5wbsjM50ON3pSKwLiY37nN4UEwz774iUflB95EXdR/i81RTfLXzT7dcH0pyMcgVowe6j+mARmvbcH6Ru4i5AP/N40nahBWMEI04tldktbKnGstVL2Eoaq5qYWl3jmVI86rbdYnAMRZT0VYJ1DrHpDldxDVAzGfxh3HNoDYnaMKxKTZ59KXVGceT9EbclfSuzeT985hU3P9XnhC21awadn0ufdKFRtRNEpJ/t02Oqc3bBK8g7j580JanpE+Hgwx7BrhuUZzR/+hATnW2XRtY7k45RsB9yH3UTY1coK0p/VlbA0I3PdF905ctRuz2DPrgMbJt5FPKbqv3ZV156GVUg9cS8aGoHtFfmf4OYZk0ngY2tUgtmybCPa5IjjIIxFJz/dvV6Z2tCnMLWniX5zkCB6e4owNhfjhWl 6eC/CqtK Jgf9hhqdv+KwzHHs1EiFdLsYTM2m44HTpqQWJN/NcCpPvK9lamU84ZMKMaCURMwMIH0iz+eWpRkwJBe8BwXGYMEen6rQdFT7kVTFOjmHhTnZ3yy1L76nR+2dx9cM0lfsZgwECfajj0ZqeQ7raoCAa0VxTAagqLLZy2iPCo+lQp6rFHqCV3DboWuo3MqAqNznI+sdQRT/UZS6xaqE36LIANZJRFBcOb7TIGUjK8AkzLoDF0Eb8BsXRxq64eu4kkplL7diFeiaQjEK79gFB0xRGVm411Luh1embE2nBXaCPUHsssVldcPAsM5kdr+KJMNhazuXo7g3JvjzwPjdxUH8lCc3HbPUco8IElnIVD5b3FydWRmSDAx+z3yhW5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Thu, Sep 07, 2023 at 12:02:02PM +0800, Peng Zhang wrote: > >=20 > >=20 > > =E5=9C=A8=202023/9/7=2011:49,=20Matthew=20Wilcox=20=E5=86=99=E9=81=93:= =0D=0A>=20>=20>=20On=20Thu,=20Sep=2007,=202023=20at=2012:39:14PM=20+0900,= =20=EC=8B=AC=EC=9E=AC=EC=84=A0=20wrote:=0D=0A>=20>=20>=20>=20Use=20GFP_KERN= EL=20on=20mas_node_count=20instead=20of=20GFP_NOWAIT=20=7C=20__GFP_NOWARN= =0D=0A>=20>=20>=20>=20in=20order=20to=20allow=20memory=20reclaim.=0D=0A>=20= >=20There=20are=20many=20paths=20that=20call=20maple=20tree's=20mas_node_co= unt().=20Some=20paths=0D=0A>=20>=20cannot=20reclaim=20memory.=0D=0A>=20=0D= =0A>=20Right=20...=20but=20we=20should=20be=20handling=20the=20ENOMEM=20ins= ide=20the=20maple=20tree=20and=0D=0A>=20allocating=20some=20nodes=20with=20= GFP_KERNEL=20instead=20of=20failing=20fork().=0D=0A>=20=0D=0A>=20>=20>=20Wh= at=20testing=20did=20you=20do=20of=20this=20patch?=20=20In=20particular,=20= did=20you=20try=20it=0D=0A>=20>=20>=20with=20lockdep=20enabled?=0D=0AI=20di= d=20power=20on/off=20test=20with=20this=20patch.=0D=0AI=20did=20not=20try= =20it=20with=20lockdep=20enabled.