From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185B5CCF9ED for ; Wed, 6 Sep 2023 00:35:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 301FA900011; Tue, 5 Sep 2023 20:35:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B1FC8E0014; Tue, 5 Sep 2023 20:35:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17928900011; Tue, 5 Sep 2023 20:35:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 091638E0014 for ; Tue, 5 Sep 2023 20:35:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C394FC0B47 for ; Wed, 6 Sep 2023 00:35:42 +0000 (UTC) X-FDA: 81204304524.27.10DB9F0 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf11.hostedemail.com (Postfix) with ESMTP id 98F274000C for ; Wed, 6 Sep 2023 00:35:39 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dgS4aXRV; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693960540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=xJai1rKoisjNPpGcPW/7t7240hxBZK0oF0kOxP3vz6E=; b=PBhzrFKn+LOu6bL1dHka+JHZyAT8EdFO4L3tT3RxcelCcnUVroHuhUQQ3cXtKx31Gj9XyA 9gI3B6Jmmr/ncPd46zwvFZe8/QzX8ItMGm5f/XARkRYavN0LAvbBOqKHrA6H5tEpx6jhtD i6x3RPMflch4zALTA+LogxL/fAjLgJA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dgS4aXRV; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693960540; a=rsa-sha256; cv=none; b=oe6woya/eR6OCvUir5yQJqS4jGqdDVzyjXD/gP5Orx5kUbumCqYIeETg2b/ijTAaq0petS AVRHt8n6Aw7smPFRdosC9Wcx128wdV3x5RLx5Ylilf7MM5tCNh5O3cH+VTZuJ6KLqbsrMb d2UPD1Hh/OUDEvU1mIEpSw5oueJIiMw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693960539; x=1725496539; h=date:from:to:cc:subject:message-id:mime-version; bh=5qySARsvlZosY4P9OJqFFblEpNcfQm1UzmvRTfu8Fus=; b=dgS4aXRVUxAR87j63y5R0ukytE/FhY5rsnTdELu7ldLBBxCGiyA1imrD uPD2lo/DZK4RHryqz5CEkTtzP7eUITqi9QOfASPNbxBYV3lFpM36MGo/j F0nqCs7gY2O1h6pTxZgyEK2PNs9txVaeGYZPXJWKvK3J0A67AQt9jWxph VO/5esOHZmiXehHMMtSn6Qa5DSmaMgCUBDi9BNv1BKGkJlnVxEk7ViuIi SqUgkC2njS4AREfHYv+aQthjr3YSCkW7VbQW3xaBum1CS1NwxIvTML5VD RKS0stAxU5WszPmGsDSFIKM94o+a5WoBDxdh7xAnHaiIV+DQAhzWswwbv w==; X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="379652605" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="379652605" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 17:35:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="915066869" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="915066869" Received: from lkp-server02.sh.intel.com (HELO e0b2ea88afd5) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 05 Sep 2023 17:35:36 -0700 Received: from kbuild by e0b2ea88afd5 with local (Exim 4.96) (envelope-from ) id 1qdgW1-0002Gk-1r; Wed, 06 Sep 2023 00:35:30 +0000 Date: Wed, 6 Sep 2023 08:34:18 +0800 From: kernel test robot To: Qingqing Zhuo Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher Subject: [linux-next:master 13320/13985] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292 dcn35_update_clocks() warn: inconsistent indenting Message-ID: <202309060824.qUfQMteL-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 98F274000C X-Stat-Signature: u1ppfwqsgei47jb7yfqcc3a8th76oytq X-HE-Tag: 1693960539-406724 X-HE-Meta: U2FsdGVkX1+YWOZ9nuTix/UWbsS9nF6c/Mt6wORXj/egyzPoU5o8bctLrXkZ8dHDc6M9fLXPQkMOL4G0zAWjKLqrlOP2BBOMznjT96UnMl7136NUpCvMGFum5ATJPqpf4sMVJWtE3BGBZfvD5aSDoKKFuAyckkMNMMzygGwCZ5H+iu/QnCxUxn1HkzW5lzjkO/8T8vbnBcHOdzzWCF3g90awG0QA8FT6YN8va0qVcMZRMdnFS1e04JAyeREdJQ+aF1sWrja7rbgJax06Az/n2kruVxK9KVcPUgUNw4x3tg+De1enu0Sis1HKIXuoMVOXkCN6EPadc8QebZz8mzNQgkrXKyiJFKBz6xup7fg4ex7hEgUQRC7DC7HwiF7tHv6V/AIm3m4VnE0/8G4xNxalkqSrnRV+I55by7GSb4uhXKAg0O9vaMgHjw7g//Y71ICSTJZKoSXZy548by6EDYPxHJ1d/vjJdGKiU9uAf0jjE6QVq87a2P1ufSvxCXj4vFd+b5Xo2OCbq7PzQrWBtbe94/4HMrzHRPgto2QC2NfMd0h2WkEPIIACWi0t3ot/I6Rp2fyXkA2c3VCYQoy5MP0vHn4n8gmegs1EB0HMifs9i9ikQEpMNlwC/f83pX+YAmD1DlFveoplxa/HcUMw+VTlTbqZudNkg+r33xL47evQrPa7Rcyoyrmbnu6/ztMqrv8SGcY2FVMQL+YfW8BFvIqW0oXs3uXYRitr7MYdHZCS67+Yc2WFnxv3X7OmmocvE+m+ZE8eOybahKzii8tSsB7cJHZ4wEUNRQi0vJUgeY5FbT43zS1lTj3uhcj9IiKy0iwKIecW1MptgGdOMvulsMZq9PFfzlGeLKUD/Z+cAETZBnhkBe4dFO52GqKj/gffqku1YKUIS7/d5CW6ceq2naVGliqZ0Elo6FtfKFv2Zme3zvSGbgaBIjivL0N5lbyoUe2XkCxyBGy0gsF/Q2ESYLW G5Cd4FFG MQp6tBWD+Hrg+Czy7d/oA7GK8ac65DC6tTaIvKvbD33Hm+jcniDILP6ER4YYd2VdkgZmlpTYAPU9Rk1TQ1sz/1YHHdrlejLUKi4xc147B+wh6B/P9XZ+gsb2cKUfqQbH29/ysbUapXqARVBke0CAAJJK8qOgjehq5P1zzqweUTV1MhoQjOYO0CZJq6yv4/qSo3Y/SZDu89GejdqGV26MY1kGh5nucQLGvuHvTwEZHZLEH0iGiy+HU/5HEjhf3ejS+kn32w78eYy/6Qx7ahww9ViLyZlvWGBfhknrvCrGDlfT9UhCobZru7/wn6wDCW2ILqBIr0Y56SjKSh8W5IYcUKvmIvqaIa1068smV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: c50216cfa084d5eb67dc10e646a3283da1595bb6 commit: 8774029f76b9806f2f3586bb0502408076767fd5 [13320/13985] drm/amd/display: Add DCN35 CLK_MGR config: i386-randconfig-141-20230905 (https://download.01.org/0day-ci/archive/20230906/202309060824.qUfQMteL-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230906/202309060824.qUfQMteL-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309060824.qUfQMteL-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292 dcn35_update_clocks() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:919 dcn35_clk_mgr_construct() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:980 dcn35_clk_mgr_construct() warn: variable dereferenced before check 'ctx->dc_bios' (see line 913) drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:980 dcn35_clk_mgr_construct() warn: variable dereferenced before check 'ctx->dc_bios->integrated_info' (see line 913) Old smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:921 dcn35_clk_mgr_construct() warn: inconsistent indenting vim +292 drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c 213 214 void dcn35_update_clocks(struct clk_mgr *clk_mgr_base, 215 struct dc_state *context, 216 bool safe_to_lower) 217 { 218 union dmub_rb_cmd cmd; 219 struct clk_mgr_internal *clk_mgr = TO_CLK_MGR_INTERNAL(clk_mgr_base); 220 struct dc_clocks *new_clocks = &context->bw_ctx.bw.dcn.clk; 221 struct dc *dc = clk_mgr_base->ctx->dc; 222 int display_count; 223 bool update_dppclk = false; 224 bool update_dispclk = false; 225 bool dpp_clock_lowered = false; 226 227 if (dc->work_arounds.skip_clock_update) 228 return; 229 230 /* 231 * if it is safe to lower, but we are already in the lower state, we don't have to do anything 232 * also if safe to lower is false, we just go in the higher state 233 */ 234 if (safe_to_lower) { 235 if (new_clocks->zstate_support != DCN_ZSTATE_SUPPORT_DISALLOW && 236 new_clocks->zstate_support != clk_mgr_base->clks.zstate_support) { 237 dcn35_smu_set_zstate_support(clk_mgr, new_clocks->zstate_support); 238 dm_helpers_enable_periodic_detection(clk_mgr_base->ctx, true); 239 clk_mgr_base->clks.zstate_support = new_clocks->zstate_support; 240 } 241 242 if (clk_mgr_base->clks.dtbclk_en && !new_clocks->dtbclk_en) { 243 dcn35_smu_set_dtbclk(clk_mgr, false); 244 clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en; 245 } 246 /* check that we're not already in lower */ 247 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_LOW_POWER) { 248 display_count = dcn35_get_active_display_cnt_wa(dc, context); 249 /* if we can go lower, go lower */ 250 if (display_count == 0) 251 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_LOW_POWER; 252 } 253 } else { 254 if (new_clocks->zstate_support == DCN_ZSTATE_SUPPORT_DISALLOW && 255 new_clocks->zstate_support != clk_mgr_base->clks.zstate_support) { 256 dcn35_smu_set_zstate_support(clk_mgr, DCN_ZSTATE_SUPPORT_DISALLOW); 257 dm_helpers_enable_periodic_detection(clk_mgr_base->ctx, false); 258 clk_mgr_base->clks.zstate_support = new_clocks->zstate_support; 259 } 260 261 if (!clk_mgr_base->clks.dtbclk_en && new_clocks->dtbclk_en) { 262 dcn35_smu_set_dtbclk(clk_mgr, true); 263 dcn35_update_clocks_update_dtb_dto(clk_mgr, context, clk_mgr_base->clks.ref_dtbclk_khz); 264 clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en; 265 } 266 267 /* check that we're not already in D0 */ 268 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_MISSION_MODE) { 269 union display_idle_optimization_u idle_info = { 0 }; 270 271 dcn35_smu_set_display_idle_optimization(clk_mgr, idle_info.data); 272 /* update power state */ 273 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_MISSION_MODE; 274 } 275 } 276 if (dc->debug.force_min_dcfclk_mhz > 0) 277 new_clocks->dcfclk_khz = (new_clocks->dcfclk_khz > (dc->debug.force_min_dcfclk_mhz * 1000)) ? 278 new_clocks->dcfclk_khz : (dc->debug.force_min_dcfclk_mhz * 1000); 279 280 if (should_set_clock(safe_to_lower, new_clocks->dcfclk_khz, clk_mgr_base->clks.dcfclk_khz)) { 281 clk_mgr_base->clks.dcfclk_khz = new_clocks->dcfclk_khz; 282 dcn35_smu_set_hard_min_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_khz); 283 } 284 285 if (should_set_clock(safe_to_lower, 286 new_clocks->dcfclk_deep_sleep_khz, clk_mgr_base->clks.dcfclk_deep_sleep_khz)) { 287 clk_mgr_base->clks.dcfclk_deep_sleep_khz = new_clocks->dcfclk_deep_sleep_khz; 288 dcn35_smu_set_min_deep_sleep_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_deep_sleep_khz); 289 } 290 291 // workaround: Limit dppclk to 100Mhz to avoid lower eDP panel switch to plus 4K monitor underflow. > 292 if (new_clocks->dppclk_khz < 100000) 293 new_clocks->dppclk_khz = 100000; 294 295 if (should_set_clock(safe_to_lower, new_clocks->dppclk_khz, clk_mgr->base.clks.dppclk_khz)) { 296 if (clk_mgr->base.clks.dppclk_khz > new_clocks->dppclk_khz) 297 dpp_clock_lowered = true; 298 clk_mgr_base->clks.dppclk_khz = new_clocks->dppclk_khz; 299 update_dppclk = true; 300 } 301 302 if (should_set_clock(safe_to_lower, new_clocks->dispclk_khz, clk_mgr_base->clks.dispclk_khz)) { 303 dcn35_disable_otg_wa(clk_mgr_base, context, true); 304 305 clk_mgr_base->clks.dispclk_khz = new_clocks->dispclk_khz; 306 dcn35_smu_set_dispclk(clk_mgr, clk_mgr_base->clks.dispclk_khz); 307 dcn35_disable_otg_wa(clk_mgr_base, context, false); 308 309 update_dispclk = true; 310 } 311 312 if (!new_clocks->dtbclk_en) { 313 new_clocks->ref_dtbclk_khz = 600000; 314 } 315 316 /* clock limits are received with MHz precision, divide by 1000 to prevent setting clocks at every call */ 317 if (!dc->debug.disable_dtb_ref_clk_switch && 318 should_set_clock(safe_to_lower, new_clocks->ref_dtbclk_khz / 1000, clk_mgr_base->clks.ref_dtbclk_khz / 1000)) { 319 /* DCCG requires KHz precision for DTBCLK */ 320 dcn35_smu_set_dtbclk(clk_mgr, true); 321 322 dcn35_update_clocks_update_dtb_dto(clk_mgr, context, clk_mgr_base->clks.ref_dtbclk_khz); 323 } 324 325 if (dpp_clock_lowered) { 326 // increase per DPP DTO before lowering global dppclk 327 dcn35_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower); 328 dcn35_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz); 329 } else { 330 // increase global DPPCLK before lowering per DPP DTO 331 if (update_dppclk || update_dispclk) 332 dcn35_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz); 333 dcn35_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower); 334 } 335 336 // notify DMCUB of latest clocks 337 memset(&cmd, 0, sizeof(cmd)); 338 cmd.notify_clocks.header.type = DMUB_CMD__CLK_MGR; 339 cmd.notify_clocks.header.sub_type = DMUB_CMD__CLK_MGR_NOTIFY_CLOCKS; 340 cmd.notify_clocks.clocks.dcfclk_khz = clk_mgr_base->clks.dcfclk_khz; 341 cmd.notify_clocks.clocks.dcfclk_deep_sleep_khz = 342 clk_mgr_base->clks.dcfclk_deep_sleep_khz; 343 cmd.notify_clocks.clocks.dispclk_khz = clk_mgr_base->clks.dispclk_khz; 344 cmd.notify_clocks.clocks.dppclk_khz = clk_mgr_base->clks.dppclk_khz; 345 346 dm_execute_dmub_cmd(dc->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT); 347 } 348 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki