* [PATCH] mm/shmem: remove dead code can not be satisfied by "(CONFIG_SHMEM)&&(!(CONFIG_SHMEM))"
@ 2023-09-06 4:50 sunying
0 siblings, 0 replies; only message in thread
From: sunying @ 2023-09-06 4:50 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, pengpeng, Ying Sun
From: Ying Sun <sunying@nj.iscas.ac.cn>
The value of “.fs_flags” in line 4608 is a dead code
which will never be implemented，because its conditions of
line 47 "#ifdef CONFIG_SHMEM" and line 4607 are mutually exclusive.
It is recommended to delete redundant code.
Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
mm/shmem.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 13c27c343820..be050efe18cb 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4602,11 +4602,7 @@ static struct file_system_type shmem_fs_type = {
.parameters = shmem_fs_parameters,
#endif
.kill_sb = kill_litter_super,
-#ifdef CONFIG_SHMEM
.fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME,
-#else
- .fs_flags = FS_USERNS_MOUNT,
-#endif
};
void __init shmem_init(void)
--
2.17.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-06 4:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 4:50 [PATCH] mm/shmem: remove dead code can not be satisfied by "(CONFIG_SHMEM)&&(!(CONFIG_SHMEM))" sunying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox