From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2214CCF9E9 for ; Wed, 6 Sep 2023 00:28:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5FEE900010; Tue, 5 Sep 2023 20:28:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B10328E0014; Tue, 5 Sep 2023 20:28:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96308900010; Tue, 5 Sep 2023 20:28:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 834368E0014 for ; Tue, 5 Sep 2023 20:28:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4450D160AC9 for ; Wed, 6 Sep 2023 00:28:53 +0000 (UTC) X-FDA: 81204287346.14.7D0A0DD Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id F24A08001B for ; Wed, 6 Sep 2023 00:28:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b="DYo87bp/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=alYRYkGz; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693960130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ObmxTeo2pKCpwdpjw391Ir/pD0MisadzpR+UFQHtjB8=; b=cRgMmTx/G28j8FMZH8pp5u2zWF3S+SpsYaO3hYdPY90vQ4cSveRF/LsYvksAqwoEaNS3Id eJTbf5y37/GgMCAUS1sl5pWn5AeKxV0IZa4xdsWKcYiKHL0inTQ0Amx1MIRrFx4kkQcKcp UKqC0YHK0UI1b4++oqc1o2VMR1wUotc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1693960130; a=rsa-sha256; cv=pass; b=7KfVJtskins5Lk3+0AEmWbCFb92lcf266jsAA1vTy1kzAgu17ecXtxBM9ntLhGLJEi8LE6 kpgM/YfXtut32S5/sdP73VaAo7rfGVp+ojeNxE0TodkUXl1xxpoNW5AFvN8IZZEVRVs4G0 fYAnuD9m79rh5TwgO4WCECMIRJV0va0= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b="DYo87bp/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=alYRYkGz; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385NtLbd027175; Wed, 6 Sep 2023 00:28:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=ObmxTeo2pKCpwdpjw391Ir/pD0MisadzpR+UFQHtjB8=; b=DYo87bp/1r2EksKygso6GgzObi04hU74DvgppycrrJXCOXoQO9IvTpgO1XDtlC/8wWmy ayOEeYA5X6nLFrapkuJ5oKrWHsKQ4nf6FXaNskCJQLmR5Y7e4AhD/FaF9nkcEMet45J/ 5wFCF710mtzP1f8aJLC4vOWwOMo6wKV8Lm8Ovc3nv2NzpdZ9K/w+Mk74vvRZmUmvAwz3 6BKIr/b9mkQCq9GQgSo6W8OqZuUIvt2d+NSxEtZjex2xAFnhvGH0ciozdhA/ygy/IPaL ko0yAIKL2bE0BNrd2K34Us3MZDVP+jqVDKnekh2FGLGz33GWhyihzOvMAEkRB/zBUnj/ rA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sxedm81xk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Sep 2023 00:28:35 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 385MAZUl010410; Wed, 6 Sep 2023 00:28:34 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3suugbr2wr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Sep 2023 00:28:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3NLTt/RVp1ASto8oEXjXPCoNfmFz8fyRfDyjywRSCedKB1/hxe5a7wD/jUD+my+Uxf5HK7Ar2r8V3VJIecTo+I6cFh4j19HW0w82h2+axlbYVEbYo+NNSNjINiH2oVzoUNnJI1yyIcfOUoeS/C2A3eSI7hdIqdXnQsTDwebfKllxfMRl/cEjy85J0Gd59feWh96r8WxuK9jHfGlwylUjpfbOdyWDz3ns5Trb/h9bX9E+vidFVqxsYoDO+PhWWxfPgFAqiPrCWuk6OjBmdgeHwh+c3M0RKLJ8dXt3zdnCHwvUK0DYqJLUtDDTbYaZlgwOXVjfcdQ/gEItRJnS699pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ObmxTeo2pKCpwdpjw391Ir/pD0MisadzpR+UFQHtjB8=; b=HDjcUYxeMISpxY1q6ure5y6F+M64f+JOb39SNvh/QLxLXPYdokGlGXO62UiApErkdsPbPmHgv+lRMS/mQBPEGJ2B5RBBhSOOV7S8bo3OYOaNDehFTxEkp6dqpqPICfiYOZL8FScCaM6RDrACZjGoIXBHpXEfwYWfVzkTv8RIpensnrpo3iD+uWKmG5pMPiG+pRc5OR3sXPVuBMdps/x7YeL0V+C/0648niBLWlMVkVP6ixD0LJkiRy9rw0D6PfYjBCzLzLHyyVhlkafFubwVp8mEzu/PZ8+i/18b8Mg94HZTCCnmjG7//xOhsjapbxRUz8w3IS5+I26tKbKzTFStCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObmxTeo2pKCpwdpjw391Ir/pD0MisadzpR+UFQHtjB8=; b=alYRYkGzNVxBtosuIVi4SaQInMMu4qe97BqjXJVK6ySbSpfXEdaspm+aNnbyEtkGN1y/Wu8X9ay0gM9m/r7qUR+jRiZO+rzu2ZgFM4TTEsUAXV6vgqsCXkY9n3XU7XQk4ZmkNOdG/gC755sf94u6WP6zwEsUrFey4KYKdCFLLIo= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CO1PR10MB4483.namprd10.prod.outlook.com (2603:10b6:303:98::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.23; Wed, 6 Sep 2023 00:28:17 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::58d8:cf97:ae4b:1715]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::58d8:cf97:ae4b:1715%3]) with mapi id 15.20.6745.030; Wed, 6 Sep 2023 00:28:17 +0000 Date: Tue, 5 Sep 2023 17:28:14 -0700 From: Mike Kravetz To: Muchun Song Cc: Yuan Can , Andrew Morton , Linux-MM , wangkefeng.wang@huawei.com, David Hildenbrand , Michal Hocko Subject: Re: [PATCH 1/2] mm: hugetlb_vmemmap: fix hugetlb page number decrease failed on movable nodes Message-ID: <20230906002814.GA3740@monkey> References: <20230905031312.91929-1-yuancan@huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW4PR04CA0306.namprd04.prod.outlook.com (2603:10b6:303:82::11) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|CO1PR10MB4483:EE_ X-MS-Office365-Filtering-Correlation-Id: 761fde83-f843-4b67-b674-08dbae702a27 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 31ZbaHoZgJh8U5np1QI2Io59PSsHRSO73YYz1nytDWHS2WzFAt4g26a/GW7P6L+sscav86tDVRfE2oAlI5dBRdxydTeosG0GRZQ6lOIJtF2oCXJmyhk9vxBVtK3Sgpq/ILlcC8aPc4en/TlHycDxHsBdO4QlosQdRtjTRYmoWjm7gwu0CjB4a85QhVXo5Fk2bqUreC4S6/Tcz8+Xm4ySa2E8BIrziCYQuyW3A+Jf8UttftsSUkLcxZiYRV7fJv5xisAZUEPJ8HzrHVVnFjcX2mvUeM3szku8nUf+0HT7ODvRY/zZxFCpZ78d4CsVPAVgR9WqgtYGGHKDjMVv3sOMiXm74PA3mBH9vWzM6zrSRJ47CT6T3aJwy3wtAYO16VNRoVbnM3d+Zqmi/4n2CrUZuVdZVPdOnr+17IIm9IUx8eWWulZi4CU4B5ajiVxXmQMHJT8+sLrlLT1phCBaEgKdaXdn+ERsQP6Oip8f2+FRaRWlAXvUisJue2k6qlubFGkXjW0TJMUmWnRgtibxyIyJxW4PQMYR1FyY9oqlVBtlFgKTVjrevIeYVtKwkb1cvT2w X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(396003)(346002)(39860400002)(366004)(136003)(376002)(1800799009)(451199024)(186009)(41300700001)(6666004)(33716001)(38100700002)(83380400001)(86362001)(33656002)(478600001)(1076003)(26005)(53546011)(6512007)(9686003)(6486002)(6506007)(54906003)(2906002)(316002)(6916009)(66556008)(66946007)(66476007)(5660300002)(8676002)(8936002)(44832011)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bv8Kzz0Zw/lNyN61znBK2+4772snkFhYI0d5hie4A0haNIzRzTH2C3X/tvQQ?= =?us-ascii?Q?PHebLlWWW23LA8LZIRAUhhm5NoG0kbgG8tZ6lz+3t3lcvhIKhZkRISoYXTA1?= =?us-ascii?Q?G/HAY7DuWuARG4B3edLcZwsqAIGNpltNWHxeHXBXIjp6T0ArMCbc/2n2X3p3?= =?us-ascii?Q?kqlqxxlAqSAVMbWTwmJTFa/HqHOrryABbcBKukpZ0u7bYtI0AGRUjip41qgc?= =?us-ascii?Q?1e2wEflzeQWaf7anI75bEtQ6ZYjIjcwp3X4e1eSqh+BHamXKFIEV4hswBmwl?= =?us-ascii?Q?X057aAsaS5dOlOmojEf/w2FGJU7WYzVH1L/EM+FyOo4KZ8QdznKjanFXHG7X?= =?us-ascii?Q?F9SeUr3iLyJyoayR3r6XtdmTT/7PlpcligoBdKoaGD/AqDLjbcXHhRwMm4La?= =?us-ascii?Q?n/zAm6N56XxLsSnVl1E8ETVJEMY5F/Ywh9m0lHOoPmMzDIHmIU8ax3IBTlDf?= =?us-ascii?Q?ypGDek0PdlUJe+2vTlj5PsmCczr59bgN1O2aY5LqIZ/AAbXtXGEeNOs6sdpu?= =?us-ascii?Q?zxqzdSyos1/NnGSZQYSHLyokb47gWpmGGWqhCeDuJxWwz8ayTEqiHO8uPY7S?= =?us-ascii?Q?wDYTR87gZF6FfHQi+z+Q3Wnq7UfpNxfmNwVDRnsnmF7XU8eseC/A55vCtOLc?= =?us-ascii?Q?1b3aGLhQxpDZO3RnGt0FldF3+U3b2xB/YsWky0nEHX6TeOiazKoyjPIbKXZ0?= =?us-ascii?Q?VSiCTfdyHISxnKOovfNidQwwFFsDT4C4Cw1TmAESvN817Zp3cGQ6a4at1y6M?= =?us-ascii?Q?IUgY6A/4RT10H/tLjNGaxNEFNMZh9pKBKdSkf0mWTz+1yJFN6eCEg+86wn+s?= =?us-ascii?Q?Y+6yvEFeMj50DZxcMa/fgahsQiUa94Y4dmUV3jOeMXxO//M91Wv0+/fcghJg?= =?us-ascii?Q?JkH8s0tiHnisi2KUMObuyFAZGYCvn2G5J1hIaVBi1JlXHVrU62N6XFVtI8U5?= =?us-ascii?Q?MBz41KIxBajM/povgTESRowaniTGK3AF0MsGqw9K49xGqnUKoGMEl1l1pR6u?= =?us-ascii?Q?0BMFWt6yvOePXemtblO+HAckWYmNrBuZ9dGSY9J9XoL2Kv8rd0anv9vSuirM?= =?us-ascii?Q?JHSXld0qlq2cO/IZq+169CqM8CTtQUp9QsIiTgun1f60ycGp2FzpM/+dxEKF?= =?us-ascii?Q?aengXdlopd2WPBCUKx9GIi0yTwjl+x/qpmSqNh7zIrQWelcjjyWnKdywxglT?= =?us-ascii?Q?8Qe5YPMZMeveT4a+ZocLAjZkz29VTBVKAioqkBMiTgchAY25EVleh1bqZKky?= =?us-ascii?Q?DXyGgsyGCr/SfvuEZ5QnlzQyeq0g4xRJehYFCPSRphHQ4NMcW5OK8tcnCdMk?= =?us-ascii?Q?YVoEBaTQE9/6kQtCtI8TG5HvgCp1j0gEzEQsfmvKIM760IL2uYqM9G+WySvb?= =?us-ascii?Q?hF/vUa2nYRpp2ZC5oIVcA1Hnv39oXz/vFQe2nOdWd5wd1Ncq3HtweCtD2pss?= =?us-ascii?Q?XsE2qZlXXR8J4HvA5EcVJI36fFIzEZkyeoN47dIdsWdiRK0wXj4G4dRR7Zq6?= =?us-ascii?Q?wyFsMrKtCsbv/V4Jzq4ouUrRDGCU58OZ0IQ/iROVkFY+vFkxUd3t7cnCGvQ3?= =?us-ascii?Q?5ur+13jI7zliooi36m2wrbWikZX9Dp4qxxsW0rpsjzAtRCwE3lumde31sSJS?= =?us-ascii?Q?/A=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: S1gDPRZuz6k3IXTKpfTHdZCED7WpPLpdSxjEcqJvR3ZzoTvurP/xaoJV1U4tWRYXVYyK9KcKlwzsiNx2EsFMBwi1vo4jai+Y7WtsVwwFwWfjfrneeEtm+6itveAzEY0YjuskXYYhwMc541kZGze2zYDLAgb5ekCIXEYd1zVKeLOUzYWs0fpX8JLXSumrs4Xmge8xWJksT2hZvhoFdj/Vw1Ry8vZ1JJDsNkaWEEVx5t2Rg4BNyKM4MkvC8wkYufm4HGsfWkSrC71/NT/VxXJY9YwMABfJghjwGzEH66mS8VtT6IhG2f/lOLQ60Z2wmvPr1YZQpa9N0ybk+dX2Wx6dtU9qiNTG/Y5LQ4Lm0AletWTk4Pg8aVluyeapiYmCYH9IKm7FlMCDhvb1IWslND7UMJsFX6aQGZlUsVcgog+2labmoeYGgbWr8BPute+47kU++h7egae1ti2jAOCk7JPbknOnqRnA7Iufe3vPJay3wg/33IZX4QKKTL2DVt6n55sm7Xdb8ieAVHq4oD9QCNCfKvbip9QQvv+S3vfg2YONO5j/KbFo0szCkAgLoNgo1UHPziCu9JfwrY1nSPRE/qFTAMn6xlM3ABc4iZH7nRizwB+CuT/nXXWzIJyaOd/0lf3xB2aHtAS/c6VxFXspupon1zyvy03ZCWCn9nY10jzxnULduIDkuUWuE/R1PT32AhHfiS5YVA2DCHz9izYyk49YfFSohsJq+MmyqJv53ZX/hmOgDycBJHAngE6bYbgccxIUGxojEghptcxFUNREDpip8+SHTWE8gcUacQWhWA9dHa5WYNLUYujCa5e5BL1+RYIxg78au2kIBTOXcB6xQcHgPyFTol+/NBdvTeB7boeCfou4CqCmorVjFTPzBmIwTdpLHvNn9fFvfIlgo2Ls34N1UgpyYV4fRzUqQ2sEc5Jzcac= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 761fde83-f843-4b67-b674-08dbae702a27 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2023 00:28:17.3709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rz63/oMJgQLL/smysgD1pN4Ox24E9ZQPPMTatL9nbFRQuocomTVoVTvzDwxlKXKLgAxlyZA6PLxZJzR8ZywpFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4483 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_13,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=892 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309060003 X-Proofpoint-GUID: OoPXrWVhPIRtbF65F-r31P0ynE1nd5j1 X-Proofpoint-ORIG-GUID: OoPXrWVhPIRtbF65F-r31P0ynE1nd5j1 X-Stat-Signature: 6fgan8dedyk3ym3ojidj1sh6fuh3ubjh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F24A08001B X-Rspam-User: X-HE-Tag: 1693960129-499115 X-HE-Meta: U2FsdGVkX1/DJOrw8USFy6J8vOgVDOKFIM2YrAGfzvDkCQJz34a2XkKzfWNS5h7xoNj3tMa2eF/rwaJCKEovOs/AP8w3oQgWVOnOPX+ysIM6W10aYtZ7ByZBbWjwqQ8V8qKfri8z8+1yzwYg986yxMF9DOyqXjsvqgqZ238ZjVuEgDc5Z9OWDGXqnTYzJGIn9vLbDhxvxlkQ9HXcGNuzr/td65vtQi99mEXgt5Oxj/6+z/8mYinFUMoyqjASI0HCwAluPQdNuF2XdxWavlXykjysKtkIeNpU+DM2LvXhqgct/2IyLOP6gxRdLQ6SvOcl17cBFs2dwYF3swPWXaFH4Nf2R8HuAPL3ptqFMM1pzB8ykwup1LFRHZLWl600VHRQS3bycoMRFiQM2nsDCpUHodsWslhGfZ3NQLBoB02xWdOnMlki3YuHAIfS2qif71ATisP3ty4e+unmMMmPcCbIytGbxnHcmtxZ4yc1MERKqGeUwcPsGqA7X8L0XUopQFiLkjuxXjcP+vxCunNI9LbObISxMSnYvZJURGs+Y364jW2JuFMBtS9CLHHDA+Ak42JsfdbjYseUmfJcqIoapp6IEBGupP91F9XZEujipE9GpZSpOT7D8eGksHY3bQEXnSv1DQMR3iEKdlX0hf5BiLc3e2D/ER8Q+nsebOJGVippsY+1E9GtU7QlR2kmPjylFryJWbf723EzEdEmi9iqSN6zTtL26f/8FAL9BegusCqOdwmyVZy2wBosgPdFSNPeM0Rly/U2O3ihBbBhN0mwogDxgDzeiU1HwGkcxaGVEkkVRV6/A7iyIAKrqrxImbUb5f67LsAGFYJvJlTjQ1QERRo0RdRNlCuWjOwucJOCchnGceLFuz9IBLAzycPQ8abk3JhCV9paEYZfZqAFPxejnsRnTnBN6cEr/phycsdg5CzHiMMNQAZ5f0HBQ1D9wgbkrn/UtOkHxXHM73ezwyqdKa/ 48HstAI9 YYsTk/waLX2VONtV+fxZ2u6qfos5eVt0YYRHvok2vEWL/pvMVS+Y/DO9S8R/Iftel8xhDAsKg4wsbld4QKwvOWQEJ09jplfxYcZj3RNydhiIvNx3r2LeKrSN/JAQGs/aFa+TPh3FSosaoiKt/SYJgcxkYW9nlGMYop1QpvR4Y4xY+zTLx/2EtPss2YyW2aNp7sjpJYTMrBU8D1qJkUZGEKYRFhqzkH+ppsv/USDInwcH7lLSr5NEm01f8uJ7SErhz2yPH9Rsxd3JWvHj2IZYzG5TaTpXA2+jUPXl7yzB63MLe9rVbC3lFSmXGMt7u+A0kFf+NnMjgE2TyBbVVU7zzLKmT/PC6qMWIkkuqdB/TaCJUPcCMPvSLJKowtlSfZw5humTx+LSYZS4u3BQyWJ/KsfwK5AlD2O4xRhKkSOBzQKA0ffgf+ggaYU9zsPSpLj3W1kEowf9OyAeQBGdwqncirP+LL+hpwqwft38RG2uzVp+GiR8sxvis/U1vSG8/lZsKII/wFSV8KeXNKazlF4fYjChcMK6ionxS9J2Rvjk4FwArXnAUWxaqQIbBnBIgiR14yeebDs7wWfFfC2QWMfsKYfz3FWcJZ+2SROOvHutF8EbaAJMQrpXYe3Z7Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/05/23 17:06, Muchun Song wrote: > > > > On Sep 5, 2023, at 11:13, Yuan Can wrote: > > > > The decreasing of hugetlb pages number failed with the following message > > given: > > > > sh: page allocation failure: order:0, mode:0x204cc0(GFP_KERNEL|__GFP_RETRY_MAYFAIL|__GFP_THISNODE) > > CPU: 1 PID: 112 Comm: sh Not tainted 6.5.0-rc7-... #45 > > Hardware name: linux,dummy-virt (DT) > > Call trace: > > dump_backtrace.part.6+0x84/0xe4 > > show_stack+0x18/0x24 > > dump_stack_lvl+0x48/0x60 > > dump_stack+0x18/0x24 > > warn_alloc+0x100/0x1bc > > __alloc_pages_slowpath.constprop.107+0xa40/0xad8 > > __alloc_pages+0x244/0x2d0 > > hugetlb_vmemmap_restore+0x104/0x1e4 > > __update_and_free_hugetlb_folio+0x44/0x1f4 > > update_and_free_hugetlb_folio+0x20/0x68 > > update_and_free_pages_bulk+0x4c/0xac > > set_max_huge_pages+0x198/0x334 > > nr_hugepages_store_common+0x118/0x178 > > nr_hugepages_store+0x18/0x24 > > kobj_attr_store+0x18/0x2c > > sysfs_kf_write+0x40/0x54 > > kernfs_fop_write_iter+0x164/0x1dc > > vfs_write+0x3a8/0x460 > > ksys_write+0x6c/0x100 > > __arm64_sys_write+0x1c/0x28 > > invoke_syscall+0x44/0x100 > > el0_svc_common.constprop.1+0x6c/0xe4 > > do_el0_svc+0x38/0x94 > > el0_svc+0x28/0x74 > > el0t_64_sync_handler+0xa0/0xc4 > > el0t_64_sync+0x174/0x178 > > Mem-Info: > > ... > > > > The reason is that the hugetlb pages being released are allocated from > > movable nodes, and with hugetlb_optimize_vmemmap enabled, vmemmap pages > > need to be allocated from the same node during the hugetlb pages > > Thanks for your fix, I think it should be a real word issue, it's better > to add a Fixes tag to indicate backporting. Thanks. > I thought we might get get the same error (Unable to allocate on movable node) when creating the hugetlb page. Why? Because we replace the head vmemmap page. However, I see that failure to allocate there is not a fatal error and we fallback to the currently mapped page. We also pass __GFP_NOWARN to that allocation attempt so there will be no report of the failure. We might want to change this as well? > > releasing. With GFP_KERNEL and __GFP_THISNODE set, allocating from movable > > node is always failed. Fix this problem by removing __GFP_THISNODE. > > > > Signed-off-by: Yuan Can > > --- > > mm/hugetlb_vmemmap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > > index c2007ef5e9b0..0485e471d224 100644 > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -386,7 +386,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, > > static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > > struct list_head *list) > > { > > - gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_THISNODE; > > + gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL; > > There is a little change for non-movable case after this change, we fist try > to allocate memory from the preferred node (it is same as original), if it > fails, it fallbacks to other nodes now. For me, it makes sense. At least, those > huge pages could be freed once other nodes could satisfy the allocation of > vmemmap pages. > > Reviewed-by: Muchun Song This looks reasonable to me as well. Cc'ing David and Michal as they are expert in hotplug. -- Mike Kravetz > > Thanks. > > > unsigned long nr_pages = (end - start) >> PAGE_SHIFT; > > int nid = page_to_nid((struct page *)start); > > struct page *page, *next; > > -- > > 2.17.1