From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64A0EB8FAD for ; Wed, 6 Sep 2023 07:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38A33280003; Wed, 6 Sep 2023 03:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 339DA8E0014; Wed, 6 Sep 2023 03:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202A9280003; Wed, 6 Sep 2023 03:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D10F8E0014 for ; Wed, 6 Sep 2023 03:13:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C2CB0C0C26 for ; Wed, 6 Sep 2023 07:13:42 +0000 (UTC) X-FDA: 81205307484.23.DACDC05 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id B526640006 for ; Wed, 6 Sep 2023 07:13:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vp6ei2Rs; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693984421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YvV8dFMD+nE7wrxySseBQZ4e16Ivjspfjk0A6Z8/lp4=; b=osQu2qHBPvmv/eXPW13Zb8VojwEQofuY4c7tSIgSUCB9J7bknWwEcoO3q3cUQFlMKo98ml E2vflr9gsvCnUEJuUIrA1VhY4Fhc3Hkv7wZ1yFWzCiU+Ncs9CHo72RwmF5Rxo6q4xiY//L C6ettyq9VXtCSMC2Q2BIW77p9mtXaD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693984421; a=rsa-sha256; cv=none; b=hSrSVf4wBmd69mljxCtiLPpB1cKIOPxIGpQ6Ma8A7OTDAHZl522EsRUkEzAVVaVl4titL7 OLhkPD3zgv37ms+VfeqUzPVrK9exhF3yQivt1hRU52OYNa0GWcx0uGvdA1nXkffRHyMwli +VM4NW2NHw6AMn9SIOvey/axOPnIKa8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vp6ei2Rs; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 15D39CE10A0; Wed, 6 Sep 2023 07:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A3CFC433C8; Wed, 6 Sep 2023 07:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693984414; bh=xbpzvOy1GbMdzWOLcnPSwZpXoa52vIob+3+/5L6zTO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vp6ei2RspuPENaYFEij+M8YMq1wAYO5vWV8K2G0JaK+XK4bMI+Tss/7qOjJctjsbA uTYeT8WpQrox9A0CPTkzwD5GJIFAhN0p8aftbPhHGKBq6hEI+9iBD4izW6iSEorkCi RcVX0o+FEgZiq+KVhT8aOklHPxJP0cTkm84n+FC9qe0X1kjcaAJII7+v1PceleftJr m53VU/z+YWsUZgA9RZbz7ns+x90yEpfAtgDwhmFQpbTfpCeAYTj+PB8vAch8KM97PJ bduC+5XQlS+HU8mbqGRJop/p1pkgI1P10lhu4nFLpEwcwhU4aFOPwPrZwbJu/oaBBq d/zAcrFsJh61w== Date: Wed, 6 Sep 2023 09:13:29 +0200 From: Christian Brauner To: Aleksa Sarai Cc: Andrew Morton , Damian Tometzki , Daniel Verkamp , Jeff Xu , Kees Cook , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memfd: drop warning for missing exec-related flags Message-ID: <20230906-eichenbaum-hektar-01140b56ca64@brauner> References: <20230906-memfd-reduce-spam-v1-1-1f0d35facd95@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230906-memfd-reduce-spam-v1-1-1f0d35facd95@cyphar.com> X-Rspamd-Queue-Id: B526640006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3qx1i9t9xi3cnc7cbucppmitkmgihuwj X-HE-Tag: 1693984420-653720 X-HE-Meta: U2FsdGVkX18mv5Y3wqmmkWjUXda1EfC1wBv+hj1tp4W5+mr+rwGovj8JB8Ynt0uLRiXiiEOKZaiz1gF6Pmmsr+l+hNtjm6KN1eEtO1WLeZXfS/5ai70cvjDTNFgjRjPGuVq8+N0CzAVK1krjedsXConfcO3X6kc6rmNjfLYmYLvyB/xv+e0+JVGrygpN/VeW8pGXxoZpFwhIoQiK/hxMtwBivzosMxAhBrJ8sbBVCRLkvTVIcohulE8Sb/BoW/SsUM5EgtBQOyAaxTUNuvtt3gBh8Xdw1gtbW6ZhJOa4fgZX7fgXurq6AaSsWg4X8jWnE9q1YLUEA6ir84lUCjTDro0Xz2NGbT0okUlYeuITeR55il0bP0llzjIqc1aaF6Ts/t9xD95z5VRAq61ofP0E5CND0eQiZUDo2YIPW+2bNDmIJv0jDUC9hY9/v661rJEQufhPIEFPH3SEyzp3VHYWaO67T2voGZEyGFI+dwLe25HSWErpw18OVjpyaIlJB0BxBEwVJIxIUZ7Ehol+XncbKUGPlH71cLrYeGUos0t59NexDmLuWWKv8riNdKj0+rhU+tY/KC7JU4WyI8ji82kB+78K3CRihAzPj8dRZrraDTeFDWr4yOwI7o47fHCk1qFzbCK2opZF49tT99JZp2DehvSkmpJ8syMbmn55ejA5jfZEcZ+ozTOarGl00+5yw1PhoP5GCmDvEGI84ljttMCoTXXmw7AjrhPVRvOo45pI/cONfydrC7lvDQu9UZ+XjmDKLoVozxTHWxZR2YwVVMIFGJ1v5p3qyVcsftv8xqBnfObJxZW8qpyV7gEm9YjIGinfqhvSZgjVkyQWK1vz7JdOK2HPSWh9QGv1H1RhH5ASbB6bGMJMF9/aziAVysk7fcmT4eusi7tjQYRgKQPCRNymq4tbgsqZT9J/MWiwdxsWn9f2kDPaq4i3+96na9AmG8IYxbI0nU+gFt0A2VOqSBf kMScwa+6 fAuGUsxXgZtGHaX5SqVavMTIXstpyZouUFeIuI8cH0sL2gitq1eyQRYh+C475chARLSs5leS/lA1i8Oz51CD3s3+QxxGZ1IzkVrGFFa4E5OF9pvXVgDSNbxz/lQP/sZk6I0O45c1Cw51DmEdscqtPsec7XJbcJqmNKhU5UrP92tD6y4mEUNgfn7H79Qkh5+FqN3BRQgnw7UyabWFVobH9cgIam56JGIXx6mhvYo8IwRHPM9o6TucDnUryIbsCmOr9ZJip8hvsQr4vImKTMSSmGyh1cBx7dK6NvLS0ivkyW/MfOK1fP33FzBylvSOYgRxdevks16sSg8VRK2Eb5nmymTRK7qyKung2aiD7qs1VfXS5HbsCEbrGjcAyCFTAOLn9LbiDYqAhAk5ITx07ggMxyyngyBQZ+lHl7cbe3SB7i7zxkaf/2kMV7yjEoyzR5x6kBjiXh3WdCjHC1PyGM9vlgpavyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 05:02:06PM +1000, Aleksa Sarai wrote: > Commit 434ed3350f57 ("memfd: improve userspace warnings for missing > exec-related flags") attempted to make these warnings more useful (so > they would work as an incentive to get users to switch to specifying > these flags -- as intended by the original MFD_NOEXEC_SEAL patchset). > Unfortunately, it turns out that even INFO-level logging is too extreme > to enable by default and alternative solutions to the spam issue (such > as doing more extreme rate-limiting per-task) are either too ugly or > overkill for something as simple as emitting a log as a developer aid. > > Given that the flags are new and there is no harm to not specifying them > (after all, we maintain backwards compatibility) we can just drop the > warnings for now until some time in the future when most programs have > migrated and distributions start using vm.memfd_noexec=1 (where failing > to pass the flag would result in unexpected errors for programs that use > executable memfds). > > Fixes: 434ed3350f57 ("memfd: improve userspace warnings for missing exec-related flags") > Reported-by: Damian Tometzki > Signed-off-by: Aleksa Sarai > --- Looks good to me, Reviewed-by: Christian Brauner