From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Anthony Yznaga <anthony.yznaga@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, willy@infradead.org
Subject: Re: [PATCH] mm: fix unaccount of memory on vma_link() failure
Date: Tue, 5 Sep 2023 09:12:09 -0400 [thread overview]
Message-ID: <20230905131209.4xacdbisz4hvj2cf@revolver> (raw)
In-Reply-To: <20230830004324.16101-1-anthony.yznaga@oracle.com>
* Anthony Yznaga <anthony.yznaga@oracle.com> [230829 20:43]:
> Fix insert_vm_struct() so that only accounted memory is unaccounted
> if vma_link() fails.
>
> Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> mm/mmap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 514ced13c65c..f8c084017757 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -3278,7 +3278,8 @@ int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
> }
>
> if (vma_link(mm, vma)) {
> - vm_unacct_memory(charged);
> + if (vma->vm_flags & VM_ACCOUNT)
> + vm_unacct_memory(charged);
> return -ENOMEM;
> }
>
> --
> 2.39.3
>
prev parent reply other threads:[~2023-09-05 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 0:43 Anthony Yznaga
2023-09-05 13:12 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905131209.4xacdbisz4hvj2cf@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox