From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD29C83F2C for ; Tue, 5 Sep 2023 05:02:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09D938E001C; Tue, 5 Sep 2023 01:02:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04E048E001A; Tue, 5 Sep 2023 01:02:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57E28E001C; Tue, 5 Sep 2023 01:02:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D39648E001A for ; Tue, 5 Sep 2023 01:02:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 95069C09E4 for ; Tue, 5 Sep 2023 05:02:05 +0000 (UTC) X-FDA: 81201347010.04.DD5CD3E Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf07.hostedemail.com (Postfix) with ESMTP id A07554000D for ; Tue, 5 Sep 2023 05:02:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xi5cl9mS; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693890123; a=rsa-sha256; cv=none; b=IkLMIhSVsbkvcELp+3tnMgDLdFRHIQs5Tw0DncIsVkhca2cNxU4b/TV0jv28sdyuw2yK2W p8Z522MCswa1wmm4F3knZ07kZD3oX1qh3fSZ9WPaltiSl+cIGaPDpc7quyCx5i9kHAcce8 Ix8cGjsmHDAQ3z7ryh1dqYdNhOU2pfY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xi5cl9mS; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693890123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZUzgQhmUcrpYjy4XRQMDJNrGSBxTkLFduYpDV6nXTf4=; b=5aJi7tVpW+nDCT048D5pAXrNGvbkPMWNhrzK99ww384apbAma8OfaAxG3Iyw4piLKUr22w enJZrgQnim3Jl33UUtxSfNbaN4NoWJA5G0sxipGC5ByNk1W99znSlvBscrp+JJzrC+AmyU S5p11erd5bdHfZ+psOqKQ844ECRrJS0= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1bdf4752c3cso10170205ad.2 for ; Mon, 04 Sep 2023 22:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693890122; x=1694494922; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZUzgQhmUcrpYjy4XRQMDJNrGSBxTkLFduYpDV6nXTf4=; b=Xi5cl9mSzDFUJHIuFGLlSBnlKcThtWTECtE5vwRyHKS+FtkvULefClmMXTmV0vo6Be ZENRjj1kxsaVjDSLQeGgJegrMvyI+vItbcguIxGANJq9M6Mc6xE2dCMtiNrB3fJiuxY3 sn9U0P4hktnsrTfpmWnpnbMT0gPFbe11yjMG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693890122; x=1694494922; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZUzgQhmUcrpYjy4XRQMDJNrGSBxTkLFduYpDV6nXTf4=; b=JGth3gPWkgff/qldtwhlhNDVMV3OAyJlk1YZgUWFtCcbZReuEPMoJF0F1bQzACKZgb MS+3Hv5JG+Iv/Oxa8b0djrOW0YZIhTbFhMbANQJEfnlDqr+MPDrK2y6fV2OkVjg7kc7v aiqD0gZbWk3JrhN7kXVioIg4evi08416h/ZZFLZR7V+hH+b4xtCI5IZK76J0n8QlJktg uz4j8VorFDEpnJ1lZ8u1ewkQoRWGedYzWm9HNeWM4qEW8C5jm20O2VEBiI7CeW0sJsqf 9zI5T8CDExf4KCR71dYwBwfhpmOMATyyP56uDGc7vSuWV1UOfUXZ3SdgPRpb0ZgZuepB iJug== X-Gm-Message-State: AOJu0YygyRcbGHMbRWzUiZykYE7xMr0Nh30DbLU5TdzRstjEc6IgickZ T6QzFXH3RlbKIuzVrJKgcyqnTQ== X-Google-Smtp-Source: AGHT+IHg9457MHuGXNN4ZmcVXfXbY1b00sKmCn2j8JB+/PbcADiHRIDBL3G2Fq4BpQboAJ0SD8b4uQ== X-Received: by 2002:a17:902:c94d:b0:1c3:3c0f:3dee with SMTP id i13-20020a170902c94d00b001c33c0f3deemr4069125pla.31.1693890122119; Mon, 04 Sep 2023 22:02:02 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:46d9:d35:d74e:cbe0]) by smtp.gmail.com with ESMTPSA id f9-20020a170902e98900b001bbbbda70ccsm8313006plb.158.2023.09.04.22.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Sep 2023 22:02:01 -0700 (PDT) Date: Tue, 5 Sep 2023 14:01:57 +0900 From: Sergey Senozhatsky To: Ze Zuo Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk, akpm@linux-foundation.org, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH 1/2] zram: add a parameter "node_id" for zram Message-ID: <20230905050157.GD610023@google.com> References: <20230901071942.207010-1-zuoze1@huawei.com> <20230901071942.207010-2-zuoze1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901071942.207010-2-zuoze1@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A07554000D X-Stat-Signature: b8aco1p6ydgas1r17yzizu4z97h7ezf9 X-Rspam-User: X-HE-Tag: 1693890123-401056 X-HE-Meta: U2FsdGVkX1/NynWbbUlaPjBcdUjXw2cA5zkw+YLneXHaITfDQX2aofTRRXVUF4NqYsIzeECJNZEf1v9mjqEwsapU/4g8xrimJ+JCNQ6rQ3at8wNtN5Cg7Vn9rewxxlaz2W6quSgO4ILIpxuDYXo7YeVHpgB3IfdjpWpnEXiFXuFWkM5rz+tcXq6TxgEdR/gcAnRCWGwaGsNNvWovoAcEI3F9w8amyqadsR64BpM9/jbF3zBhmU853uCz0trhEd1NoDV+d2mCTQV1ytHykpee1Qqjdr1UIQFDF0+cSn/L+0C8Wm4DatHSlLcBc4n8zjZdRAsA22Q1Jtfe8txSzyT1ztxt45zwp5joJ72ovmSDhGj3EETRi583eQYvuRvSqcnVbj8UPtjiygtOp0B2i8qYpMwMVbLea97jvxJVN09ymEbErN9aX0V5QFLuVQEDFKRhM0zAqXfXYT5nyXzqrDb3O3OZI2M+a6JydSSp8Q0ldS9E8sNNY/S7bfaKLVaQ5pxxPXUKSmAe6jwMGRZmJV4o08hi0h32PfJQHiC06uk5znjKVdy7vCl7Dz59lWMBzTvFysiHeQ92wNG+WleUHxMJdoEG+uBAP2wfpeBNpHCSQWE+UG792BhpbBuUvDnJMAx80GBzkuVqEtz4Ff96HSOo5Y/NSBmmxg8WIi/DTY3whZV+kVo4iw/mJPkLec4w/omFTgvh0MsvzeueNWWbtce9AoFnxDmhntVBU2ASGkNXbBuk5mxzIIBH4eZsQbPSx7C/ZNqVTnf4hhGwTxgA9MTWkKxBvFC+gaZ8lcnJTyC/onFJVcBgIUIfncbcwJV5IDmGJsMKoFjuKn2Eh7zL7WEW1mEcgGzzd5dvnQ/F8H/s7u5ClO67H3qAS9VCrYuZmmAaejweASqJNvTi0PNaYdSZhu7xIh4kZoNJi6owZc9tiD9W2UTAbABCO7+8l3zAkFzwBZxY41bw9BkGoPY7Ymn OwmHGRV5 +CxnYQY1CWuPPrXBV1OmZOBfmS6aB5wxj7LwOa68JHucwhahdQKx/D5fjhD4zTgKTT+ngonymf0NJ6w4/YUXRMW1DLCdYxv4r1PmFnM8dBbkcTHPRnlicv3p2cqsFP7ZRyxpt5Y6IV/CHQrBriuiRYmnrhUDRRwVOC68o5kIBDWI7ncRzHSy9GG8B2sLt1EGG5clqftWVXkUfipwo+64yV7/tNOBXjCmYtWtNxCy9/GTnbpLPhkP+kkPRU3Dnee8rpyhLqc4QEbV4zCqzATp4QwSR4a48K5DsneYc/CUtHQxmARwoldZzV0YkkwXOV83bnmELTbrhA3ruxIiq/vcuJuwung== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001458, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/09/01 15:19), Ze Zuo wrote: > Now, zram memory allocation is random, however in some cases, specifying > specific nodes for memory allocation for zram may have good effects. I'm sorry, but that needs benchmarks in order to be justified. > In addition, when memory tier is supported, demotion can be achieved not > only through page migration, it is also possible to apply for memory by > specifying zram on low-speed device nodes, such as CXL memory devices, > and compressing pages to these devices through memory reclamation to > achieve similar effects to migration. zram->table has nothing to do with zsmalloc pool. zram->table is a fixed size (it depends on block device size) array that maps block index to zsmalloc handle. It's allocated once, when the device is initialized. Compressed pages are not stored there, zsmalloc pool is a separate thing. [..] > + zram->table = vzalloc_node(array_size(num_pages, sizeof(*zram->table)), node_id);