From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BA3C71153 for ; Mon, 4 Sep 2023 17:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41A418D000B; Mon, 4 Sep 2023 13:44:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA138D0001; Mon, 4 Sep 2023 13:44:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8F28D000B; Mon, 4 Sep 2023 13:44:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1D0368D0001 for ; Mon, 4 Sep 2023 13:44:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E89B9B378E for ; Mon, 4 Sep 2023 17:44:39 +0000 (UTC) X-FDA: 81199639878.25.3AA1301 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 54D5340014 for ; Mon, 4 Sep 2023 17:44:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DUaW/2wf"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693849477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v1ek+FZYoZA1DpwC7cW3tnaZdn9k8LE3pdLiKXyZDEc=; b=1EX4oK4pUSP2G9r0ZrdWLPV8Oyscv/1Uq3E1WNXuHrxJPRnVsgmrjvC7/UX3KZzlHNiZEe s98nqMEijR5Vy4+htKciIKuuATXSUUATYU81kbSfE9W7MvLIicdke8JjNJWy02riwJLaNN GzwSy0/gTqPjBypC/zjWHANzNiK+QBA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DUaW/2wf"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693849477; a=rsa-sha256; cv=none; b=d0aB50qUlam4C3sazHn9NP5LWx9Z2V18TzuePf6GLX1H2fwk6483Y7ZLR2YV5FcDLin/Jb yDPnfVLOxyJBapnFHGpAmWDZBQzAMGZ00popKjOjLRX5bXFRWoCEaq4r8vMK+Cqa5HFG9D qFVdXOGJKzh0XryvMYbqfD76aD33GRE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33A1D60B6B; Mon, 4 Sep 2023 17:44:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF822C433C7; Mon, 4 Sep 2023 17:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693849475; bh=YvrmulUiFFn/NobkUjd6sOl1dt0QMsFH5NPz/lhd9Ak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DUaW/2wfixpVSCoxOkzamyqusPm1ayWPvKAYivsybGuMUieEjwCwHuqEdL4Fpo6wb eRjw2NElkfQ7PdK+XJE4HU08dbDA4KF6yUkGnvgWB7/mA0Ity95eh6TzeR6ue8oJw1 OIlqHYVBg8XuTINrjEMJCZ4SdNmfbM2l7mrx7Q0jFDmTsI0Rf0JcO1GyvwESkcNy4C Z/Z9QBNFBIH+cY2eorlfSTYf8IzBOB7DXKlGoVoVZ394DHjQK7eZVJq1uMjp2UV6GR kWTGzghngoM1U9neksj/nvyCwv3fIuzqR03RrQDsEKyDLhMMfKp4k1h6gWzWEw4taO scTpMEFunrAkA== Date: Mon, 4 Sep 2023 20:43:50 +0300 From: Mike Rapoport To: Guenter Roeck Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: [PATCH v6 26/38] sparc64: Implement the new page table range API Message-ID: <20230904174350.GF3223@kernel.org> References: <20230802151406.3735276-1-willy@infradead.org> <20230802151406.3735276-27-willy@infradead.org> <2513a500-920d-4e32-8231-f428175c7182@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2513a500-920d-4e32-8231-f428175c7182@roeck-us.net> X-Rspam-User: X-Stat-Signature: d4pbg3bpgjzea1kkmmpiq3bxcnrrdk7e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 54D5340014 X-HE-Tag: 1693849477-645971 X-HE-Meta: U2FsdGVkX1/eOrg0QeQpa3rSuXzfH0AX8zSETVwOpIgn8g8AvU39B2UhdBsUHqF5RBHuBq3DSPJsamFDzZjTRKfOcmWCO2Hahd7z3f8mDZ2C6HAvyjuaXNkSZ2iutj7IIoePFeBHmYdKD1zT8HIRH+SmFljJltLo5rUyGVcWWkUX0RlJK0qMjE1bbP8gCbThyr5ROCcSYwPLCxUDGnmf5a8NDj22dTC/SFV2nx3lStKSlGCDMZN+erOXA4uFcQxpE+yjH1pl5DR3tbanaAtZ+zKUZ3tFC+mK0uOVQAQzSa7ynLoOVPUGIP8n8VngwpC9zdKhPYcsSI7lGHsXAx1Tod7lcughpL2geJLd8ZfDUyhHx/GAsvWHkMjv/l27c/LyyE7PJiMB+U/rkbarFpEcRsajeq69m80GpBFA3BmCoWuH9Wz4rpULQ3dOWM/QnV6dZ6yfByV9LNs5bLBT4Haf6o/k6XEpt1F3E78pYbu777+vdxKZiPYHGnLEBzXvK6I7pzD0h3LhQ3C+TyzceN7fKwGmYD4Q+3QzUxtvrMjrFmf7gFxgTpi6CGDJ2hqPPuIE/tg/AKz81Fo4a7yq0zQzVSe9ik2/LH0evKJcGbLsXZ9VdrdJDEfowZI9nqkOz1z9CU+ow0gTBWdgmiKRPbJ+/bAKrSbuigSnrojixsxAddvkzi5cfgcjkroxcHVzqLz3XYTZfGbxvt2smv3oTO+3LYDwOlIWkniRgsMCRL+bLknOlXeiQtZxCJ5LTNDDYujwgTRGnGxRuM8R8QiasGTAfU+mLHYGxllFpIeiBZ73/mhBEdj2EH4qzVUVjiaf8aBazlpgmguXa0D/Tu1/cZFeS0Klv2weX23V1nHRtqwXFV/SQPIFqYDIPbTFClTYstImtduqg/6r5rJ7NhVanhXUH22ngfJp4stlDHf8ZVUCk3vNfBLkqIG37wQckZ6EC+zpQVnv68lLVtfrBt4Edmj DyDyyAKr vzGx59pVfZPgVA4P5SzW/c0GmMmileugHvJFVMxJoJ/HNWjmGAuiBA73jdsT7OmldMuW/RPhi4xBS9nZbrLUUgo5pJKTglb6M2v4i6OlXf9FAmCubm1jLlAyHPsfJqKJ4QSSF0ezJ+74YdZJiVesqLYFNSwnmfaTkgYvzGjEji5EG5uN50kHa3uFuXG8cPT7ELNx5yvY/y2Ixp1Ul1THaYklhuaA+KtLyY33xhgZCwVNvsVzQy++bOb5cuz4dPGviFPcpZ01Xl0fyreUpaoPpHzaoXPDbiQ8s7X0QCJv+DiXbArKj7WzzJmDb0h5rDmIDXUVUkvL9LdAnEbmaEETweU8o5UDkAQLSkz8+RfPax/MxPyoCnfGqMOharajVbe2n6sgDfqbwIgCZWZu5SoBXBfQYZU/hVbjWZAIa+onXnXpojzbvOdmCuvdSuSolq6wwaMcvOSqBHDqUr7P+/laGrJsigu6/xivRgn7A6eeRh15kM+EyswwBB72hwjh1Hs3qE70WOcvDZHwnOKI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 04, 2023 at 08:36:44AM -0700, Guenter Roeck wrote: > Hi, > > On Wed, Aug 02, 2023 at 04:13:54PM +0100, Matthew Wilcox (Oracle) wrote: > > Add set_ptes(), update_mmu_cache_range(), flush_dcache_folio() and > > flush_icache_pages(). Convert the PG_dcache_dirty flag from being > > per-page to per-folio. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Mike Rapoport (IBM) > > Cc: "David S. Miller" > > Cc: sparclinux@vger.kernel.org > > This patch causes all my sparc64 qemu boot tests to crash. > > [ 4.890744] Unable to handle kernel NULL pointer dereference > [ 4.891273] tsk->{mm,active_mm}->context = 0000000000000001 > [ 4.891475] tsk->{mm,active_mm}->pgd = fffff80005452000 > [ 4.891660] \|/ ____ \|/ > [ 4.891660] "@'/ .. \`@" > [ 4.891660] /_| \__/ |_\ > [ 4.891660] \__U_/ > [ 4.892116] modprobe(45): Oops [#1] > [ 4.892555] CPU: 0 PID: 45 Comm: modprobe Tainted: G N 6.5.0+ #1 > [ 4.892949] TSTATE: 0000004411001601 TPC: 00000000004565d8 TNPC: 00000000004565dc Y: 00000008 Tainted: G N ... > [ 4.901535] note: modprobe[45] exited with preempt_count 2 This should fix it: >From 8181d1f582a309b51fe4cb02a783628257b91c86 Mon Sep 17 00:00:00 2001 From: "Mike Rapoport (IBM)" Date: Mon, 4 Sep 2023 20:37:59 +0300 Subject: [PATCH] sparc64: add missing initialization of folio in tlb_batch_add() Commit 1a10a44dfc1d ("sparc64: implement the new page table range API") missed initialization of folio variable in tlb_batch_add() which causes boot tests to crash. Add missing initialization. Reported-by: Guenter Roeck Fixes: 1a10a44dfc1d ("sparc64: implement the new page table range API") Signed-off-by: Mike Rapoport (IBM) --- arch/sparc/mm/tlb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c index 0d41c94ec3ac..b44d79d778c7 100644 --- a/arch/sparc/mm/tlb.c +++ b/arch/sparc/mm/tlb.c @@ -128,6 +128,7 @@ void tlb_batch_add(struct mm_struct *mm, unsigned long vaddr, goto no_cache_flush; /* A real file page? */ + folio = page_folio(page); mapping = folio_flush_mapping(folio); if (!mapping) goto no_cache_flush; -- 2.39.2 > Guenter > -- Sincerely yours, Mike.