From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF1BC001DB for ; Sat, 2 Sep 2023 22:58:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 634018D0017; Sat, 2 Sep 2023 18:58:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E4278D0002; Sat, 2 Sep 2023 18:58:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3E38D0017; Sat, 2 Sep 2023 18:58:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 39F9D8D0002 for ; Sat, 2 Sep 2023 18:58:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EF64E801E6 for ; Sat, 2 Sep 2023 22:58:56 +0000 (UTC) X-FDA: 81193174272.06.5A5A87A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 239EC40003 for ; Sat, 2 Sep 2023 22:58:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="uWkk4/92"; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693695535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GasDrvc6W3jC0nPuH+NLVlgYduZUFueUAVu7PupFXWg=; b=irWEXIioWtZ52cgETVpTrG6BhZmsUHe0m0AdMlKAcxG6ICUb2q5p8TMiGPoJd6vJEoeixe hw4xKglt7v1XaPDR+jj55j9DTCkQlO5Y4OjazYntyxG04p5pyEPjRkAx0ay4+k9Rmtksl4 t0qXlMK1k0q1pQ/ZRw8MbLssHtUNu04= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693695535; a=rsa-sha256; cv=none; b=zQQthJvrCp5Nu0Pxu+CEGC13RVThZrQSwTmj5nEtFzq2yG6IGd841zmXkF7Fp/uxN80MCm kx1PfmuZICoQDWrxe9/EBivwRt2XoWZW8+LYMcfcqKbeHgR2zKEIjs7+MPjjISh4uFSbJ2 lRhzGUJuEpeH+CEWEyO4Oi9UIO/Xwm8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="uWkk4/92"; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 954C2B80957; Sat, 2 Sep 2023 22:58:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD5DBC433C7; Sat, 2 Sep 2023 22:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1693695532; bh=Pc7GpWIHklekXAoIIEgvXTBTXk0POLNq+rx6i3iVkpk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uWkk4/925oGsoUT/g2nfGusbL8Se07i/a4cb8oypyPMgWKTz1VKBLf34/LqJCxEM2 eQf44uz/MUwsaZPVMCDL3/y/oCeZePc/HgtNCGU8tQlQQEt2fWNZ3jdhQQSueCyhV/ VL+4t/bm5/BaCWpPLvOwKFrMUeTkTvA3O85omhwg= Date: Sat, 2 Sep 2023 15:58:50 -0700 From: Andrew Morton To: Damian Tometzki Cc: Aleksa Sarai , Shuah Khan , Jeff Xu , Kees Cook , Daniel Verkamp , Christian Brauner , Dominique Martinet , stable@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 3/5] memfd: improve userspace warnings for missing exec-related flags Message-Id: <20230902155850.ca1d32c16862cbe54ebd36ef@linux-foundation.org> In-Reply-To: References: <20230814-memfd-vm-noexec-uapi-fixes-v2-0-7ff9e3e10ba6@cyphar.com> <20230814-memfd-vm-noexec-uapi-fixes-v2-3-7ff9e3e10ba6@cyphar.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 239EC40003 X-Rspam-User: X-Stat-Signature: gya19momkq4ac8igjgtr3htiufjja3uz X-Rspamd-Server: rspam03 X-HE-Tag: 1693695534-207613 X-HE-Meta: U2FsdGVkX1+L7tF7Mj/LiEfbFFDHxRrBXU3hf/pxoC9ZIAJUH5r9/vwWwT0u46IYzsU9MXSOf3Q1sBrFPZAkdOwti1SD60B5N+mRi8L5fmnhrBk7P7J7vdi5Pi6fdDC2dqUx/6b+xvaDnEjuAHfgJlHtnFY1PH/t0iKzKyuTNBS3kuLfTJXpxI+6QCjVVcSRJJOGOS8PejA7brUbnaBQbT+ftHaKI3657LyKMshSJYXLkGByAHr5bK9lPLg4fPGzs8USUdKnXNiyJP0rha7T+wF7RQwJ5DH5qmKcNdcD198NAuNm+wxFFMW48KrjKtCIzHlEJuJkGJzLqKdX1VN6dAnmhk8WZJuRl414ADHZW9qsCXD51T1EF5IT5EGgSIvOfFr+A5LTBSdpkI7bYb1dYm3vg5S5aqKmyNF7VFZlaIGYmV4wXxFM1Cs/5A2gVSTz4u4AswmMBGxJXZHUaEXIUiafyvDcmONtjbomfJML4FK292WUKpWvz59r/IMQ3WM67V25zTxGR7rB2ICTkSWpXvsEdTwHYx95HpI9CobUn0lHhbdPZqwKGKqBxygoCcXf1ilBg2lFl5ZMdFJQljpAMXGlG2r4R5D9ie8c3FzWcZEpbRuBJVuEVMLtx1/Z8+pyRAuj6ub5sO64G3mR83xCAPT1fR+tWL8xC70jVBFSsvG4sMNm+YIYhQwqRmUT9t0MqydBmdBpH9CazO8kL2YD+UhMoacUnngalTewdm2aquRZJRTqO5FRHOFcH7HNxXPhYlY7HPVR9ehTE6rU1ssdZN2DqOVE4mRddhypBNN0NQtGl3P68j2/2GFCtGMQr3yYOOSD7liLe777e2iyeWJ6z00HOFwuy1Xi4cdRGRZeM/DIvaA/7W5SQx/+jxnbElMK/S+qhp0ZQKLpwFj5LtkJ4nLxlHTmYOByQi1loHukoEm/W8lR+we1g6gzf7PN3umjmLcfFc2qctjdw9l0uFJ oVH7Zu6q Mq41EacFMyGAPD7mLDPrMzifFmQcGXnAhAyUB7rgqUb5vrCCs7wjopsSRSgoPLYENCXpYCUhH8CDLkTmHM86Svh2aT619KrLmdTPoVVJ11+c7jVsnwos0kKCsoguGw9OqqnfrIdNmUrSyDvbITW4wTZ6DcJcsAO88cO6xvbvszbTUgNpgbxbLTYOreuDr6GEFkt4UjJ1A8A07NMRv5OO/AwN53fyQq3gI4VtSyn9GStMVUla2kWtxdhzB2fO2Tsm4taPrbemnG6IzwsN9Rvc0DgHb+MwpEREFDVMz/5PdJD+BnyJfBerExaku/W6LlSHsHn9H3sGDfZVcgs8aXSrxRpPVwAqq9vj6JRhED4V9HDi6sCUUCPyhJsfg6PaZ8oADsZAv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Sep 2023 07:13:45 +0200 Damian Tometzki wrote: > > if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) { > > - pr_warn_once( > > + pr_info_ratelimited( > > "%s[%d]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set\n", > > current->comm, task_pid_nr(current)); > > } > > > > -- > > 2.41.0 > > > Hello Sarai, > > i got a lot of messages in dmesg with this. DMESG is unuseable with > this. > [ 1390.349462] __do_sys_memfd_create: 5 callbacks suppressed > [ 1390.349468] pipewire-pulse[2930]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set > [ 1390.350106] pipewire[2712]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set OK, thanks, I'll revert this. Spamming everyone even harder isn't a good way to get developers to fix their stuff.