From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02F3C83F33 for ; Sat, 2 Sep 2023 22:55:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B897B8E000C; Sat, 2 Sep 2023 18:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B11DE8D0002; Sat, 2 Sep 2023 18:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2588E000C; Sat, 2 Sep 2023 18:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 886D48D0002 for ; Sat, 2 Sep 2023 18:55:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5971C1203A5 for ; Sat, 2 Sep 2023 22:55:36 +0000 (UTC) X-FDA: 81193165872.01.A5D1068 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 66857C0014 for ; Sat, 2 Sep 2023 22:55:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lfA41V19; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693695334; a=rsa-sha256; cv=none; b=Uv59U+zPPz4ElJU4CJ3D7ZwITnyJM+TzWjYCYx2K7CeUDUwBGhI2Tiba5QsniS8zrjKj7n axx1sNq123F8T2xla0fcaZKZfzq1c1DfHpsztmQKfZpc1oEtYuK5ux9Bt6AXxfn+YPNsqX Jn4M4WJ+tzhdEoJp3S5qEkKrX2UvKqg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lfA41V19; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693695334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OWF9t7++T3EZDEGkAYGgvD1qn9hyCFJAK9wBX28WAOo=; b=abP0n3OPpeX/gGS3rJ0iNLl7ywk17liUoRMt0Ohevao7Uu+N7wVjuyKhrSJYIBK92WRSKs 85iUxlFDXe/KHz1NHTLMWb7vfl1/EqV6jzyueRZnl17dUzKctr7uK6fr1wlq6G0NHdad5z uIXSRWg+iO3jPTDEnWaj91byduojslw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8004CB808C9; Sat, 2 Sep 2023 22:55:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4E8BC433C8; Sat, 2 Sep 2023 22:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1693695331; bh=pihSQW8CJUH01a8SNi5TsadWucjrNQIZustgBgJrkgs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lfA41V19zanFLGj5+kq10lX9sBYrQQBLdY6in/Pi4uc6pYiYSKbawjWmhpupgbIDc 6WZ4C9ec4kyLWYMHsKVmMKcJuocCP+nsJMJzf/sRjjPrb9Mz1aVJIRF/LQ3TdjGoXV lgX4m6IwJJDEQlPGSTeNcYSWi9UffMnphQn1Jb7k= Date: Sat, 2 Sep 2023 15:55:29 -0700 From: Andrew Morton To: Ze Zuo Cc: , , , , , , , , Subject: Re: [PATCH 1/2] zram: add a parameter "node_id" for zram Message-Id: <20230902155529.61384b25aae68abb9c262552@linux-foundation.org> In-Reply-To: <20230901071942.207010-2-zuoze1@huawei.com> References: <20230901071942.207010-1-zuoze1@huawei.com> <20230901071942.207010-2-zuoze1@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 66857C0014 X-Stat-Signature: r6h3djqitt616w9x9y478uu167xgeiwm X-HE-Tag: 1693695334-712789 X-HE-Meta: U2FsdGVkX18qvLIBRzsai2iyeum0UFouwTiP4WB1XgOjC+y/PdVY43m/WA7717oHeaEWtSGo1Ymq+5o5QhbUCjdl+b2q0RPdYuYO6ZWB3A88BZTzJW8z4CjO8jN43LYPz/PEYVdwueXCR85Pzvk1p/ckqc4avVoOVUSNx1CqufaGYhS+fhvidGLQi0WmeT0BCBSrvW1qT9erYHZPLJZqz6Z5f1aNepK6YLzDJRUzJT072BiDu9AHzrYn2YKpcG8cFuqCJxdXPOPuEKtrjRPKdeNVO4HrHD9jGLHtHdH/ge2iFYOm5Dxt/QIMeaq/uUZBJctxJZanGLssyFWTa10ZZmau+UXwG7X5z57X9TlIW3LbK20dP5Hn9FzZtoQ+U/X2pCBqS9X9HZNBHYkxV0mRFIktZikgdL5/zUOJ1x3qWWhIV2WuP55fIUtlSAq302jp0s/lC1EhPvbPFFDVtFPVRGpPu6aUIVPtYBj2gFeSPzM/8lQJ6exFlY9lIP8p27bEz2BWu7gCovh6bFFAob7Q50ace25Je7bZKwj2CpBETi0IrV8zYhKUIUoPOgsL/WgxXc6X02AAA6+5lTdPQzcT4YiE8NXHvKHRXp+VAV5WiJmOBf16W+aCdXW+1tVpdgqCwkS+oFAFdW9HtUuVXbqYgy1Bm7uoM4UDyxXn5M1blRa/WWHglWRqVa4ESERgX575/lUCKif9QwJRgN8n/F/nnWgpuweeTc2MsnOlUPyYkjSQmNXBlSRYs/4VUuJoH0BjkEa2bZ8T4m4SgmZimzbuSfGW7UzCxJabfk7iGbQLTaOtB07FtznQZCtIDcSQbDblJv69h/mQm7CN+WR5hQLzQOqLNZDdplPU9dD6E3yKLIxJ1YENaL2EjsT8//O9GmtQ46cTBycF5AX95cWANk/X2QuaaR0JUhdgfiBBhDTwgZDEQwr0r3tVr7GfqivoSQk+uhO1LOfiAY001fZxnv1 fsn7ETFZ 2XPCZFU0gWTGuSltWrd/NqEOUhqeYTHrwNUIGPgJqSIEwNKyxWwXOt/7rzWUwP/JuKt/UmwubMd7Dr7YOtRYH3N+7Umn4k1j5jRfzrfAG5VXB3PO5VSahcJi2Xkmbyksu+m442XpqAdFSouEUGwIFdZOYMb/dnZCDtk6SsQLpI28VcUvKRhXHuVIvRzTLWfKfwQnzmiru1g5vbLTAkobiooioLN5/5/dhGL6DKCdRpDDufqUtZkLWXRlb6sq7L/f2BC1fc1vS05gtsu6OlIj4KHplu0loktINpcTXGI3qQv3eU40LhS2m0Sjj4maStIjHKQ94dG+NAG13ziTx/fmdCG+HMeUEf5leR98z5wcPHljXD46/3c+J3LD4X+G0hmsJlaMooSgjqxkB9HqV2sbpsCCYtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Sep 2023 15:19:41 +0800 Ze Zuo wrote: > Add a parameter "node_id" to zram to support storing pages on specific > node_id node memory. Please document this in Documentation/admin-guide/blockdev/zram.rst Should it be a group of nodes rather than a single one? If this feature is useful, people will want that. > Now, zram memory allocation is random, however in some cases, specifying > specific nodes for memory allocation for zram may have good effects. In > addition, when memory tier is supported, demotion can be achieved not > only through page migration, it is also possible to apply for memory by > specifying zram on low-speed device nodes, such as CXL memory devices, > and compressing pages to these devices through memory reclamation to > achieve similar effects to migration. Are any performance testing results available from using this feature?