From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6C9CA0FE1 for ; Fri, 1 Sep 2023 00:19:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44ABA280007; Thu, 31 Aug 2023 20:19:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D3448D0002; Thu, 31 Aug 2023 20:19:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24C96280007; Thu, 31 Aug 2023 20:19:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D8D68D0002 for ; Thu, 31 Aug 2023 20:19:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C8BBD4048D for ; Fri, 1 Sep 2023 00:19:22 +0000 (UTC) X-FDA: 81186119364.01.3DEA2A5 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 0E58140024 for ; Fri, 1 Sep 2023 00:19:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=fTRIenSu; dmarc=none; spf=pass (imf07.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693527560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wJr2TRCzYoBSC8ybEg+IVfuBxW+TOUi/yIcqDzlQM1o=; b=DYfVERoyRrq0Ot3/4LMMqX3oTYrAo9Ief0GSBjMuUH5L3oOYRagmVZOFdXzodw3u0A917W 7hwdsF6dBbgRb5x0ew7kfWATRl0sMw2SBI2DiwdEzfFMYTqLOzA+mirC+8z/YJVlreDKPv 918KdWO9x0R2I+80VZCo8LeXou4jMxU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=fTRIenSu; dmarc=none; spf=pass (imf07.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693527560; a=rsa-sha256; cv=none; b=j1mGZvrBQ41t++3At1vtwZjRSUVH/jadr4a+WJepQbnykEABh6+4sjr5TRsS/RLYQIfkIM zpGe8RguBBiwgiiLBIlyG83m+x7QX1UPPXkbPkgBkjIR5DlBdxTXelqKnfetN/NNM3HSKn OKpGPW4Tw0yVOCerEgUYvNMA8xn+LCw= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-792717ef3c9so51261939f.3 for ; Thu, 31 Aug 2023 17:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693527559; x=1694132359; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wJr2TRCzYoBSC8ybEg+IVfuBxW+TOUi/yIcqDzlQM1o=; b=fTRIenSuRTnJIQNDEzNaLIHYS98orOcyAqGPKrBo5gcAsB7RfkjvPIMkPMTrTV+3Ct Y9cQRSfDLWhSkGc5aIFQ0loFU1s7EQfdj1RTBRzYvSjxMe6U8eXkKXlDG0i3rjdQule4 eW9GeIn6JCM+kLMpACjqLo8mTFn/UDyyUVLgI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693527559; x=1694132359; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wJr2TRCzYoBSC8ybEg+IVfuBxW+TOUi/yIcqDzlQM1o=; b=OLtLhGsfbcr4DinwUigmv/z6EIEtQvQbGs7gGU2mopz9tU0WMFM9MV0uL77FEF1woh yKvLHogknoZG6uNDCTOajZ9oh+6jvRprxJkcpNTPm2OK5BqFrcL+VDZF4o1OvXYa3fyl 2A1fX3QGCjWr29jQn6548zRaVntQBEsz5VLXNnG4+bGaWi5vDWfYPRPS1PKPWclMjE4I IiWTnDdJayUFx6B4dcFA0xzyFZZsEMjDB1Y8VI5d4YmuDYw2cKTyTsDR7YB3zu46gSj8 v55P+0886qh+Z7asUpM7n94Y1zUpluZNwrTu3kXXoxDfmfGUn3VV+Mi+qouAVpVxKHw9 zDXg== X-Gm-Message-State: AOJu0YzxuolurgEdnY+Vivx+neHNq9lHCnEd3qE/SG9scdxJrjudWais qfRCydCww9OwVqqNO5hhqyE3oQ== X-Google-Smtp-Source: AGHT+IGb7sZBvvl51e4dQtJiZ/vDJ4zUjhxqO4U4boVBY5g2/wBMTeU1aw98BQ1Q8rg0Sy8onkXDRg== X-Received: by 2002:a6b:6a19:0:b0:790:a211:b95a with SMTP id x25-20020a6b6a19000000b00790a211b95amr923908iog.4.1693527559073; Thu, 31 Aug 2023 17:19:19 -0700 (PDT) Received: from localhost (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id t15-20020a05663801ef00b0041cd626ea0csm713150jaq.147.2023.08.31.17.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 17:19:18 -0700 (PDT) Date: Fri, 1 Sep 2023 00:19:17 +0000 From: Joel Fernandes To: Uladzislau Rezki Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, Zqiang , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v2 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Message-ID: <20230901001917.GA2723108@google.com> References: <20230831171827.2625016-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0E58140024 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ffmomo1shp1d5na45knh435g3owm9utd X-HE-Tag: 1693527559-261497 X-HE-Meta: U2FsdGVkX182OfY2NuHGCsr45I4ThbsoRcuWDIn9W/Le4rdnXY2r7B/xlUlU/8iesgu39rs5wr23m7ESWX9y/KUBgURMsSNJhD5USzJL/Q6HLyUcItVuQ1YuaGcwg6NoN7ddAkayHILM3W3CU+p6ZI2QcqaxdSabQaAs9vcA2S6AwJZk/2qRaYr7Y94DEoYfYtjEypzrzwAwApFPFxDqtPbX9qdLluoIOlpdKcouBrNkFFKjPJ2U1BZSEN+1tarvGBfeKa4AwpwzY3qc0gE6pnqca2Il6AKTXo4sb6gYefccJeSLCvL3Hs62JW9nxJn2A7+dvWVNnzS5TptLyTzdvAduyWrNQNYdakwhr54jE8d0TSFgg/8drBJmpCxDHrO6Gkz4uo3qJwApccMbPHhX0BIyAKZoAOlqW9yfhC/4gPgC/oU+40knYx7jConljv9W+EAh1KXdC6ZtemGgcl/0VRwisHo8H/iCepDM+aMq6qxU83OKRGxTndw+TSppHoYcq4hXu+weuyvWqnZglRIe3rPcAMBVZac81y8N12fUFbJ+O9RgTe/hPbeEfYokjlOlBcOObQrdjud4JYdFVju+kIVuSswFuxY9TcnN+XpaQJKlwA1nBCQR8kJhDz6ihFZrQOSZKU+g3vkXErwZSnuy4Jhi4VEUXwGUzt7st4OM9JirTzHioFBC94mMpMoTG4kGa9OA4zgvuoyoGig1d1VBRL0rXJD9ttUZ3kwtsa+nsQZF3JsvJNeQaVa4oPhvk9zjpXd75NbRneRcCKUnTgtIS6mEbF2BbtX1O5HFPd7B0x07WjI7TYU77R3nb2euz7knwW7TmX3y2TFTotg1XSNRwakkRLBdcn946HACAk+ohxaa41L1NnLPt4QEwvPSlntEQyHBmEVIEMz3DQeKGYNosYEjEKH0UDBWyIcI5vGrHDN5gZDNsygcAR9fEJhB66BX7YN1rg8qt8sZR8x2HeU ysI6Zvl0 hBax4IEKLOaaWAe8gL2/i3dBjhkEy84589Jh5OmL3QDTBYp4UcbRJeyEKw89Sm2hr/7CI2r+QoQ/oBFpeG+KqFeOBY+r1+iCQ2K0aZePKTWg2QFkfnreoIC10ZV5VWwY4GBUUV/vEGFNuogKrX/lXOtbhgG+j4BuNzwDJWgRvso4KT3/BW65qUpuMQ3p5FIb3EJ+ipq6JZKb030+hI6jqOsZxzdRmF+IHnQXxIwv5sdT/TPNkP1yCOo9pWm6F8qvphtYLoW4S4KIury6D/T3b9fHkBwAPRiWN5jCcPxeozjFdz7pPvmKXRjAaXpZISZMrVXJHUqLQR7kY5nByxe/oh17EVQTzdLxiuFU+feaRId7B0MWxuLUW4xQLlzBE9Trwr4/gMyTUt3rHyxSV6QWc4VdLLZ7ZHyjjD5yuTtRipm0esaMO4llFuxJEMrBXE4wyhvhrEOfdLtrtlcJmrHsA7k5Svjz7/l6pDsGjAX1Mb/CRhH1HHWGWnSUcdDudP+oQnaxsvkDeYOfInX159YXJBuzxZiE1tuSXAuE0IbwQBZDwXuD4cuk8OxXwC3AsfQy7Mx2PZyQg785muFlBoDDJM0uBZY+n4B5e2PTVkd/48IwxfhHpQAo/rFWASbe1IgUEN9KPzytYBYCSggOGHY7KIfilHeFWtlCxviOQzFFEP/ngbtrr+Z7iyehnEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 31, 2023 at 09:47:52PM +0200, Uladzislau Rezki wrote: > On Thu, Aug 31, 2023 at 05:18:25PM +0000, Joel Fernandes (Google) wrote: > > It is unsafe to dump vmalloc area information when trying to do so from > > some contexts. Add a safer trylock version of the same function to do a > > best-effort VMA finding and use it from vmalloc_dump_obj(). > > > > [apply test robot feedback on unused function fix.] > > > > Reported-by: Zhen Lei > > Cc: Paul E. McKenney > > Cc: rcu@vger.kernel.org > > Cc: Zqiang > > Reviewed-by: Matthew Wilcox (Oracle) > > Signed-off-by: Joel Fernandes (Google) > > --- > > v1->v2: Apply review tags and test robot feedback. > > > > mm/vmalloc.c | 39 ++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 38 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 93cf99aba335..f09e882ae3b8 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1865,6 +1865,20 @@ struct vmap_area *find_vmap_area(unsigned long addr) > > return va; > > } > > > > +#ifdef CONFIG_PRINTK > > +static struct vmap_area *find_vmap_area_trylock(unsigned long addr) > > +{ > > + struct vmap_area *va; > > + > > + if (!spin_trylock(&vmap_area_lock)) > > + return NULL; > > + va = __find_vmap_area(addr, &vmap_area_root); > > + spin_unlock(&vmap_area_lock); > > + > > + return va; > > +} > > +#endif > > + > > static struct vmap_area *find_unlink_vmap_area(unsigned long addr) > > { > > struct vmap_area *va; > > @@ -2671,6 +2685,29 @@ struct vm_struct *find_vm_area(const void *addr) > > return va->vm; > > } > > > > +/** > > + * try_to_find_vm_area - find a continuous kernel virtual area > > + * @addr: base address > > + * > > + * This function is the same as find_vm_area() except that it is > > + * safe to call if vmap_area_lock is already held and returns NULL > > + * if it is. See comments in find_vmap_area() for other details. > > + * > > + * Return: the area descriptor on success or %NULL on failure. > > + */ > > +#ifdef CONFIG_PRINTK > > +static struct vm_struct *try_to_find_vm_area(const void *addr) > > +{ > > + struct vmap_area *va; > > + > > + va = find_vmap_area_trylock((unsigned long)addr); > > + if (!va) > > + return NULL; > > + > > + return va->vm; > > +} > > +#endif > > + > > /** > > * remove_vm_area - find and remove a continuous kernel virtual area > > * @addr: base address > > @@ -4277,7 +4314,7 @@ bool vmalloc_dump_obj(void *object) > > struct vm_struct *vm; > > void *objp = (void *)PAGE_ALIGN((unsigned long)object); > > > > - vm = find_vm_area(objp); > > + vm = try_to_find_vm_area(objp); > > if (!vm) > > return false; > > pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", Hi Vlad, Thanks for taking a look. > I am not sure if this patch makes a lot of sense. I agree, this is a > problem and it mitigates it. But it is broken in terms of once you drop > the lock, the VA should not be accessed. Just to note the lockless-access issue you are referring to is not introduced by this patch but is rather in the existing code. Also just to note this is debug code. > Is that a real issue or it gets triggered due to some syntetic test case? It is a real issue. See 2/2. > If i were you, i would go with open-coded version of trylock. Because > there is only one user so far. Taking your open coding and locking suggestions, I came up with the below which actually results in a smaller patch. Does it look good to you? diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 93cf99aba335..aaf6bad997a7 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4274,14 +4274,31 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) #ifdef CONFIG_PRINTK bool vmalloc_dump_obj(void *object) { + void *caller, *objp = (void *)PAGE_ALIGN((unsigned long)object); struct vm_struct *vm; - void *objp = (void *)PAGE_ALIGN((unsigned long)object); + struct vmap_area *va; + unsigned long addr; + unsigned int nr_pages; - vm = find_vm_area(objp); - if (!vm) + if (!spin_trylock(&vmap_area_lock)) + return false; + va = __find_vmap_area((unsigned long)addr, &vmap_area_root); + if (!va) { + spin_unlock(&vmap_area_lock); return false; + } + + vm = va->vm; + if (!vm) { + spin_unlock(&vmap_area_lock); + return false; + } + addr = vm->addr; + caller = vm->caller; + nr_pages = vm->nr_pages; + spin_unlock(&vmap_area_lock); pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", - vm->nr_pages, (unsigned long)vm->addr, vm->caller); + nr_pages, addr, caller); return true; } #endif