From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85619C83F2C for ; Thu, 31 Aug 2023 03:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 992B58E0007; Wed, 30 Aug 2023 23:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 942478D0001; Wed, 30 Aug 2023 23:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A258E0007; Wed, 30 Aug 2023 23:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6F1D58D0001 for ; Wed, 30 Aug 2023 23:08:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 35FBC404A3 for ; Thu, 31 Aug 2023 03:08:56 +0000 (UTC) X-FDA: 81182917872.08.28BBB47 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 2A2011C0003 for ; Thu, 31 Aug 2023 03:08:52 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NxYkZeYG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693451334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VP69QQxs1+oAyVfloqKOcPYu2SdZ6W5UMwVp6UlcL9Y=; b=4o3Ezr5tUsxd9Cg1w74XZJo4RFkc3dHxjpfybJYv3DEhK7hlF0H1+y87awrFSj4TU68h8s zsZJj5fRZqav5xi/7FdhvdTcxY4CQcahOhMDEOcTvGFdm5uv3FfiRS074enU0naacEa8U9 1WLpSNjYrcqxj8iF1hEQTgdg/28klsA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NxYkZeYG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693451334; a=rsa-sha256; cv=none; b=UC3zKSqu4NG7o2854i9xj246fa6v6oTyuGmV7y/lVX3eBvLXxVNaTZ5MB21OSvr2KVe2KM ox2kz1IHYgcL9jwtqaYCgTHJNz3L3f40vst7PxAyXFEzTYwtNJWyY0ufZ8s7ck+O95lYd5 UJ+tclzf+/vM0Le+LKE21WeMH1FeD20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693451333; x=1724987333; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mYEk4LI2pL8XWPF1zKc5qz6vdX12xJGX7KbAifejJ34=; b=NxYkZeYGtQXNy6xgZrt1PTvvyh3FHR09AQThtCQVq6B50e3kTKtnmA0x 74x33niyxHh0ZrB+MwbnH8U6XsxuH+sw8J/nPQt/H7woosoN4LV8kyf+l HHLz9yzoAI8LhiLJxnsJ83yQsCWbmmWyYfKx2RQe3RsQeSU6WFeTl3Ni+ Td1aqZoFXbGwMk4OCC0fTI+RiLKsrRcZAorOhhBpq2aS7lNyzIxEyCHK6 s977Rzh9vEpPAOVNTwqnz5r71UkneYPaEifiYoLXJ3g6Nx/al4nTQ4fSN LpD4mt0StRNCkZeS+8ifH8aAulj0F+AbsGBJXi80cvV40UyQE+gt7hihO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="462175916" X-IronPort-AV: E=Sophos;i="6.02,215,1688454000"; d="scan'208";a="462175916" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 20:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="913042869" X-IronPort-AV: E=Sophos;i="6.02,215,1688454000"; d="scan'208";a="913042869" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 30 Aug 2023 20:08:47 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qbY34-000AWX-1Y; Thu, 31 Aug 2023 03:08:46 +0000 Date: Thu, 31 Aug 2023 11:08:43 +0800 From: kernel test robot To: Yosry Ahmed , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , Michal =?iso-8859-1?Q?Koutn=FD?= , Waiman Long , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: Re: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing for userspace reads Message-ID: <202308311025.538QuXBV-lkp@intel.com> References: <20230830175335.1536008-5-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830175335.1536008-5-yosryahmed@google.com> X-Rspamd-Queue-Id: 2A2011C0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dz7byu33e44zq14i3u44ncz4rsb4o39y X-HE-Tag: 1693451332-719261 X-HE-Meta: U2FsdGVkX1+zNTdbtrkF1SR+fqLzjNuPtbxZH2IKoS4Uk0SByH0W5FoYIx66jEdfMW3ap2ufDGPB2jYZIt4LOuSCUxdvMek0Z09/1neDdcWkSiZY8DRDEHn8kh0mizNDlMs8uhgt+A9t0RQsgMv+YHIm/ncEZlHttYo9FLhvoMJytwpo+bb295sRHdd0zNDvxccv9MpkHdMLnGavu1jvo2mWdnvhojNHX4I5SUBkxB1Kt4LMTlqbR0LrZDJsoEevvx+ETofCu355VWoHOEFF+ZkUUumizPRPvqyf/N+Aytqr2ieB+xOIkiMTiSMgiqfarkR3XCDI+uGsKlhxv+JO4jGgpM52OnQoA/G4PRPF6To60pCLEpETXU5DIJ4S0/lNZbj4g/RX8CtxO/wKN1gwOd+4mAz21rMzUyaVRQeBcS5bL4NsahnyJ8lAGN/bEoWJhciDRnVaoHUcuX2zE41N3JxUaBeCWM1llxTnFxl1PxTeJP7aas7rVhroj16w4RewZ4cTdLb5Ovj4IYpx34gL/SD2zZRk9XMM9jx7t7nn9qrTGyo7o+WDz3RAnB5uDMnLFio6WvZDK06DHwUGV29bpXB5MkgUSSu3syx1/3CcPsU2M7eJWV+X6kcLtOpuiHA+xOdPzt6ydni8bupK+nZZ8vtEFkkt29pjmJ/2zvZKWRdEGSUv0wlxhKxDG4iAuRzLjaUQA1ipVVAPlST6zGpWIuatMEk4vASSW8MKBpcrxvr2QjVnSPcZ7ix7OmnkMWGKq3LYBtw25Nlkc4jiGsDAMxoDrcorgo1TEDD6TYIu2cATi8JPJcIVBQAsNMwCPbL5hbebIikeGyofIoAukcLH1lJj58U5x8ltUNlA+YOXc0XG2gj1m/4jF+mlHsdH85M5Gyon11cddxBDGl5+KO37g9MhnKshRQm4IOJLL+d9QhERsid/8zjJqHSfSD6Rcy5DCJz8yYOH72Iu4waEBke /+EJk+SW KQTZszCUHRC0rKFGP7Tn+JSs2DB+Etol1he9dJhov460vVznxfgSdOhltrkyJ7wnaZdaqnH7nbWbLLYn8L3xN/7Btra3H9X/Ejnp7AaV2ausLz2LMxivLdJggULf27eH6Y4FP6hWyl43iqT6fEjVhdS5zvIPv/oa8G5JfIJJ9b1WwGHNp8IVzt7gkhvdNgzBXEntHTR7U8fMybYbO69/B0UMAzQ0jIsbz7+d0rtnVgCEdqd+t+pKocsFSXKx3saiyMQL4vsNhbKNJNo1c9UeuL6MZPcHR5TS7FJ2v/75ocaJQdncQa440fYZqezSloN3lxAMso9I5HkxukYrTV/SkCHj6/0XhaezjmoTfxHsca8wuv7Vv1k4d50C4xKnLDvJ2Mv3bkxNQ+Yzqa/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master next-20230830] [cannot apply to v6.5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-memcg-properly-name-and-document-unified-stats-flushing/20230831-015518 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230830175335.1536008-5-yosryahmed%40google.com patch subject: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing for userspace reads config: i386-randconfig-r013-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311025.538QuXBV-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311025.538QuXBV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308311025.538QuXBV-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/memcontrol.c:667:6: warning: no previous prototype for function 'mem_cgroup_user_flush_stats' [-Wmissing-prototypes] void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) ^ mm/memcontrol.c:667:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) ^ static 1 warning generated. vim +/mem_cgroup_user_flush_stats +667 mm/memcontrol.c 658 659 /* 660 * mem_cgroup_user_flush_stats - do a stats flush for a user read 661 * @memcg: memory cgroup to flush 662 * 663 * Flush the subtree of @memcg. A mutex is used for userspace readers to gate 664 * the global rstat spinlock. This protects in-kernel flushers from userspace 665 * readers hogging the lock. 666 */ > 667 void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) 668 { 669 mutex_lock(&stats_user_flush_mutex); 670 do_stats_flush(memcg); 671 mutex_unlock(&stats_user_flush_mutex); 672 } 673 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki