From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71D2C6FA8F for ; Thu, 31 Aug 2023 00:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 119A18E0001; Wed, 30 Aug 2023 20:41:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CA738D0001; Wed, 30 Aug 2023 20:41:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFBC08E0001; Wed, 30 Aug 2023 20:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DCA578D0001 for ; Wed, 30 Aug 2023 20:41:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AEA621A0472 for ; Thu, 31 Aug 2023 00:41:44 +0000 (UTC) X-FDA: 81182546928.14.E9BE13B Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 6BA4840010 for ; Thu, 31 Aug 2023 00:41:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uyl1LU7T; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693442502; a=rsa-sha256; cv=none; b=ORLoNPfYz4Us9eH2cjSoZx0k0CP4zjt2B5QVnq6TB3W2wBRy2WyPQ8ollZCz0XEqCw7YOh VAjT8gEypAi1NVcsenLJAA/TNf3W4ayICINfMOW9LQL5Z3KCkEyc+jDSx9cI37pb9claPY BVmC6bwZssO+lNmwL3QcqFNXmLeqrvY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uyl1LU7T; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693442502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pu/MgjqHj2bBGv2mzSqRR8TxfH7GxoseQ23yVUaP2sw=; b=HdOssG7BIeKC03IubrmnW1LBgPB7Kr5ZhACHp7ciEIKFEhNdPOAXgk2Ohd9GvB8X5VPEHJ wsawGKbJ8VeqMIo4M3k5wNqMxbKptiLHHkbZg7GzLUZzvqGNGrU4uBeqQ7XQlIj5qA4VOx UUbe2P11440ohp5DTb8Y/3e6u9F0Wtc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693442501; x=1724978501; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E0Kpa3glzmhOit+Gfb9EdvlhhILV82Bjg5COBTCvIV4=; b=Uyl1LU7TEk8BgN3lD2BRRl1nOR8Y8l3hUEetaIMm54j6KcLRv65tOYdl 0CjT9l6Ifj9jTRVals1NzhRV7b/ps9Lss49AWkRESN7IFZBTFdrptXofP s+JIzDsFc/OnCPBQBRo8CEUAl4J1Yqt68k37SFGOsCSO9OvT9oIRC2OKE 50oRpvUFRCRdQk6i+onkgTLIMxMvhftIc8TnJd3DuTTV5ZRB5NL479Nq5 NcSeQjDWJJhqE8Z+vEYwkM1pbEUR0/MsOcGFz89Mi5dsSGLid0oVaBVPq tlQ12YPhFYk9gx77VXqRRBHXHDmvVptYh96vQNbDJ2MBLjYEFlbZg+H6m Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="462160107" X-IronPort-AV: E=Sophos;i="6.02,215,1688454000"; d="scan'208";a="462160107" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 17:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="774290764" X-IronPort-AV: E=Sophos;i="6.02,215,1688454000"; d="scan'208";a="774290764" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 30 Aug 2023 17:41:35 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qbVkd-000APv-0I; Thu, 31 Aug 2023 00:41:35 +0000 Date: Thu, 31 Aug 2023 08:40:39 +0800 From: kernel test robot To: Yosry Ahmed , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , Michal =?iso-8859-1?Q?Koutn=FD?= , Waiman Long , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: Re: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing for userspace reads Message-ID: <202308310858.19VshX68-lkp@intel.com> References: <20230830175335.1536008-5-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830175335.1536008-5-yosryahmed@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6BA4840010 X-Stat-Signature: r3cftfeqqoonprrhuqw8e3y8sz1u7aey X-Rspam-User: X-HE-Tag: 1693442501-155863 X-HE-Meta: U2FsdGVkX1/vKoS7T0z7LAF2G5q73wL4uyVPQJldFVfQDPfUns6rzd28gleJoGguCVjHCPT7rTOq3CivT02/p3SSid4yywkG9/q+zvmIaDi7a2SzDcYak5jZbsoQrfjIVw+jKdNK7NgENMn7w+D5nHG2aQRIe+6koK4v/VRX4BIJxQzHcIveh+axzcD+tpxv56yXWLa46N1J+ybp/ABCAdS11OFc2UOrzxpCl5nBJ0+nLtL1cXQF70N87dnmw3y8PLld8gg+aMuV4MQfUNBn+zR/T0kzfmWIu6LE8M5rNlRq3WUylr/9uw6OFA5fM1YH5/c/YPpqVaoguBZbNUomqTygBZ/XIAdiqM1Ru6UrU1LTqRuq2nFx6Y2IB3DwPbocqVfgeXdreiMk4TbHcVF76kJVglQ+LWIWQEwBi5gT4yIElILC3NR9OsdcsLX4x1IaDlXz4VtwV5KobjiKHI2pTgcQILEb1Vw7SVYl3vliZxcwVqbEsUDz5kSmIU1L6/rlQGf4j6z90CmgDiD64kNUwpBdBE/yU7LsiVr6jodK2f/riMQGkPYl1c3bapgEOxAm4SeuoiUSVzuDp4hiHowzh5XgMTGWXGrPFu+iZe0gMIhGQZ7FlA+2BwB2RT+bY35tF6UHrEf8HpowkSL3tYkdXzPk+mrXmYJ9d+HgXyIJ/gWh8SqjxkFUJWv8jw2KhpQ6f5i9/aMno5mGgizxX3unlkWPtQHilFegZ1bMEPrKKxqUroTkE+l0jBmkK9ZftzmQbCxxqEycAXLbPsqdXR7hGwvp/ZNRfBlGZVCMpoQZnfYRNPHZmnNtVDf4DIcYhjGPnl2cmodVBJ+FtpN0c5xmwwXGBkk1JEdJA2y/56cqMnDtyWJltkiA527nKe2VnI5+9RqZAAQ3x3BkYHmaAD3dcFfDm7fZRe+DY8eJrX61zjzv2/UVAZ2CojwjY+3R1RTXuN+FkSndR2x701MzW2X NMEXggI3 qeqzT9Gzy/7hattXWQ07o0pa9q/2GeO0Ps40Yh9zN4BBdS6QUsR7k+TjOpe632F149pcitF7BgY3oaVrOR0buA1crgPdnQ35HjKDlhPmV9wMNhPjfU894PMaVBS+IQ2FTQ4XphZGkoRJ7tdqYhR8fI/K7mIDaKi0YjwZQ3mkzFLoc4DpZGtSsXjcfmMUa02z2k9bQZpf5e+FlpbjVDwM9Skiy1dRsZyJVgX88rt/8TcWccGJar1GZzrSOZ+CTrPkdEHALnFRPqrKDAor9MDdZfY5h3vXPlMg5Ems76KIPJL9gDjFKTaBOqXXWA1GvNBtiFs8KX6e3eJohJUqKOJIOKKEhq8rKTqIDw5zD3C3JwqXdYwkMRNKOL6z7avAGq9htk6ZnNFH+ckwra5M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master next-20230830] [cannot apply to v6.5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-memcg-properly-name-and-document-unified-stats-flushing/20230831-015518 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230830175335.1536008-5-yosryahmed%40google.com patch subject: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing for userspace reads config: m68k-randconfig-r016-20230831 (https://download.01.org/0day-ci/archive/20230831/202308310858.19VshX68-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308310858.19VshX68-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308310858.19VshX68-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/memcontrol.c:667:6: warning: no previous prototype for 'mem_cgroup_user_flush_stats' [-Wmissing-prototypes] 667 | void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/mem_cgroup_user_flush_stats +667 mm/memcontrol.c 658 659 /* 660 * mem_cgroup_user_flush_stats - do a stats flush for a user read 661 * @memcg: memory cgroup to flush 662 * 663 * Flush the subtree of @memcg. A mutex is used for userspace readers to gate 664 * the global rstat spinlock. This protects in-kernel flushers from userspace 665 * readers hogging the lock. 666 */ > 667 void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) 668 { 669 mutex_lock(&stats_user_flush_mutex); 670 do_stats_flush(memcg); 671 mutex_unlock(&stats_user_flush_mutex); 672 } 673 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki