From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43780C83F12 for ; Thu, 31 Aug 2023 11:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FDFE8D000C; Thu, 31 Aug 2023 07:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AE468D0001; Thu, 31 Aug 2023 07:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 675BB8D000C; Thu, 31 Aug 2023 07:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 576BA8D0001 for ; Thu, 31 Aug 2023 07:34:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 29BC2B2A48 for ; Thu, 31 Aug 2023 11:34:39 +0000 (UTC) X-FDA: 81184192278.14.D7CBFE4 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by imf20.hostedemail.com (Postfix) with ESMTP id E110A1C002A for ; Thu, 31 Aug 2023 11:34:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=ptVy0Liv; dmarc=pass (policy=quarantine) header.from=microchip.com; spf=pass (imf20.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693481677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rVezkmxiPctV4+yNso6COWfB1cp+m9J9ENCJeuoCP5A=; b=Fws/9rB12dEf+/NsR5+vGZA16hrXauln2VkWOtn/U+RcTBqwCnaOkX6kIwr5n8Wooxl3IH 5r6Oz5KYwzSpH2xntkXkZcIJus7dW3pjzFSvrtkm0BbxDH+5OUnlusNHNTIibKp5YsrwId OU9E0bwXj5hsGjINS9POKml50USqspY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=ptVy0Liv; dmarc=pass (policy=quarantine) header.from=microchip.com; spf=pass (imf20.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.154.123 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693481677; a=rsa-sha256; cv=none; b=HQd7kkMkzCQdjNeCeHi5/1o2T+nTwT9CbquUHusPfuHaVeSPro4vehAQutfkCyaBcvThjc /qzS9w5MCl0+qZbOhBi6Ew2ZNU90D74jd5ZD4+p1P25GVBbw/87yN0ksljNrgI3aVysFyx lbq8WlnLxauBw/Rgb/z28Sg/9p78dEs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1693481676; x=1725017676; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aFapu2wzHsQUwh9wHN+w40P5tsB+oKfwhLNA8baR4Ic=; b=ptVy0LivHPO9cQ6vx2M1EnSn29J9M11LORsY6rAqJ7Vanj64gW7Ds1y4 CKQfb81R7i453Dx5m0dDsuDug/4kU03w4c02+7eEYrx82w0MD0BBMytkM 2XQR3I3/377aCZOIxyNp+qRRvJCosksFnt/ye1rUrfr/Vl9L5arMZwZ8/ Z2yQfgbSnjV/kE6fMVSZWKSr514NbTpmAeqyVYPeTz0QwWNmE66+96stE RxubUcGaiW7p0bIPMuOMr2hUazd7dl4WKk4lr3Vr1t+RvbSF15nbWqp7D q9lXRI5Kp7xEkJkaRGLS5SVfNb+rQeDDfpI5MwrppzRHPMv9fe7xQoUx2 Q==; X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="asc'?scan'208";a="169242918" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 31 Aug 2023 04:34:33 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 31 Aug 2023 04:34:31 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 31 Aug 2023 04:34:30 -0700 Date: Thu, 31 Aug 2023 12:33:47 +0100 From: Conor Dooley To: "Lad, Prabhakar" CC: Geert Uytterhoeven , kernel test robot , Lad Prabhakar , , Linux Memory Management List , Palmer Dabbelt Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known Message-ID: <20230831-imperial-surviving-afdf6d275388@wendy> References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="urOk9nLuj+RcA2yU" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E110A1C002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yydej8h4hqpd978u934x4ayzipkc3kaj X-HE-Tag: 1693481676-342802 X-HE-Meta: U2FsdGVkX19tE4c5i4qGhwBXpGCg2vVE9VJgoUI8KSRrlIb5HY9rt/HH0nhv3ycggXf+lFJ/i34AoRBIEmgDTGJ88oACe/9d5GRGfZuQQP6DKg0zYQZAYuzi/Ol5gQkxeqb+SVXy4Ucx/plahE6gxq093UkINJegslav6Xz5W7bWbTOCqpo8xZWirO4o8SbXQbRxGnVqVZRlpwJ9dEZyFYHwNonPBDVpXSnftWdzJaTrd34sehvWTAqwIHWVHle0btlWSvtrbS+llXx50PsgcBu2d/Q9arx4kLgp5rlMiq5M/BVFz6czwMQjFcskYvglfm8CBBodwnXm5erNhNu0Tb2TAA8bE/BYoMrSSfCQRZyptNiaUuHbXTCHksXTtKO1RXYO0HVwpZT9EIzTQ7/onoMJ4gFI/pOc/Gsw7ByRvOmmA83X1s10HuIY5AAlIs9rueRC5BBIIS/lBC/uOUHuEppLzk0C9izlCq/RAmn5vj9kmBjsZRqlA5BD/s0OpBCL173oF7fsaXGpfMFppEFdp2Md06iAudc9q9Z2N9Eag8mIf6GeDOjC8ba4TTtJKkOcq9F8D5KulGpG61VyyIVkmP/6i5wgKbtmQvjxWPZEwRZhN5davDFLiLZ6yv/SZU7iqH0FVb4yVsZL/TEZmerMZcsCco+thO+ULPpXN066Kuy8CYL+1qGBDMesbIO48CRSUNC0MRAFiBETLaqvB7aHghy8lAM9J0FhB4LJYaWpuZPCInp5Myg8SSyLG+JlsO7mrF/+Nuts/ZD0XIRNoFe9ojVv6oyOBRZERmpjk4uY6a9zPjkUzfQ75U2n3ELiQTcYNa1U7Y4fHp8Rz/1FOyr7W9E5Xlbe3BmjWLTXtP7xCGRaibVzXsemVTA6nsI3wWdhB+r5XX/eEaLRL5qSLyjDLHwyftes3W/2iMrXeKrHHRidW3UIIOiMn4yup37Hcu9PvmiKOUnRBID3SXDksw1 q3UuR2u4 2qKVwPgdms4Anm1rI+TDsgIYX1jrzG9z8pnNN3YNQHbsDKq/FCQMpWUP9c9erqIs5bLU6pRGLNdITEf8gmE17IWVVI0GalkSrOflFBYSpUlTMl23wE0O7+DA3nE+mzE5qKmp+B2RrTmIgELMfbSYi3aJUHY01Ob/SzA+zTr+TcLuaovcr3+JQ8xn6Y4jRShKAO556WRpil5AgR8PmwubO/SrPMLhXBiulnJHzw7mD3MDUa53LuQwGzYD8YmxWkUxcUGyYjUDsj/YxDk4i81PFL73jbqUGDqOnRzGJ7dcEMQm7m4KS58qL81eP2qQ9dRtj9ECtJBWCM/vAVZOyCNXcYHa1VhCAkFUqP+xMT0mjxlFSfTyjkdAxJBf1YNXXsMG9DrnwiqaS1SL0L7fbCs34x77rNX5gnjY2wKAauX1SEaqICpKVr/6ZA+SWP+dbAO9oU1zIJo8PKVk1Sv0gxVbp32IeyR9aLWZqnGQZOVIq/kO3HZ+EqO3z+lojgGOLWhMXVeFGy89PBIy1Z3itllgnOiEcn+tg4xZipJBGnypQsImhC3vT+tTRvgcdm5brVS7I598x+wTlHzIKTbZAahDWDpyOng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --urOk9nLuj+RcA2yU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 31, 2023 at 12:22:50PM +0100, Lad, Prabhakar wrote: > Hi Conor, >=20 > On Thu, Aug 31, 2023 at 10:44=E2=80=AFAM Conor Dooley > wrote: > > > > On Thu, Aug 31, 2023 at 04:52:00PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne= xt.git master > > > head: a47fc304d2b678db1a5d760a7d644dac9b067752 > > > commit: f2863f30d1b05e5ecf61c063609cb974954d47f8 [13230/13643] riscv:= errata: Add Andes alternative ports > > > config: riscv-randconfig-001-20230831 (https://download.01.org/0day-c= i/archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/config) > > > compiler: riscv64-linux-gcc (GCC) 13.2.0 > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/a= rchive/20230831/202308311610.ec6bm2G8-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new = version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8= -lkp@intel.com/ > > > > > > All error/warnings (new ones prefixed by >>): > > > > > > arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_work= around': > > > >> arch/riscv/errata/andes/errata.c:29:23: error: storage size of 're= t' isn't known > > > 29 | struct sbiret ret; > > > | ^~~ > > > >> arch/riscv/errata/andes/errata.c:35:15: error: implicit declaratio= n of function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] > > > 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_S= BI_EXT_IOCP_SW_WORKAROUND, > > > | ^~~~~~~~~ > > > >> arch/riscv/errata/andes/errata.c:29:23: warning: unused variable '= ret' [-Wunused-variable] > > > 29 | struct sbiret ret; > > > | ^~~ > > > cc1: some warnings being treated as errors > > > > > > > > > vim +29 arch/riscv/errata/andes/errata.c > > > > > > 26 > > > 27 static long ax45mp_iocp_sw_workaround(void) > > > 28 { > > > > 29 struct sbiret ret; > > > 30 > > > 31 /* > > > 32 * ANDES_SBI_EXT_IOCP_SW_WORKAROUND SBI EXT che= cks if the IOCP is missing and > > > 33 * cache is controllable only then CMO will be = applied to the platform. > > > 34 */ > > > > 35 ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDE= S_SBI_EXT_IOCP_SW_WORKAROUND, > > > 36 0, 0, 0, 0, 0, 0); > > > 37 > > > 38 return ret.error ? 0 : ret.value; > > > 39 } > > > 40 > > > > Looks like the config doesn't enable SBI, so ERRATA_ANDES_CMO will need > > to grow a dependency on RISCV_SBI. > I think adding dependency for RISCV_SBI on ERRATA_ANDES would be a good i= dea. >=20 > While at it I am seeing below warnings with this randconfig: > WARNING: unmet direct dependencies detected for ERRATA_ANDES_CMO > Depends on [n]: ERRATA_ANDES [=3Dy] && MMU [=3Dn] && ARCH_R9A07G043 [= =3Dy] > Selected by [y]: > - ARCH_R9A07G043 [=3Dy] && SOC_RENESAS [=3Dy] && RISCV [=3Dy] >=20 > WARNING: unmet direct dependencies detected for AX45MP_L2_CACHE > Depends on [n]: RISCV_DMA_NONCOHERENT [=3Dn] > Selected by [y]: > - ARCH_R9A07G043 [=3Dy] && SOC_RENESAS [=3Dy] && RISCV [=3Dy] > configuration written to .config >=20 > *** End of the configuration. > *** Execute 'make' to start the build or try 'make help'. >=20 > For which I will send the below fix: > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -334,10 +334,10 @@ if RISCV > config ARCH_R9A07G043 > bool "RISC-V Platform support for RZ/Five" > select ARCH_RZG2L > - select AX45MP_L2_CACHE > + imply AX45MP_L2_CACHE > select DMA_GLOBAL_POOL > - select ERRATA_ANDES > - select ERRATA_ANDES_CMO > + imply ERRATA_ANDES > + imply ERRATA_ANDES_CMO > help > This enables support for the Renesas RZ/Five SoC. I've only ever heard bad things from Arnd about using imply. Why don't you just make the erratum config option select RISCV_DMA_NONCOHERENT, just like the THEAD_CMO erratum does? The cache driver should probably then depend on the erratum Kconfig option, since there's no point in having it otherwise? --urOk9nLuj+RcA2yU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZPB6mwAKCRB4tDGHoIJi 0kGvAP9ybdfClhDRmiBy0YULH+tI/yizqM4J7yaSTXrF74by7AEAxMFWW1R0xEiF jg+FaeKo7shHTcbzeUNwYCBQYEE0YgQ= =0b9u -----END PGP SIGNATURE----- --urOk9nLuj+RcA2yU--